From owner-svn-src-all@FreeBSD.ORG Wed May 15 13:42:18 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 2EC3A382; Wed, 15 May 2013 13:42:18 +0000 (UTC) (envelope-from dim@FreeBSD.org) Received: from tensor.andric.com (tensor.andric.com [IPv6:2001:7b8:3a7:1:2d0:b7ff:fea0:8c26]) by mx1.freebsd.org (Postfix) with ESMTP id E915DE94; Wed, 15 May 2013 13:42:17 +0000 (UTC) Received: from spaceball.andric.com (spaceball.andric.com [IPv6:2001:7b8:3a7:0:204:4bff:fe01:de8a]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by tensor.andric.com (Postfix) with ESMTPSA id E69835C44; Wed, 15 May 2013 15:42:13 +0200 (CEST) Message-ID: <519390B6.2060500@FreeBSD.org> Date: Wed, 15 May 2013 15:42:14 +0200 From: Dimitry Andric Organization: The FreeBSD Project User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:21.0) Gecko/20100101 Thunderbird/21.0 MIME-Version: 1.0 To: Brooks Davis , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r250658 - in head: share/mk sys/conf tools/build/options References: <201305151304.r4FD4B1i032146@svn.freebsd.org> In-Reply-To: <201305151304.r4FD4B1i032146@svn.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 May 2013 13:42:18 -0000 On 2013-05-15 15:04, Brooks Davis wrote: > Author: brooks > Date: Wed May 15 13:04:10 2013 > New Revision: 250658 > URL: http://svnweb.freebsd.org/changeset/base/250658 > > Log: > Add a new option WITHOUT_FORMAT_EXTENSIONS to disable flags related to > checking our kernel printf extensions. This is useful to allow > compilers without these extensions to build kernels. As I have written before, please let us consider this to be a band-aid, and aim to remove non-standard printf specifiers from our kernel sources. Otherwise we will lose most of the advantages of format checking... :-( > --- head/share/mk/bsd.own.mk Wed May 15 08:38:49 2013 (r250657) > +++ head/share/mk/bsd.own.mk Wed May 15 13:04:10 2013 (r250658) > @@ -268,6 +268,7 @@ __DEFAULT_YES_OPTIONS = \ > ED_CRYPTO \ > EXAMPLES \ > FLOPPY \ > + FORMAT_EXTENSIONS \ Spelled as 'extensions' here... > Modified: head/sys/conf/kern.mk > ============================================================================== > --- head/sys/conf/kern.mk Wed May 15 08:38:49 2013 (r250657) > +++ head/sys/conf/kern.mk Wed May 15 13:04:10 2013 (r250658) > @@ -5,7 +5,7 @@ > # > CWARNFLAGS?= -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes \ > -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual \ > - -Wundef -Wno-pointer-sign -fformat-extensions \ > + -Wundef -Wno-pointer-sign ${FORMAT_EXTENTIONS} \ ...but as 'extentions' here... > +# External compilers may not support our format extensions. Allow them > +# to be disabled. WARNING: format checking is disabled in this case. > +.if ${MK_FORMAT_EXTENSIONS} == "no" > +NO_WFORMAT= -Wno-format > +.else > +FORMAT_EXTENTIONS= -fformat-extensions and here. -Dimitry