From owner-freebsd-hackers@FreeBSD.ORG  Mon Aug 23 12:40:28 2010
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1B81110656BA;
	Mon, 23 Aug 2010 12:40:28 +0000 (UTC) (envelope-from jhb@freebsd.org)
Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42])
	by mx1.freebsd.org (Postfix) with ESMTP id DEC388FC2D;
	Mon, 23 Aug 2010 12:40:27 +0000 (UTC)
Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net
	[66.111.2.69])
	by cyrus.watson.org (Postfix) with ESMTPSA id 884F246B17;
	Mon, 23 Aug 2010 08:40:27 -0400 (EDT)
Received: from jhbbsd.localnet (smtp.hudson-trading.com [209.249.190.9])
	by bigwig.baldwin.cx (Postfix) with ESMTPSA id B91DC8A04E;
	Mon, 23 Aug 2010 08:40:26 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-hackers@freebsd.org
Date: Mon, 23 Aug 2010 08:07:59 -0400
User-Agent: KMail/1.13.5 (FreeBSD/7.3-CBSD-20100819; KDE/4.4.5; amd64; ; )
References: <AANLkTi=CB4eyZPsj+NdFfYo3bhQ-P=1icnxAHx3VaT+n@mail.gmail.com>
In-Reply-To: <AANLkTi=CB4eyZPsj+NdFfYo3bhQ-P=1icnxAHx3VaT+n@mail.gmail.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201008230807.59582.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1
	(bigwig.baldwin.cx); Mon, 23 Aug 2010 08:40:26 -0400 (EDT)
X-Virus-Scanned: clamav-milter 0.95.1 at bigwig.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00 autolearn=ham
	version=3.2.5
X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx
Cc: hackers@freebsd.org, Garrett Cooper <gcooper@freebsd.org>
Subject: Re: Question about printcpuinfo in sys/amd64/amd64/indentcpu.c
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 23 Aug 2010 12:40:28 -0000

On Friday, August 20, 2010 10:14:46 am Garrett Cooper wrote:
> Hi,
>     Currently the code in identcpu.c does a check for a specific cpu
> value extension. This is set to 0x80000004 (even though the
> corresponding code below iterates through 0x80000002:0x80000005):

It does not invoke 0x80000005 (<, not <=, is used as the loop terminator).

>         /* Check for extended CPUID information and a processor name. */
>         if (cpu_exthigh >= 0x80000004) {
>                 brand = cpu_brand;
>                 for (i = 0x80000002; i < 0x80000005; i++) {
>                         do_cpuid(i, regs);
>                         memcpy(brand, regs, sizeof(regs));
>                         brand += sizeof(regs);
>                 }
>         }

-- 
John Baldwin