From owner-cvs-all@FreeBSD.ORG Tue Apr 10 07:12:58 2007 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6EE5916A401; Tue, 10 Apr 2007 07:12:58 +0000 (UTC) (envelope-from grog@lemis.com) Received: from ozlabs.org (ozlabs.org [203.10.76.45]) by mx1.freebsd.org (Postfix) with ESMTP id 2F0D213C44C; Tue, 10 Apr 2007 07:12:58 +0000 (UTC) (envelope-from grog@lemis.com) Received: from wantadilla.lemis.com (wantadilla.lemis.com [192.109.197.135]) by ozlabs.org (Postfix) with ESMTP id D070CDDF13; Tue, 10 Apr 2007 17:12:56 +1000 (EST) Received: by wantadilla.lemis.com (Postfix, from userid 1004) id 9C6D71A9C97; Tue, 10 Apr 2007 16:42:56 +0930 (CST) Date: Tue, 10 Apr 2007 16:42:56 +0930 From: Greg 'groggy' Lehey To: Dag-Erling =?iso-8859-1?Q?Sm=F8rgrav?= Message-ID: <20070410071256.GJ91694@wantadilla.lemis.com> References: <200704090219.l392Jc1f064727@repoman.freebsd.org> <864pnpdf8w.fsf@dwp.des.no> <20070410010901.GD61460@wantadilla.lemis.com> <86zm5gr9wl.fsf@dwp.des.no> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="Tu8ztk+XgTAiG9Id" Content-Disposition: inline In-Reply-To: <86zm5gr9wl.fsf@dwp.des.no> User-Agent: Mutt/1.4.2.1i Organization: The FreeBSD Project Phone: +61-8-8388-8286 Fax: +61-8-8388-8725 Mobile: +61-418-838-708 VoIP: sip:0871270137@sip.internode.on.net WWW-Home-Page: http://www.FreeBSD.org/ X-PGP-Fingerprint: 9A1B 8202 BCCE B846 F92F 09AC 22E6 F290 507A 4223 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/touch touch.1 touch.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2007 07:12:58 -0000 --Tu8ztk+XgTAiG9Id Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tuesday, 10 April 2007 at 9:00:42 +0200, Dag-Erling Smrgrav wrote: > Greg 'groggy' Lehey writes: >> On Monday, 9 April 2007 at 12:16:47 +0200, Dag-Erling Smrgrav wrote: >>> The latter part is incorrect and should be reverted. Furthermore, >>> usage() should be static. >> Can you give details? > > usage() should be the way it was before your commit, except that it > should be static. You mean declared as a static function? In a program of a single file? As I said before, >> Can you give details? Specifically, this doesn't match my recollection of "good practice". Where is this behaviour mandated? Greg -- See complete headers for address and phone numbers. --Tu8ztk+XgTAiG9Id Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.3 (FreeBSD) iD8DBQFGGzj4IubykFB6QiMRAi+zAJ98xLoMwjfY3URKa8eBwrGUade7MwCcDi5J k8zVcKTxpg9rFwe5Z/ROGmw= =PQqg -----END PGP SIGNATURE----- --Tu8ztk+XgTAiG9Id--