From owner-freebsd-hackers@FreeBSD.ORG  Mon Jul 21 09:57:41 2003
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 617A437B408
	for <hackers@freebsd.org>; Mon, 21 Jul 2003 09:57:38 -0700 (PDT)
Received: from ussenterprise.ufp.org (ussenterprise.ufp.org [208.185.30.210])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DE3FC43FA3
	for <hackers@freebsd.org>; Mon, 21 Jul 2003 09:57:36 -0700 (PDT)
	(envelope-from bicknell@ussenterprise.ufp.org)
Received: from ussenterprise.ufp.org (bicknell@localhost [127.0.0.1])
	by ussenterprise.ufp.org (8.12.9/8.12.9) with ESMTP id h6LGvZ8i056811
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Mon, 21 Jul 2003 12:57:35 -0400 (EDT)
Received: (from bicknell@localhost)
	by ussenterprise.ufp.org (8.12.9/8.12.9/Submit) id h6LGvZFx056810;
	Mon, 21 Jul 2003 12:57:35 -0400 (EDT)
Date: Mon, 21 Jul 2003 12:57:35 -0400
From: Leo Bicknell <bicknell@ufp.org>
To: Tim Kientzle <kientzle@acm.org>
Message-ID: <20030721165735.GA56766@ussenterprise.ufp.org>
Mail-Followup-To: Tim Kientzle <kientzle@acm.org>,
	hackers@freebsd.org
References: <3F1B0610.90803@acm.org>
	<20030720225041.GA26277@ussenterprise.ufp.org> <3F1C0C91.6050203@acm.org>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s"
Content-Disposition: inline
In-Reply-To: <3F1C0C91.6050203@acm.org>
Organization: United Federation of Planets
X-PGP-Key: http://www.ufp.org/~bicknell/
cc: hackers@freebsd.org
Subject: Re: Correct way to call execve?
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 21 Jul 2003 16:57:43 -0000


--SLDf9lqlvOQaIe6s
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

In a message written on Mon, Jul 21, 2003 at 08:53:53AM -0700, Tim Kientzle=
 wrote:
> Actually, this example passes -Wall if you declare
> "execargv" as simply "char *[]".  However, I'm looking
> for something that passes gcc -Wwrite-strings, which this
> example does not.

% cat exec.c

#include <unistd.h>
#include <paths.h>

int main(int argc, char *const argv[], char *const envp[]) {
  char *execargv[2];

  execargv[0] =3D (char *)_PATH_BSHELL;
  execargv[1] =3D (char *)NULL;

  execve(_PATH_BSHELL,execargv,envp);

  return 0;
}
% cc -Wwrite-strings exec.c
% cc -Wall exec.c

Looks good to me.

--=20
       Leo Bicknell - bicknell@ufp.org - CCIE 3440
        PGP keys at http://www.ufp.org/~bicknell/
Read TMBG List - tmbg-list-request@tmbg.org, www.tmbg.org

--SLDf9lqlvOQaIe6s
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.1 (FreeBSD)

iD4DBQE/HBt/Nh6mMG5yMTYRAireAKCGpkL4F+HaO2EtLIf0SkvxE+dINACVFkIC
CAF2RcO7TZpZJAmjuExIGQ==
=ymiB
-----END PGP SIGNATURE-----

--SLDf9lqlvOQaIe6s--