From owner-freebsd-ports-bugs@freebsd.org Wed Jun 15 14:07:28 2016 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CEAEFA31FCF for ; Wed, 15 Jun 2016 14:07:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id ACEA51671 for ; Wed, 15 Jun 2016 14:07:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id u5FE7SXE058380 for ; Wed, 15 Jun 2016 14:07:28 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 197129] games/scid: vulnerable files with mode 666 below /usr/local/share/scid/books Date: Wed, 15 Jun 2016 14:07:28 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-patch X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: bsd@volki.at X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback+ X-Bugzilla-Changed-Fields: flagtypes.name attachments.created Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Jun 2016 14:07:28 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D197129 Friedrich Volkmann changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171462| |maintainer-approval+ Flags| | --- Comment #6 from Friedrich Volkmann --- Created attachment 171462 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D171462&action= =3Dedit patch removing hardcoded file permissions @Vladimir Krstulja: Yes and yes. It works as expected, but requires a fix f= or (theoretical) security reasons. I just followed John Marino's suggestion to use INSTALL_* macros. Unfortunately, some useful macros such as MKDIR and COPYTREE_SHARE are not exported, so we have to stick to literal install -d or mkdir for directorie= s, and the "find" command in the makefile looks ugly. Of course we could move = the file copying and directory creation to a do-install section in games/scid/Makefile (where we could use all of the macros), but that would = be even more difficult to maintain. So here's my patch, please check out if I did it right and if everything is still working. --=20 You are receiving this mail because: You are the assignee for the bug.=