From owner-cvs-src@FreeBSD.ORG Sat Nov 19 18:42:39 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C01D16A41F; Sat, 19 Nov 2005 18:42:39 +0000 (GMT) (envelope-from jdp@polstra.com) Received: from blake.polstra.com (blake.polstra.com [64.81.189.66]) by mx1.FreeBSD.org (Postfix) with ESMTP id 80B5743D45; Sat, 19 Nov 2005 18:42:38 +0000 (GMT) (envelope-from jdp@polstra.com) Received: from strings.polstra.com (strings.polstra.com [64.81.189.67]) by blake.polstra.com (8.13.1/8.13.1) with ESMTP id jAJIgbHw050516 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sat, 19 Nov 2005 10:42:37 -0800 (PST) (envelope-from jdp@strings.polstra.com) Received: (from jdp@localhost) by strings.polstra.com (8.13.1/8.13.1/Submit) id jAJIgbSQ053454; Sat, 19 Nov 2005 10:42:37 -0800 (PST) (envelope-from jdp) Message-ID: X-Mailer: XFMail 1.5.5 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <20051119182853.GX5197@obiwan.tataz.chchile.org> Date: Sat, 19 Nov 2005 10:42:37 -0800 (PST) From: John Polstra To: Jeremie Le Hen Cc: John Polstra , cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/cam/scsi scsi_cd.c scsi_da.c src/sys/geom geom_disk.c geom_disk.h geom_subr.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Nov 2005 18:42:39 -0000 On 19-Nov-2005 Jeremie Le Hen wrote: >> This fix adds a new disk_gone() function which is called by CAM when a >> drive goes away. It orphans all of the providers associated with the >> drive, setting an error condition of ENXIO in each one. In addition, >> we prevent a re-taste on last close for writing if an error condition >> has been set in the provider. > > This commit stirred my memory up about panicking when hot-unplugging > an USB key while it is still mounted. I have not been able to track > HEAD source changes attentively for some time recently but it > appears from the above description that this awkard behaviour has been > replaced by a smarter one (IOW, return ENXIO on all pending filesystem > actions). > > Thanks in advance for explanations. This commit may or may not fix those panics -- I don't really know. There is a lot that can go wrong if you remove a mounted filesystem from the system. John