From owner-freebsd-hackers  Sun Dec 17 18: 4:55 2000
From owner-freebsd-hackers@FreeBSD.ORG  Sun Dec 17 18:04:53 2000
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from assaris.sics.se (dyna225-150.nada.kth.se [130.237.225.150])
	by hub.freebsd.org (Postfix) with ESMTP id A5BDF37B400
	for <hackers@FreeBSD.ORG>; Sun, 17 Dec 2000 18:04:52 -0800 (PST)
Received: (from assar@localhost)
	by assaris.sics.se (8.9.3/8.9.3) id DAA67881;
	Mon, 18 Dec 2000 03:04:57 +0100 (CET)
	(envelope-from assar)
Sender: assar@assaris.sics.se
From: assar@FreeBSD.ORG
To: "Jacques A. Vidrine" <n@nectar.com>
Cc: hackers@FreeBSD.ORG
Subject: Re: Why not another style thread? (was Re: cvs commit: src/lib/libc/gen getgrent.c)
References: <200012172110.eBHLAfU46563@freefall.freebsd.org> <20001217151509.A63051@hamlet.nectar.com>
Date: 18 Dec 2000 03:04:55 +0100
In-Reply-To: "Jacques A. Vidrine"'s message of "Sun, 17 Dec 2000 15:15:09 -0600"
Message-ID: <5l66kia3i0.fsf@assaris.sics.se>
Lines: 23
User-Agent: Gnus/5.070098 (Pterodactyl Gnus v0.98) Emacs/20.6
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: owner-freebsd-hackers@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

"Jacques A. Vidrine" <n@nectar.com> writes:
> What do folks think about
> 
>   1)    if (data)
>                 free(data);
> 
> versus
> 
>   2)    free(data);
> 
> versus
> 
>   3)    #define xfree(x) if ((x) != NULL) free(x);
>         xfree(data);

(2), unless you can show that you actually win something by the
optimization in (1), and if you repeat it enough I would vote for
doing an inline function similar to the one in (3).

This is of course for user-level free since kernel free has different
parameters.

/assar


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-hackers" in the body of the message