From owner-freebsd-bugs@FreeBSD.ORG Fri Jun 1 16:50:05 2007 Return-Path: X-Original-To: freebsd-bugs@hub.freebsd.org Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 6428616A46C for ; Fri, 1 Jun 2007 16:50:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id 44EC713C457 for ; Fri, 1 Jun 2007 16:50:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id l51Go5b3045702 for ; Fri, 1 Jun 2007 16:50:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.4/8.13.4/Submit) id l51Go5ek045701; Fri, 1 Jun 2007 16:50:05 GMT (envelope-from gnats) Resent-Date: Fri, 1 Jun 2007 16:50:05 GMT Resent-Message-Id: <200706011650.l51Go5ek045701@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, "Mikhail T." Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id A80BB16A468 for ; Fri, 1 Jun 2007 16:47:33 +0000 (UTC) (envelope-from mi@aldan.algebra.com) Received: from aldan.algebra.com (aldan.algebra.com [216.254.65.224]) by mx1.freebsd.org (Postfix) with ESMTP id 640C013C455 for ; Fri, 1 Jun 2007 16:47:33 +0000 (UTC) (envelope-from mi@aldan.algebra.com) Received: from aldan.algebra.com (aldan [127.0.0.1]) by aldan.algebra.com (8.13.8/8.13.8) with ESMTP id l51GRBvd091905 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Fri, 1 Jun 2007 12:27:11 -0400 (EDT) (envelope-from mi@aldan.algebra.com) Received: (from mi@localhost) by aldan.algebra.com (8.13.8/8.13.8/Submit) id l51GRBqb091904; Fri, 1 Jun 2007 12:27:11 -0400 (EDT) (envelope-from mi) Message-Id: <200706011627.l51GRBqb091904@aldan.algebra.com> Date: Fri, 1 Jun 2007 12:27:11 -0400 (EDT) From: "Mikhail T." To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: bin/113230: const-ify PAM-headers X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2007 16:50:05 -0000 >Number: 113230 >Category: bin >Synopsis: const-ify PAM-headers >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: update >Submitter-Id: current-users >Arrival-Date: Fri Jun 01 16:50:04 GMT 2007 >Closed-Date: >Last-Modified: >Originator: Mikhail T. >Release: FreeBSD 6.2-STABLE amd64 >Organization: Virtual Estates, Inc. >Environment: System: FreeBSD aldan.algebra.com 6.2-STABLE FreeBSD 6.2-STABLE #2: Mon Mar 26 18:05:02 EDT 2007 mi@aldan.algebra.com:/meow/obj/var/src/sys/SILVER amd64 >Description: As currently declared, the pam_* functions don't guarantee the read-onlyness of the passed in data, even where no modifications could happen. The declarations also differ from those used of Solaris and Linux, leading to increased porting burden of 3rd-party PAM-modules (such as Samba's winbind). It is possible, that a newer version of OpenPAM will bring in these changes, but we can update the headers (without functional changes) now to introduce the updated API and ease the porting efforts. >How-To-Repeat: >Fix: The up-to-date patch can be found at http://aldan.algebra.com/~mi/pam-const.patch or -- color-coded -- at: http://aldan.algebra.com/~mi/pam-const.patch.html It does not, at the moment, touch the relevant man-pages. These will be updated soon, but testing/review of the code can begin now. The changes only add const-ness here and there -- no functional changes. >Release-Note: >Audit-Trail: >Unformatted: