From owner-svn-src-stable@FreeBSD.ORG Thu Jul 11 08:18:46 2013 Return-Path: Delivered-To: svn-src-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 9B5B8FB7; Thu, 11 Jul 2013 08:18:46 +0000 (UTC) (envelope-from yongari@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:1900:2254:2068::e6a:0]) by mx1.freebsd.org (Postfix) with ESMTP id 8DDA61A2D; Thu, 11 Jul 2013 08:18:46 +0000 (UTC) Received: from svn.freebsd.org ([127.0.1.70]) by svn.freebsd.org (8.14.7/8.14.7) with ESMTP id r6B8IkH0087889; Thu, 11 Jul 2013 08:18:46 GMT (envelope-from yongari@svn.freebsd.org) Received: (from yongari@localhost) by svn.freebsd.org (8.14.7/8.14.5/Submit) id r6B8Ikvu087888; Thu, 11 Jul 2013 08:18:46 GMT (envelope-from yongari@svn.freebsd.org) Message-Id: <201307110818.r6B8Ikvu087888@svn.freebsd.org> From: Pyun YongHyeon Date: Thu, 11 Jul 2013 08:18:46 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-8@freebsd.org Subject: svn commit: r253196 - stable/8/sys/dev/bge X-SVN-Group: stable-8 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-stable@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for all the -stable branches of the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jul 2013 08:18:46 -0000 Author: yongari Date: Thu Jul 11 08:18:46 2013 New Revision: 253196 URL: http://svnweb.freebsd.org/changeset/base/253196 Log: MFC r245870: bge_attach() can fail before attaching mii(4). So make sure to check bge_miibus before detaching mii(4). Modified: stable/8/sys/dev/bge/if_bge.c Directory Properties: stable/8/sys/ (props changed) stable/8/sys/dev/ (props changed) stable/8/sys/dev/bge/ (props changed) Modified: stable/8/sys/dev/bge/if_bge.c ============================================================================== --- stable/8/sys/dev/bge/if_bge.c Thu Jul 11 08:18:00 2013 (r253195) +++ stable/8/sys/dev/bge/if_bge.c Thu Jul 11 08:18:46 2013 (r253196) @@ -3924,9 +3924,9 @@ bge_detach(device_t dev) if (sc->bge_tq) taskqueue_drain(sc->bge_tq, &sc->bge_intr_task); - if (sc->bge_flags & BGE_FLAG_TBI) { + if (sc->bge_flags & BGE_FLAG_TBI) ifmedia_removeall(&sc->bge_ifmedia); - } else { + else if (sc->bge_miibus != NULL) { bus_generic_detach(dev); device_delete_child(dev, sc->bge_miibus); }