From owner-cvs-all Wed Oct 24 14:54: 5 2001 Delivered-To: cvs-all@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id CBE2A37B405; Wed, 24 Oct 2001 14:54:00 -0700 (PDT) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id HAA30197; Thu, 25 Oct 2001 07:53:58 +1000 Date: Thu, 25 Oct 2001 07:53:03 +1000 (EST) From: Bruce Evans X-X-Sender: To: Jeroen Ruigrok van der Werven Cc: , Subject: Re: cvs commit: src/include assert.h src/lib/libc/gen assert.c src/lib/libstand assert.c src/share/man/man3 assert.3 In-Reply-To: <20011024215758.U33318@daemon.ninth-circle.org> Message-ID: <20011025074607.C74238-100000@delplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, 24 Oct 2001, Jeroen Ruigrok van der Werven wrote: > -On [20011024 21:50], Bruce Evans (bde@zeta.org.au) wrote: > >This breaks K&R support, > > I thought we cared like >< much anymore about K&R nowadays? I still care :-). > >C90 support, (there is no __func__ in C90), and > >maybe C++ support (is __func__ in C++?). Please back this out. > > It is fair, since I forgot to properly wrap it. > > Then again, our STABLE sources are broken as is then as well: > > src/sys/i386/i386/in_cksum.c has two unwrapped occurences of __func__ > usage. > src/sys/netinet/accf_http.c has one unwrapped occurence. > > I must be honest that I have no idea about CURRENT's usage of __func__ > though. -current has many more of these in the kernel. I dislike them because they break compiling with C compilers (C90). They are also complained about by lint(1). But the kernel isn't a central standard header. It has never been completely compilable by a C compiler. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message