From owner-svn-ports-head@FreeBSD.ORG Mon May 20 17:35:19 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id CD3E2623 for ; Mon, 20 May 2013 17:35:19 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-pa0-f45.google.com (mail-pa0-f45.google.com [209.85.220.45]) by mx1.freebsd.org (Postfix) with ESMTP id A77C688E for ; Mon, 20 May 2013 17:35:19 +0000 (UTC) Received: by mail-pa0-f45.google.com with SMTP id lj1so5896467pab.4 for ; Mon, 20 May 2013 10:35:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=jkYVAVw9TRXRUrHFlCQSD3YNKkhhA/DwQxLO34S7QWg=; b=gG//Lkt62XaItt2p30Y5LwGZjUQBNAbH4c8wZkwe0zeyB/KY0twKfp5CK/Il3cSEqF W9F6fouRBSlyby5NnZauTj9lH8mKEmeaNDDHOJvVF9lZyun3AfpeM+9xEdi3bmq6pI2M 6cTcDCrSurG4KH5DR2T5CT0ZuGIvt6OyR9eoEd4bhLlP+osl8Qf8UpTSqtdhHzwD0Vjp F3cF8I0f9qHnxrCG4sceeUScUwFvI6mnP+hAWzw9fg+qmSTnBjm3KCtzNNafy5yA2pYu JtkG9A6dMrCrusUbk6QDZkw54N+UgP5UKKRE/fRTy5uqr4P1S45lpjZaTLkTmYcT1VZd bvww== MIME-Version: 1.0 X-Received: by 10.66.160.162 with SMTP id xl2mr60907243pab.215.1369071317518; Mon, 20 May 2013 10:35:17 -0700 (PDT) Sender: bsd-src@helfman.org Received: by 10.70.78.10 with HTTP; Mon, 20 May 2013 10:35:17 -0700 (PDT) In-Reply-To: <20130520154757.GA96836@ithaqua.etoilebsd.net> References: <201305200715.r4K7FYmS057791@svn.freebsd.org> <20130520154757.GA96836@ithaqua.etoilebsd.net> Date: Mon, 20 May 2013 10:35:17 -0700 X-Google-Sender-Auth: ndxKB-hnGWXuEEryJCdNqX6U7tk Message-ID: Subject: Re: svn commit: r318576 - head/mail/sendmail-sasl From: Jason Helfman To: Baptiste Daroussin X-Gm-Message-State: ALoCoQnmyxzI9JbY1bOzEhN2AhHfMh8IgShKyKpMprPasub7SwoPYtJH4N3DUUHGr/TVjFmwQ+Ix Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: Dirk Meyer , "svn-ports-head@freebsd.org" , "svn-ports-all@freebsd.org" , Jason Helfman , "ports-committers@freebsd.org" X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 May 2013 17:35:19 -0000 On Mon, May 20, 2013 at 8:47 AM, Baptiste Daroussin wrote: > > Since mail/sendmail was converted to optionsNG, shouldn't these options > be > > defined similarly with the new framework? > > Yes it should > > > > OPTIONS_SET= TLS SASL2 SASL SASLAUTHD > > No not that way OPTIONS_SET and OPTIONS_UNSET should never ever be used in > a > ports Makefile > > My apologies for this advice. I forgot that this can't be noted in Makefile. It was PORT_OPTIONS at one point that should be defined. > OPTIONS_SLAVE has been written for that > It does 2 things: > 1- it makes sure the options are activated in the slave > 2- it removes the specified options for the options the user can select. > Very nice. I haven't used this, yet. I do see the commit about this now, however has it been included in the Handbook or CHANGES? Sounds like it would be well worth an inclusion if not. Thanks bapt! Great addition. -jgh -- Jason Helfman | FreeBSD Committer jgh@FreeBSD.org | http://people.freebsd.org/~jgh | The Power to Serve