From owner-cvs-src@FreeBSD.ORG Wed Aug 18 19:20:08 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 52EC216A4CE; Wed, 18 Aug 2004 19:20:08 +0000 (GMT) Received: from TRANG.nuxi.com (trang.nuxi.com [66.93.134.19]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2555C43D69; Wed, 18 Aug 2004 19:20:08 +0000 (GMT) (envelope-from obrien@NUXI.com) Received: from dragon.nuxi.com (obrien@localhost [127.0.0.1]) by TRANG.nuxi.com (8.13.1/8.12.11) with ESMTP id i7IJK4E0062906; Wed, 18 Aug 2004 12:20:04 -0700 (PDT) (envelope-from obrien@dragon.nuxi.com) Received: (from obrien@localhost) by dragon.nuxi.com (8.13.1/8.13.1/Submit) id i7IJK4Wv062898; Wed, 18 Aug 2004 12:20:04 -0700 (PDT) (envelope-from obrien) Date: Wed, 18 Aug 2004 12:19:59 -0700 From: "David O'Brien" To: Takahashi Yoshihiro Message-ID: <20040818191959.GA10978@dragon.nuxi.com> References: <200408180346.i7I3kdSj026379@repoman.freebsd.org> <20040819.005752.74729270.nyan@jp.FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040819.005752.74729270.nyan@jp.FreeBSD.org> User-Agent: Mutt/1.4.1i X-Operating-System: FreeBSD 5.2-CURRENT Organization: The NUXI BSD Group X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3 90 76 5D 69 58 D9 98 7A X-Pgp-Rsa-Keyid: 1024/34F9F9D5 cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: rwatson@FreeBSD.org cc: cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/conf options.pc98 X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Aug 2004 19:20:08 -0000 On Thu, Aug 19, 2004 at 12:57:52AM +0900, Takahashi Yoshihiro wrote: > In article <200408180346.i7I3kdSj026379@repoman.freebsd.org> > Robert Watson writes: > > Since pc98 shares the AGP driver with the i386, also define the > > amd64 agp option here in order to let the pc98 kernel build > > complete. This doesn't seem right, since there probably aren't > > plans to build a pc98 amd64 box; however, it's not clear to me > > how to get config to generate an opt_agp.h without an option > > defined. > > I think that using '#ifndef PC98' in agp_sis.c and agp_via.c is better > way rather than putting unneeded line in options.pc98. Agreed. I suspected that would fix things, but I'm waiting on rwatson so send me the error logs so I know what was breaking the build. -- -- David (obrien@FreeBSD.org)