From owner-svn-src-all@FreeBSD.ORG Tue Jun 21 21:09:25 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3CE871065709; Tue, 21 Jun 2011 21:09:25 +0000 (UTC) (envelope-from asmrookie@gmail.com) Received: from mail-yx0-f182.google.com (mail-yx0-f182.google.com [209.85.213.182]) by mx1.freebsd.org (Postfix) with ESMTP id AA7DE8FC15; Tue, 21 Jun 2011 21:09:24 +0000 (UTC) Received: by yxl31 with SMTP id 31so107101yxl.13 for ; Tue, 21 Jun 2011 14:09:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=0kcvhWknFn0WxyXfOUCTQ6nG5oMS47tgU93xI2Ph5nE=; b=GMdPhfYQBYgNyjTwE8Hw8A5HZ6er3SFC/qmV91eiEVoW19FDD8RpyWP2OHDB9vfFQp HCCbx74Xgaq05MH2xrcr2+JFLtXFqEeETh+yDxuL72ezO0/NQFhVNYBYGiYeTmlJYUbC Uv709I5uoGJCADH59S+jxtit4dtcj8RXV914g= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=MZ55XIAtVn11UWMd1HeQuIML7LdJpoobExz8UOMPOpOpwtS+16jAbhLMyZk1QKY/nx pd6fK++cNqvQRaZtUexVKOTDmKbtOmyn27b+9yCGRQQrRvQJ1AgTSBDEJe/4GfHB7mTW RcKtweIXk7KBaI+PfpoNRXi9K8JObbggg/kdc= MIME-Version: 1.0 Received: by 10.236.111.20 with SMTP id v20mr11180680yhg.423.1308690563598; Tue, 21 Jun 2011 14:09:23 -0700 (PDT) Sender: asmrookie@gmail.com Received: by 10.236.110.141 with HTTP; Tue, 21 Jun 2011 14:09:23 -0700 (PDT) In-Reply-To: <20110622063258.D2275@besplex.bde.org> References: <201106191913.p5JJDOqJ006272@svn.freebsd.org> <20110622063258.D2275@besplex.bde.org> Date: Tue, 21 Jun 2011 23:09:23 +0200 X-Google-Sender-Auth: zT2j_G6cUneQ3G84ny8EQ_6mKHc Message-ID: From: Attilio Rao To: Bruce Evans Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Alan Cox , svn-src-head@freebsd.org, svn-src-all@freebsd.org, "Bjoern A. Zeeb" , src-committers@freebsd.org Subject: Re: svn commit: r223307 - head/sys/vm X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2011 21:09:25 -0000 2011/6/21 Bruce Evans : > On Tue, 21 Jun 2011, Bjoern A. Zeeb wrote: > >> On Jun 19, 2011, at 7:13 PM, Alan Cox wrote: >> >> Hi Alan, >> >>> Author: alc >>> Date: Sun Jun 19 19:13:24 2011 >>> New Revision: 223307 >>> URL: http://svn.freebsd.org/changeset/base/223307 >>> >>> Log: >>> =C2=A0Precisely document the synchronization rules for the page's dirty= field. >>> =C2=A0(Saying that the lock on the object that the page belongs to must= be >>> held >>> =C2=A0only represents one aspect of the rules.) >>> >>> =C2=A0Eliminate the use of the page queues lock for atomically performi= ng >>> read- >>> =C2=A0modify-write operations on the dirty field when the underlying >>> architecture >>> =C2=A0supports atomic operations on char and short types. >>> >>> =C2=A0Document the fact that 32KB pages aren't really supported. >> >> contrary to the tinderbox I'd like to point out that all mips kernels >> built by universe are broken with a SVN HEAD from earlier today. =C2=A0C= ould you >> please check and see if you can fix it? =C2=A0The errors I get are: >> >> vm_page.o: In function `vm_page_clear_dirty': >> /sys/vm/vm_page.c:(.text+0x18d0): undefined reference to `atomic_clear_8= ' >> /sys/vm/vm_page.c:(.text+0x18d0): relocation truncated to fit: R_MIPS_26 >> against `atomic_clear_8' >> vm_page.o: In function `vm_page_set_validclean': >> /sys/vm/vm_page.c:(.text+0x38f0): undefined reference to `atomic_clear_8= ' >> /sys/vm/vm_page.c:(.text+0x38f0): relocation truncated to fit: R_MIPS_26 >> against `atomic_clear_8' > > Atomic types shorter than int cannot be used in MI code, since they might > not exist. =C2=A0Apparently they don't exist on mips. =C2=A0jake@ fixed a= ll their > old uses for sparc4 in ~Y2K. I'm sure they do, they exist in support.S though and may not have the _8 form (they may just have the _char version). I may look at the code again to be sure. Attilio --=20 Peace can only be achieved by understanding - A. Einstein