From owner-freebsd-current Sat Aug 10 7: 4:40 2002 Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 6D5BD37B400; Sat, 10 Aug 2002 07:04:38 -0700 (PDT) Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11]) by mx1.FreeBSD.org (Postfix) with SMTP id 3098D43E7B; Sat, 10 Aug 2002 07:04:37 -0700 (PDT) (envelope-from iedowse@maths.tcd.ie) Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP id ; 10 Aug 2002 15:04:36 +0100 (BST) To: Alexander Leidinger Cc: bhlewis@wossname.net, freebsd-current@FreeBSD.ORG, bde@FreeBSD.ORG Subject: Re: Is anyone else having trouble with dump(8) on -current? In-Reply-To: Your message of "Sat, 10 Aug 2002 15:23:54 +0200." <20020810152354.470317e4.Alexander@Leidinger.net> Date: Sat, 10 Aug 2002 15:04:35 +0100 From: Ian Dowse Message-ID: <200208101504.aa40149@salmon.maths.tcd.ie> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20020810152354.470317e4.Alexander@Leidinger.net>, Alexander Leiding er writes: >Have a look at Message-ID: <20020606063157.V8685-100000@gamplex.bde.org> >(should be in the archive of audit). Ah, I had forgotten about that -audit thread. >Short: open shouldn't be able to return EINTR in practice... > >My assumptions: > - Bruce hasn't made a mistake > - something broke in the kernel (either for a "short" period of > time, or it's still broken), so we should look for the real > problem instead I had a quick look yesterday, and I found a PCATCH tsleep call in diskopen(), though I do not know if this is the one that affects dump. Does open(2) need to loop on ERESTART? Currently it just maps ERESTART to EINTR and returns the error. We should fix this broken dump behaviour anyway - I don't think it matters too much for now whether it is fixed in userland or the kernel, as it will only affect the tiny set of applications that receive signals while opening a disk device at the same time as another open on the same device is occurring (I think). Ian To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message