From owner-cvs-all@FreeBSD.ORG Tue May 27 15:00:19 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3A2C610656BE; Tue, 27 May 2008 15:00:19 +0000 (UTC) (envelope-from csjp@sub.vaned.net) Received: from sub.vaned.net (sub.vaned.net [205.200.235.40]) by mx1.freebsd.org (Postfix) with ESMTP id 073EE8FC12; Tue, 27 May 2008 15:00:18 +0000 (UTC) (envelope-from csjp@sub.vaned.net) Received: by sub.vaned.net (Postfix, from userid 1001) id 9170B2E2; Tue, 27 May 2008 10:00:18 -0500 (CDT) Date: Tue, 27 May 2008 10:00:18 -0500 From: "Christian S.J. Peron" To: John Baldwin Message-ID: <20080527150018.GA51836@sub.vaned.net> References: <200706150253.l5F2rpBV089069@repoman.freebsd.org> <200805071617.57772.jhb@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200805071617.57772.jhb@freebsd.org> User-Agent: Mutt/1.4.2.3i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, "Christian S.J. Peron" , cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/net bpf.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 May 2008 15:00:19 -0000 John Sorry for the delay. I don't think there was a reason. I just took a look at the change and i think it should be safe to be MFCed On Wed, May 07, 2008 at 04:17:57PM -0400, John Baldwin wrote: > On Thursday 14 June 2007 10:53:51 pm Christian S.J. Peron wrote: > > csjp 2007-06-15 02:53:51 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/net bpf.c > > Log: > > - Conditionally pickup Giant around the network interface > > ioctl routines if we are running with !mpsafenet > > - Change un-conditional Giant acquisition around ifpromisc > > to occur only if we are running with !mpsafenet > > > > With these locking bits in place, we can now remove the Giant > > requirement from BPF, so drop the D_NEEDGIANT device flag. > > This change removes Giant acquisitions around BPF device > > handlers (read, write, ioctl etc). > > > > MFC after: 1 month > > Discussed with: rwatson > > Would it be ok to MFC this to 6.x? (Looks like it was just never MFC'd, was > curious if a reason came up why it couldn't be MFC'd?) > > -- > John Baldwin