From owner-svn-src-all@FreeBSD.ORG Tue Jan 19 15:57:01 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 77CFE1065670; Tue, 19 Jan 2010 15:57:01 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id 29FA78FC16; Tue, 19 Jan 2010 15:57:00 +0000 (UTC) Received: from [IPv6:::1] (pooker.samsco.org [168.103.85.57]) (authenticated bits=0) by pooker.samsco.org (8.14.2/8.14.2) with ESMTP id o0JFuv9j043631; Tue, 19 Jan 2010 08:56:57 -0700 (MST) (envelope-from scottl@samsco.org) Mime-Version: 1.0 (Apple Message framework v1076) Content-Type: text/plain; charset=us-ascii; format=flowed; delsp=yes From: Scott Long In-Reply-To: <201001191531.o0JFVI6n029716@svn.freebsd.org> Date: Tue, 19 Jan 2010 08:56:57 -0700 Content-Transfer-Encoding: 7bit Message-Id: <9FF943CE-9FCB-48C8-A048-23F23620F4E5@samsco.org> References: <201001191531.o0JFVI6n029716@svn.freebsd.org> To: Ed Schouten X-Mailer: Apple Mail (2.1076) X-Spam-Status: No, score=-8.2 required=3.8 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r202628 - in head: . sys/amd64/amd64 sys/i386/i386 sys/i386/xen sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2010 15:57:01 -0000 On Jan 19, 2010, at 8:31 AM, Ed Schouten wrote: > Author: ed > Date: Tue Jan 19 15:31:18 2010 > New Revision: 202628 > URL: http://svn.freebsd.org/changeset/base/202628 > > Log: > Recommit r193732: > > Remove __gnu89_inline. > > Now that we use C99 almost everywhere, just use C99-style in the > pmap > code. Since the pmap code is the only consumer of __gnu89_inline, > remove > it from cdefs.h as well. Because the flag was only introduced 17 > months > ago, I don't expect any problems. > > Reviewed by: alc > > It was backed out, because it prevented us from building kernels > using a > 7.x compiler. Now that most people use 8.x, there is nothing that > holds > us back. Even if people run 7.x, they should be able to build a > kernel > if they run `make kernel-toolchain' or `make buildworld' first. Ok, so you've broken a legitimate piece of compatibility. What's the gain? Scott