From owner-p4-projects@FreeBSD.ORG  Thu Jun 28 12:05:31 2007
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9B38216A475; Thu, 28 Jun 2007 12:05:31 +0000 (UTC)
X-Original-To: perforce@FreeBSD.org
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5023216A41F
	for <perforce@FreeBSD.org>; Thu, 28 Jun 2007 12:05:31 +0000 (UTC)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [69.147.83.41])
	by mx1.freebsd.org (Postfix) with ESMTP id 40C6113C44B
	for <perforce@FreeBSD.org>; Thu, 28 Jun 2007 12:05:31 +0000 (UTC)
	(envelope-from rdivacky@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.8/8.13.8) with ESMTP id l5SC5VnQ045559
	for <perforce@FreeBSD.org>; Thu, 28 Jun 2007 12:05:31 GMT
	(envelope-from rdivacky@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.8/8.13.8/Submit) id l5SC5Ukp045556
	for perforce@freebsd.org; Thu, 28 Jun 2007 12:05:30 GMT
	(envelope-from rdivacky@FreeBSD.org)
Date: Thu, 28 Jun 2007 12:05:30 GMT
Message-Id: <200706281205.l5SC5Ukp045556@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	rdivacky@FreeBSD.org using -f
From: Roman Divacky <rdivacky@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 122479 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 28 Jun 2007 12:05:32 -0000

http://perforce.freebsd.org/chv.cgi?CH=122479

Change 122479 by rdivacky@rdivacky_witten on 2007/06/28 12:04:32

	Initialize dvp's to NULL to prevent panic... also vrele before unlocking Giant.

Affected files ...

.. //depot/projects/soc2007/rdivacky/linux_at/sys/kern/vfs_syscalls.c#40 edit

Differences ...

==== //depot/projects/soc2007/rdivacky/linux_at/sys/kern/vfs_syscalls.c#40 (text+ko) ====

@@ -1585,7 +1585,7 @@
     enum uio_seg segflg, int follow)
 {
 	struct nameidata ndp, ndl;
-	struct vnode *pdvp, *ldvp;
+	struct vnode *pdvp = NULL, *ldvp = NULL;
 	struct vnode *vp;
 	struct mount *mp;
 	int vfslocked;
@@ -1602,10 +1602,10 @@
 	error = kern_get_at(td, fd2, &ldvp);
 	if (error && !kern_absolute_path(path2, segflg)) {
 		if (pdvp) {
+			vrele(pdvp);
 			if (VFS_NEEDSGIANT(pdvp->v_mount))
 				mtx_unlock(&Giant);
 			}
-			vrele(pdvp);
 		return (error);
 	}
 
@@ -3821,7 +3821,7 @@
     const char *new, enum uio_seg pathseg)
 {
 	struct nameidata fromnd, tond;
-	struct vnode *frdvp, *todvp;
+	struct vnode *frdvp = NULL, *todvp = NULL;
 	struct mount *mp = NULL;
 	struct vnode *tvp, *fvp, *tdvp;
 	int tvfslocked;
@@ -3835,10 +3835,10 @@
 	error = kern_get_at(td, newfd, &todvp);
 	if (error && !kern_absolute_path(new, pathseg)) {
 		if (frdvp) {
+			vrele(frdvp);
 			if (VFS_NEEDSGIANT(frdvp->v_mount))
 				mtx_unlock(&Giant);
 			}
-			vrele(frdvp);
 		return (error);
 	}