From owner-freebsd-current Sat Aug 21 18:37:16 1999 Delivered-To: freebsd-current@freebsd.org Received: from dt011n65.san.rr.com (dt010nb9.san.rr.com [204.210.12.185]) by hub.freebsd.org (Postfix) with ESMTP id 0B26914C1A for ; Sat, 21 Aug 1999 18:37:13 -0700 (PDT) (envelope-from Doug@gorean.org) Received: from gorean.org (master [10.0.0.2]) by dt011n65.san.rr.com (8.9.3/8.8.8) with ESMTP id SAA00446; Sat, 21 Aug 1999 18:32:26 -0700 (PDT) (envelope-from Doug@gorean.org) Message-ID: <37BF5334.7EEFDB5C@gorean.org> Date: Sat, 21 Aug 1999 18:32:36 -0700 From: Doug Organization: Triborough Bridge & Tunnel Authority X-Mailer: Mozilla 4.61 [en] (X11; U; FreeBSD 4.0-CURRENT-0815 i386) X-Accept-Language: en MIME-Version: 1.0 To: "Jordan K. Hubbard" Cc: Harlan Stenn , Warner Losh , current@FreeBSD.ORG Subject: Re: REQ: Test /etc/rc clean-up References: <81724.935281655@localhost> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG "Jordan K. Hubbard" wrote: > > > The X also protected test from the case where the expansion included a > > string like "-x", although with most modern implementations of test (or > > shells with test as a builtin) this is no longer a problem. > > And certainly not in any of these cases. :) Right, I was just being pedantic. > > I agree with some of your changes here, but can you explain your objection > > to using case? My argument is that case is a builtin so it makes things > > just a little bit cleaner, and more importantly it makes case insensitivity > > for the options that much easier to implement which is a huge win in user > > friendliness. For example, what happens to if [ "${pccard_ifconfig}" != > > I don't disagree with any of this, but that radical a degree of change > was simply not my intention with these diffs. :-) Ok, good. Like I said I think cleaning it up in general is a Good Thing (TM). There is one other element of style that it would be nice to see made consistent, namely: if [ blah ]; then as opposed to the various iterations of ] ; then, then's on a seperate line, etc. Even using case for the variables there are still going to be some test's needed. > If we were to commit this, I'd suggest that we do my version first > and then have a case-ify pass done 2nd, just so we have each option > to chose from in the CVS repository should anyone express strong > reservations at some stage. :) Yes, I was going to suggest the same thing. Wow... we are dangerously close to a consensus on this. :) Doug To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message