From owner-freebsd-hackers@FreeBSD.ORG  Mon Nov  9 20:58:23 2009
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 450EF106566B;
	Mon,  9 Nov 2009 20:58:23 +0000 (UTC) (envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 060D58FC16;
	Mon,  9 Nov 2009 20:58:23 +0000 (UTC)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id 46D826D41B;
	Mon,  9 Nov 2009 20:58:22 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id EBBF184503; Mon,  9 Nov 2009 21:58:21 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Alexander Best <alexbestms@wwu.de>
References: <permail-200911091924561e86ffa8000070ba-a_best01@message-id.uni-muenster.de>
Date: Mon, 09 Nov 2009 21:58:21 +0100
In-Reply-To: <permail-200911091924561e86ffa8000070ba-a_best01@message-id.uni-muenster.de>
	(Alexander Best's message of "Mon, 09 Nov 2009 20:24:56 +0100 (CET)")
Message-ID: <86aayvfmaa.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.95 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: freebsd-hackers@FreeBSD.org, Giorgos Keramidas <keramida@freebsd.org>
Subject: Re: [patch] burncd: honour for envar SPEED
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 09 Nov 2009 20:58:23 -0000

Alexander Best <alexbestms@wwu.de> writes:
>=20=20
> +	if ((env_speed =3D getenv("BURNCD_SPEED")) !=3D NULL) {
> +		if (strcasecmp("max", env_speed) =3D=3D 0)
> +			speed =3D CDR_MAX_SPEED;
> +		else
> +			speed =3D atoi(env_speed) * 177;
> +		if (speed <=3D 0)
> +			errx(EX_USAGE, "Invalid speed: %s", env_speed);
> +	}
> +
>  	while ((ch =3D getopt(argc, argv, "def:Flmnpqs:tv")) !=3D -1) {
>  		switch (ch) {
>  		case 'd':

You realize you're duplicating 6 lines of non-trivial code for no good
reason?

env_speed =3D getenv("BURNCD_SPEED");

while ((ch =3D getopt(...)) !=3D -1) {
    switch (ch) {
    case 's':
        env_speed =3D optarg;
        break;
    ...
    }
}

if (env_speed !=3D NULL) {
    if (strcasecmp...) {
        ...
    }
}

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no