From owner-cvs-all Wed Jan 24 11:26:40 2001 Delivered-To: cvs-all@freebsd.org Received: from lucifer.ninth-circle.org (lucifer.bart.nl [194.158.168.74]) by hub.freebsd.org (Postfix) with ESMTP id 9D99737B400; Wed, 24 Jan 2001 11:26:15 -0800 (PST) Received: (from asmodai@localhost) by lucifer.ninth-circle.org (8.11.1/8.11.0) id f0OJQ7402082; Wed, 24 Jan 2001 20:26:07 +0100 (CET) (envelope-from asmodai) Date: Wed, 24 Jan 2001 20:26:07 +0100 From: Jeroen Ruigrok van der Werven To: Garance A Drosihn Cc: John Baldwin , Archie Cobbs , cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org, Kris Kennaway Subject: Re: cvs commit: src/contrib/tcpdump print-smb.c Message-ID: <20010124202607.A1455@lucifer.bart.nl> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: ; from drosih@rpi.edu on Wed, Jan 24, 2001 at 01:26:52PM -0500 Organisation: VIA Net.Works The Netherlands Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG -On [20010124 19:30], Garance A Drosihn (drosih@rpi.edu) wrote: >Now, back to this thread. Archie fixed a BUG. A BUG. That >is not a typo on a man page. It is not a spelling correction. >IT IS A BUG. If I am using tcpdump to look at SMB packets, I >would much prefer to SEE THE CORRECT OUTPUT than to worry about >a little cvs bloat. Somehow I am going to regret this, but they say wisdom comes to those who try, fail/succeed and learn from their trying. Apologies to David O`Brien for speaking on his account on some things, but I hope I understood his previous sentiments correctly, if not apologies. The point everybody is failing to see here is not repo bloat. The point is maintainability and having just spend two days just trying to get awk MFC'd correctly I think that both David and my points in time [we've had this discussion before, and so many other discussion as well that I am growing quite weary of them by now] have been on the case of maintainability. Not to belittle anyone, but David and me are currently two of people, out of a score of more, who actively deal a lot with contrib'd sources and their subsequent MFC's, and we can readily attest that taking files of the vendor branch is not making our task that much easier. Sure, there exist tools which make this easier, but cause other problems for our project. To refer to your, in my reading, rather harsh statement above Garance, this bug has been present since the last import of tcpdump in CURRENT, I haven't read a lot, if any, complaints about it. Furthermore CURRENT is already in a great state of flux, one bug more or less in CURRENT does not [yet] hurt us enough to not follow the best of `procedures' dealing with things like this. And another aside, if Archie would've consulted with the other developers or directly with David or me we could've advised him to merely import this as a patch on along on the vendor branch, causing less problems for us all. And yet another, Bill Fenner showed himself to be a good maintainer of tcpdump for FreeBSD, if some people find that hard to believe, please read tcpdump-workers archives. Another point, wrong documentation can be as bad as a bug, please do not discard documentation as being minor in severity of affecting a tool than a bug in the tool itself. -- Jeroen Ruigrok van der Werven VIA Net.Works The Netherlands BSD: Technical excellence at its best Network- and systemadministrator D78D D0AD 244D 1D12 C9CA 7152 035C 1138 546A B867 Misery loves company... To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message