From owner-freebsd-arm@FreeBSD.ORG  Wed Jun 29 10:19:31 2011
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1DE0F1065670
	for <freebsd-arm@freebsd.org>; Wed, 29 Jun 2011 10:19:31 +0000 (UTC)
	(envelope-from kevlo@kevlo.org)
Received: from ns.kevlo.org (kevlo.org [220.128.136.52])
	by mx1.freebsd.org (Postfix) with ESMTP id AA0208FC1A
	for <freebsd-arm@freebsd.org>; Wed, 29 Jun 2011 10:19:28 +0000 (UTC)
Received: from [127.0.0.1] (kevlo@kevlo.org [220.128.136.52])
	by ns.kevlo.org (8.14.3/8.14.3) with ESMTP id p5T9xtKx000051;
	Wed, 29 Jun 2011 17:59:57 +0800 (CST)
From: Kevin Lo <kevlo@kevlo.org>
To: Damjan Marion <damjan.marion@gmail.com>
In-Reply-To: <B823839E-A0B2-4994-BDD8-6AC8747DCCEC@gmail.com>
References: <B823839E-A0B2-4994-BDD8-6AC8747DCCEC@gmail.com>
Content-Type: text/plain; charset="Big5"
Date: Wed, 29 Jun 2011 17:59:54 +0800
Message-ID: <1309341594.10141.9.camel@srgsec>
Mime-Version: 1.0
X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port 
Content-Transfer-Encoding: 7bit
Cc: freebsd-arm@freebsd.org
Subject: Re: Few issues with Marvell code
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 Jun 2011 10:19:31 -0000

On Tue, 2011-05-03 at 22:42 +0200, Damjan Marion wrote:
> Hi,

Hi,

> During my attempt to bring up 88F5181L I found few issues with current marvell code:
> 
> 1. There is a typo in sys/arm/mv/common.c
> 
> -       { "mvrl,pcie", &decode_win_pcie_setup, NULL },
> +       { "mrvl,pcie", &decode_win_pcie_setup, NULL },

Indeed. Committed, thanks!

> 2. Even if this is fixed, decode_win_pcie_setup will not be executed as in FDT file pci tree sits outside of SOC tree
> 
> 
> 3. CPU decode windows setup in FDT localbus tree is missing target, instead target is hardcoded to 1:
> 
> 	cpu_win_tbl[t].target = 1; 
> 
> On other side 1st column looks like a sequence. Is this 1st column needed? 
> Can we extend this definition to also have target defined?
> 
> I.e. In case of 88F5181L I need to add following window, and it will be more convenient to do that in FDT file.
> 
> 	cpu_win_tbl[++t].target = 0x04;
> 	cpu_win_tbl[t].attr = 0x79;
> 	cpu_win_tbl[t].base = 0xf0000000;
> 	cpu_win_tbl[t].size = 0x01000000;
> 	cpu_win_tbl[t].remap = -1;

I tried to boot kernel.bin used the generic DB-88F5XXX kernel
configuration on the 88F5182 board, it doesn't work either.
I will further investigate.

> Thanks,
> 
> Damjan

	Kevin