From owner-cvs-src@FreeBSD.ORG Fri Mar 3 21:46:15 2006 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9A0716A420; Fri, 3 Mar 2006 21:46:15 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id E805243D67; Fri, 3 Mar 2006 21:46:12 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id B2A5751756; Fri, 3 Mar 2006 22:46:10 +0100 (CET) Received: from localhost (dlp8.neoplus.adsl.tpnet.pl [83.24.45.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id B8D5E5174A; Fri, 3 Mar 2006 22:46:05 +0100 (CET) Date: Fri, 3 Mar 2006 22:45:45 +0100 From: Pawel Jakub Dawidek To: Scott Ullrich Message-ID: <20060303214545.GA11030@garage.freebsd.pl> References: <200603011753.k21Hrvj0055120@repoman.freebsd.org> <20060302014917.GA61428@voi.aagh.net> <20060302060618.GA1790@haakonia.hitnet.RWTH-Aachen.DE> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="MGYHOYXEY6WxJCY8" Content-Disposition: inline In-Reply-To: X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: Christian Brueffer , cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/geom/label g_label.c g_label.h g_label_iso9660.c g_label_msdosfs.c g_label_ufs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2006 21:46:16 -0000 --MGYHOYXEY6WxJCY8 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 02, 2006 at 10:48:06AM -0500, Scott Ullrich wrote: +> On 3/2/06, Christian Brueffer wrote: +> > For the record, I've heard another report of this yesterday. +>=20 +> I was also bitten by this on my embedded versions and I hosed my +> primary firewall. Sorry guys for the brakeage, but the problem is more complex. What you see is actually bug in how sysinstall creates partitions. Normally, bsdlabel(8) puts first partition at offset 16. Sysinstall however puts first partition at offset 0. There are much more problems because of this and this is one of them - glabel finds UFS magic on slice, because both slice and partition start at the same offset. If I backout this change, glabel/ufs cannot be used for file systems created with -s option. If I leave the change, glabel/ufs won't detect UFS file system on a first partition created by sysinstall... Ehh, I'll back it out of course. God, why sysinstall cannot just die? --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --MGYHOYXEY6WxJCY8 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFECLkJForvXbEpPzQRAvIKAKCGScH9/OJUyhiUEJXIC2PafyAwTACgobeb VTgItUIAoz6UwHj0aFOFFrY= =egvK -----END PGP SIGNATURE----- --MGYHOYXEY6WxJCY8--