From owner-freebsd-ports@FreeBSD.ORG  Sat Jan 19 13:36:07 2013
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id E7C3A369
 for <ports@freebsd.org>; Sat, 19 Jan 2013 13:36:07 +0000 (UTC)
 (envelope-from utisoft@gmail.com)
Received: from mail-ie0-f181.google.com (mail-ie0-f181.google.com
 [209.85.223.181]) by mx1.freebsd.org (Postfix) with ESMTP id C0B0DC1A
 for <ports@freebsd.org>; Sat, 19 Jan 2013 13:36:07 +0000 (UTC)
Received: by mail-ie0-f181.google.com with SMTP id 16so7641722iea.12
 for <ports@freebsd.org>; Sat, 19 Jan 2013 05:36:07 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=x-received:mime-version:sender:in-reply-to:references:from:date
 :x-google-sender-auth:message-id:subject:to:cc:content-type;
 bh=eaPsOjxZEGf8ugmH4I9eKPuqtml0txsXayNIrjTik48=;
 b=BJfq7eCFcarDG5QpD6LtnifusYuVrUucJqk2TMTYJ5HzzC+TOoifF903WeuE+Fh4Ab
 ElR4t1kqQEvMg5WA9789IeWBmBixl/gcLTt+fFmY/FjDrq7Qj4VUrhQBLX/tc/EwuEkg
 1yU61FkzKi7wmE3KgDs/e9LmvbLocvWfDypcII7fafwMudYwSGmWhokndMwOmb89Q/g1
 POs/qWUFfH3Cu2uBaXauOBqyfwMuth5d+jzUxuhaKvbSRmqsL5A6oYFDQiQhf87Wx5YX
 aUZbBO4xl/iCGLuperqZ5ZuLczW2nnHWa0qnswEbQ6tWkpfh+Mx7o/c6zVeINed5wBUg
 xdaw==
X-Received: by 10.50.153.194 with SMTP id vi2mr5013155igb.15.1358602567060;
 Sat, 19 Jan 2013 05:36:07 -0800 (PST)
MIME-Version: 1.0
Sender: utisoft@gmail.com
Received: by 10.64.16.73 with HTTP; Sat, 19 Jan 2013 05:35:37 -0800 (PST)
In-Reply-To: <45933.1358559937@critter.freebsd.dk>
References: <45933.1358559937@critter.freebsd.dk>
From: Chris Rees <crees@FreeBSD.org>
Date: Sat, 19 Jan 2013 13:35:37 +0000
X-Google-Sender-Auth: iSGcM8Rj3mHD4_OE9AJQlhKU9OI
Message-ID: <CADLo839_hOwbiqF_SvE-Uc9RE6guMJz2JOufjq8jE=zkOsd=ww@mail.gmail.com>
Subject: Re: Ports, bsd.lib.mk and NOPROFILE
To: Poul-Henning Kamp <phk@phk.freebsd.dk>
Content-Type: text/plain; charset=ISO-8859-1
Cc: "ports@freebsd.org" <ports@freebsd.org>
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Jan 2013 13:36:08 -0000

On 19 January 2013 01:45, Poul-Henning Kamp <phk@phk.freebsd.dk> wrote:
>
> I just tried to build a system with -CURRENT from scratch, and it fell over
> in graphics/gd because NOPROFILE is now named NO_PROFILE in bsd.lib.mk
>
> grep(1) tells me that a number of other ports will also have this problem
>
> It may be appropriate with a bandaid in bsd.lib.mk, which emits a noisy
> warning, until all these ports are fixed.
>
> A good grep strategy is to look for files containing "NOPROFILE" and
> "bsd.lib.mk" but they need not be on the same line.

The two examples you showed in IRC didn't contain bsd.lib.mk-- but I
see no problem in simply changing all the instances of NO(PROFILE|MAN)
to NO_\1.

We know that a bandaid is effectively a revert of the removal; would
be better to simply fix the ports.  Only issue is, this doesn't catch
ports that use these variables in upstream; an exp-run is required for
that...

I'm running a grep for those two above-- are there any more I've missed?

Chris