From owner-freebsd-current@FreeBSD.ORG Fri Feb 15 22:31:51 2013 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D04016C8; Fri, 15 Feb 2013 22:31:51 +0000 (UTC) (envelope-from jmg@h2.funkthat.com) Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18]) by mx1.freebsd.org (Postfix) with ESMTP id A96CF9D5; Fri, 15 Feb 2013 22:31:51 +0000 (UTC) Received: from h2.funkthat.com (localhost [127.0.0.1]) by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id r1FMVoKx059104 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 15 Feb 2013 14:31:50 -0800 (PST) (envelope-from jmg@h2.funkthat.com) Received: (from jmg@localhost) by h2.funkthat.com (8.14.3/8.14.3/Submit) id r1FMVo7e059103; Fri, 15 Feb 2013 14:31:50 -0800 (PST) (envelope-from jmg) Date: Fri, 15 Feb 2013 14:31:50 -0800 From: John-Mark Gurney To: Dimitry Andric Subject: Re: the latest version of Clang/LLVM for the world and kernel Message-ID: <20130215223150.GG55866@funkthat.com> Mail-Followup-To: Dimitry Andric , deeptech71 , freebsd-current@freebsd.org References: <511E378E.3090200@gmail.com> <511E5B05.5050402@FreeBSD.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <511E5B05.5050402@FreeBSD.org> User-Agent: Mutt/1.4.2.3i X-Operating-System: FreeBSD 7.2-RELEASE i386 X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88 9322 9CB1 8F74 6D3F A396 X-Files: The truth is out there X-URL: http://resnet.uoregon.edu/~gurney_j/ X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger? X-Greylist: Sender passed SPF test, not delayed by milter-greylist-4.2.2 (h2.funkthat.com [127.0.0.1]); Fri, 15 Feb 2013 14:31:50 -0800 (PST) Cc: deeptech71 , freebsd-current@freebsd.org X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Feb 2013 22:31:51 -0000 Dimitry Andric wrote this message on Fri, Feb 15, 2013 at 16:57 +0100: > >/usr/src/usr.sbin/wpa/wpa_passphrase/../../../contrib/wpa//src/crypto/md5-internal.c:191:30: note: did you mean to dereference the argument to 'sizeof' (and multiply it by the number of elements)? > >* os_memset(ctx, 0, sizeof(ctx)); /* In case it's sensitive */ > >* ^~~ > >There just has to be an organization behind these backdoors... > > No, this is just a very common error. The idiom is either: > > memset(&object, 0, sizeof object); > > or > > memset(&pointer, 0, sizeof *pointer); > > but apparently it is difficult to choose the right one. :) I assume you mean: memset(pointer, 0, sizeof *pointer); :) -- John-Mark Gurney Voice: +1 415 225 5579 "All that I will do, has been done, All that I have, has not."