From owner-cvs-src@FreeBSD.ORG Fri Mar 3 21:48:46 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 49A2016A420; Fri, 3 Mar 2006 21:48:46 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: from mail.garage.freebsd.pl (arm132.internetdsl.tpnet.pl [83.17.198.132]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7D94243D67; Fri, 3 Mar 2006 21:48:45 +0000 (GMT) (envelope-from pjd@garage.freebsd.pl) Received: by mail.garage.freebsd.pl (Postfix, from userid 65534) id 0253B51756; Fri, 3 Mar 2006 22:48:43 +0100 (CET) Received: from localhost (dlp8.neoplus.adsl.tpnet.pl [83.24.45.8]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.garage.freebsd.pl (Postfix) with ESMTP id 19E8D5174A; Fri, 3 Mar 2006 22:48:39 +0100 (CET) Date: Fri, 3 Mar 2006 22:48:19 +0100 From: Pawel Jakub Dawidek To: Jeff Roberson Message-ID: <20060303214819.GB11030@garage.freebsd.pl> References: <200603020537.k225bi8G006318@repoman.freebsd.org> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="hHWLQfXTYDoKhP50" Content-Disposition: inline In-Reply-To: <200603020537.k225bi8G006318@repoman.freebsd.org> X-PGP-Key-URL: http://people.freebsd.org/~pjd/pjd.asc X-OS: FreeBSD 7.0-CURRENT i386 User-Agent: mutt-ng/devel-r535 (FreeBSD) X-Spam-Checker-Version: SpamAssassin 3.0.4 (2005-06-05) on mail.garage.freebsd.pl X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,RCVD_IN_NJABL_DUL, RCVD_IN_SORBS_DUL autolearn=no version=3.0.4 Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, phk@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/geom geom_vfs.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Mar 2006 21:48:46 -0000 --hHWLQfXTYDoKhP50 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Mar 02, 2006 at 05:37:44AM +0000, Jeff Roberson wrote: +> jeff 2006-03-02 05:37:44 UTC +>=20 +> FreeBSD src repository +>=20 +> Modified files: +> sys/geom geom_vfs.c=20 +> Log: +> - Lock Giant if needed around the call to vnode_create_vobject(). Th= is is +> only important if devfs is not mpsafe. [...] +> g_topology_assert(); +> @@ -147,7 +148,9 @@ g_vfs_open(struct vnode *vp, struct g_co +> g_wither_geom(gp, ENXIO); +> return (error); +> } +> + vfslocked =3D VFS_LOCK_GIANT(vp->v_mount); +> vnode_create_vobject(vp, pp->mediasize, curthread); +> + VFS_UNLOCK_GIANT(vfslocked); Acquiring Giant while holding the topology lock is a bad thing, AFAIK. CCing phk@ to correct me if I'm wrong or explain why exactly I'm right. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --hHWLQfXTYDoKhP50 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2 (FreeBSD) iD8DBQFECLmjForvXbEpPzQRApjTAJ9uFBdWx9cygKU7/X5nAvABgvtE9ACfSGJU 30YFh8vrUmAKNVldLQfRYjw= =3xbU -----END PGP SIGNATURE----- --hHWLQfXTYDoKhP50--