From owner-svn-src-all@FreeBSD.ORG Wed Apr 22 17:15:42 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id D1984428; Wed, 22 Apr 2015 17:15:42 +0000 (UTC) Date: Wed, 22 Apr 2015 17:15:42 +0000 From: Alexey Dokuchaev To: "Pedro F. Giffuni" Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r281858 - head/lib/libc/regex Message-ID: <20150422171542.GA4240@FreeBSD.org> References: <201504221709.t3MH93vD054506@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201504221709.t3MH93vD054506@svn.freebsd.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Apr 2015 17:15:42 -0000 On Wed, Apr 22, 2015 at 05:09:03PM +0000, Pedro F. Giffuni wrote: > New Revision: 281858 > URL: https://svnweb.freebsd.org/changeset/base/281858 > > Log: > computematchjumps(): fix allocator sizeof operand mismatch. > [...] > - pmatches = (int*) malloc(g->mlen * sizeof(unsigned int)); > + pmatches = (int*) malloc(g->mlen * sizeof(int)); > if (pmatches == NULL) { > g->matchjump = NULL; > return; > } > > - g->matchjump = (int*) malloc(g->mlen * sizeof(unsigned int)); > + g->matchjump = (int*) malloc(g->mlen * sizeof(int)); Since you've touched these lines, you could'be also removed (int *) casting from malloc() calls. But now it's too late (does not warrant another commit). ./danfe