From owner-freebsd-ports  Thu Jun  7 10:40: 8 2001
Delivered-To: freebsd-ports@hub.freebsd.org
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by hub.freebsd.org (Postfix) with ESMTP id 88CB937B403
	for <freebsd-ports@hub.freebsd.org>; Thu,  7 Jun 2001 10:40:03 -0700 (PDT)
	(envelope-from gnats@FreeBSD.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.11.3/8.11.3) id f57He3K95923;
	Thu, 7 Jun 2001 10:40:03 -0700 (PDT)
	(envelope-from gnats)
Date: Thu, 7 Jun 2001 10:40:03 -0700 (PDT)
Message-Id: <200106071740.f57He3K95923@freefall.freebsd.org>
To: freebsd-ports@FreeBSD.org
Cc: 
From: Laurent Wacrenier <lwa@teaser.fr>
Subject: Re: ports/20601: DESTDIR and /etc/shells
Reply-To: Laurent Wacrenier <lwa@teaser.fr>
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-ports.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-ports>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-ports>
X-Loop: FreeBSD.org

The following reply was made to PR ports/20601; it has been noted by GNATS.

From: Laurent Wacrenier <lwa@teaser.fr>
To: Peter Pentchev <roam@orbitel.bg>
Cc: lwa@victor.teaser.fr, markp@FreeBSD.org,
	freebsd-gnats-submit@FreeBSD.org
Subject: Re: ports/20601: DESTDIR and /etc/shells
Date: Thu, 7 Jun 2001 19:32:18 +0200

 Peter Pentchev wrote:
  
 > This is a valid complaint.  However, the problem lies much deeper -
 > it's not just /etc/shells.
 
 I guess so, but I needed only this for the shells when I posted the
 problem.
 
 In most cases, the fix is simply to preprend ${DESTDIR} at the destination
 of the "install", "rm", ... statements of {pre-|post-}install targets.
 The main difficulty is to seek them all in the ports.
 
 > A very simplistic fix for the case of shells is attached.  It's made
 > for the shells/bash2 port, but it could be applied (with a little tweaking)
 
 I don't fully agree with your patch :
 
  - ${PREFIX} does not contain ${DESTDIR}, If I install bash with DESTDIR=/mnt,
    ${PREFIX} still has its default value of /usr/local, so, you have not
    to trim /mnt from ${PREFIX} in ${DESTDIR}/etc/shells contents.
 
  - (minor) ${DESTDIR}/etc and ${DESTDIR}/etc/shells are expected to already
    exists if you made previously what it's explained in jail(8) manual page.
    You are expected to install ports in a functional hierarchy.
 
 

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message