From owner-cvs-all@FreeBSD.ORG Tue Jan 25 10:32:52 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1C4D616A4CE; Tue, 25 Jan 2005 10:32:52 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id 55F9643D41; Tue, 25 Jan 2005 10:32:51 +0000 (GMT) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id j0PAWo5T029678; Tue, 25 Jan 2005 13:32:50 +0300 (MSK) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.13.1/8.13.1/Submit) id j0PAWoRZ029675; Tue, 25 Jan 2005 13:32:50 +0300 (MSK) (envelope-from ache) Date: Tue, 25 Jan 2005 13:32:50 +0300 From: Andrey Chernov To: Poul-Henning Kamp Message-ID: <20050125103250.GA29461@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Poul-Henning Kamp , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20050125101457.GA28600@nagual.pp.ru> <80763.1106648792@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <80763.1106648792@critter.freebsd.dk> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter (version: 1.1.0-3; AVE: 6.29.0.8; VDF: 6.29.0.77; host: nagual.pp.ru) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.5.6 (nagual.pp.ru [0.0.0.0]); Tue, 25 Jan 2005 13:32:50 +0300 (MSK) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern sys_generic.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2005 10:32:52 -0000 On Tue, Jan 25, 2005 at 11:26:32AM +0100, Poul-Henning Kamp wrote: > Show me code which breaks please. It is not an argument. Your commit violates both POSIX and SUSv3, namely this thing: "This volume of IEEE Std 1003.1-2001 requires that no action be taken for read() or write() when nbyte is zero. This is not intended to take precedence over detection of errors (such as invalid buffer pointers or file descriptors). This is consistent with the rest of this volume of IEEE Std 1003.1-2001, but the phrasing here could be misread to require detection of the zero case before any other errors." I simple don't want to spend time to search code now broken. If you read my previous message to the end, I already mention the case which is obviously broken: FIFOs blocking and EAGAIN returning - it must happens for zero byte reads too. -- http://ache.pp.ru/