From owner-freebsd-ports@FreeBSD.ORG Sun Feb 19 03:03:20 2012 Return-Path: Delivered-To: freebsd-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 42B0D106566B; Sun, 19 Feb 2012 03:03:20 +0000 (UTC) (envelope-from linimon@lonesome.com) Received: from mail.soaustin.net (pancho.soaustin.net [76.74.250.40]) by mx1.freebsd.org (Postfix) with ESMTP id 1F92E8FC15; Sun, 19 Feb 2012 03:03:19 +0000 (UTC) Received: by mail.soaustin.net (Postfix, from userid 502) id E1F185620E; Sat, 18 Feb 2012 21:03:18 -0600 (CST) Date: Sat, 18 Feb 2012 21:03:18 -0600 From: Mark Linimon To: Doug Barton Message-ID: <20120219030318.GB6927@lonesome.com> References: <20120217182214.GD11416@lonesome.com> <4F403B69.9030503@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4F403B69.9030503@FreeBSD.org> User-Agent: Mutt/1.5.20 (2009-06-14) Cc: Michael Scheidell , Andriy Gapon , Steve Kargl , Chris Rees , "freebsd-ports@FreeBSD.org" Subject: Re: Please test your commits X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Feb 2012 03:03:20 -0000 On Sat, Feb 18, 2012 at 03:59:37PM -0800, Doug Barton wrote: > Where I think reasonable minds can differ are (appropriate) responses of > the form, "This was not done properly, here is how it can/should be done > (better)." IMO those should *always* be public in order to help others > who are paying attention to the same topic. Fair enough. Perhaps I should have been more clear about the distinction I make between constructive criticism ("this code would be more effectively stated xyz") vs. non-constructive criticism ("your mother smells of elderberries".) I was thinking more of the latter when I replied, perhaps after wincing at some recent threads. mcl