From owner-freebsd-bugs  Sat May  4  2:48: 1 2002
Delivered-To: freebsd-bugs@freebsd.org
Received: from salmon.maths.tcd.ie (salmon.maths.tcd.ie [134.226.81.11])
	by hub.freebsd.org (Postfix) with SMTP id 7A71E37B425
	for <freebsd-bugs@FreeBSD.org>; Sat,  4 May 2002 02:47:58 -0700 (PDT)
Received: from walton.maths.tcd.ie by salmon.maths.tcd.ie with SMTP
          id <aa99339@salmon>; 4 May 2002 10:47:57 +0100 (BST)
Date: Sat, 4 May 2002 10:47:57 +0100
From: David Malone <dwmalone@maths.tcd.ie>
To: Edwin Groothuis <edwin@mavetju.org>
Cc: freebsd-bugs@FreeBSD.org
Subject: Re: bin/37702: /usr/bin/top uses 100% cpu in 'system'
Message-ID: <20020504094757.GA59372@walton.maths.tcd.ie>
References: <200205031250.g43Co7H79157@freefall.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200205031250.g43Co7H79157@freefall.freebsd.org>
User-Agent: Mutt/1.3.25i
Sender: owner-freebsd-bugs@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-bugs.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-bugs>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-bugs>
X-Loop: FreeBSD.org

On Fri, May 03, 2002 at 05:50:07AM -0700, Edwin Groothuis wrote:
>                case 's':
>  -               if ((delay = atoi(optarg)) < 0)
>  +               if ((delay = atoi(optarg)) <= 0)
>                  {

I think this has been fixed in -current in another way:

	if ((delay = atoi(optarg)) < 0 || (delay == 0 && getuid() != 0))

this means you're only alowd to get continious updates if you're
root. (This change came from the last beta version of top which
was released by the original authors.)

	David.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-bugs" in the body of the message