From owner-freebsd-smp Wed Aug 22 0:41:17 2001 Delivered-To: freebsd-smp@freebsd.org Received: from snipe.mail.pas.earthlink.net (snipe.mail.pas.earthlink.net [207.217.120.62]) by hub.freebsd.org (Postfix) with ESMTP id 2F7F937B406; Wed, 22 Aug 2001 00:41:10 -0700 (PDT) (envelope-from tlambert2@mindspring.com) Received: from mindspring.com (dialup-209.245.135.228.Dial1.SanJose1.Level3.net [209.245.135.228]) by snipe.mail.pas.earthlink.net (8.11.5/8.9.3) with ESMTP id f7M7f6h27454; Wed, 22 Aug 2001 00:41:06 -0700 (PDT) Message-ID: <3B83623D.9DC45B93@mindspring.com> Date: Wed, 22 Aug 2001 00:41:49 -0700 From: Terry Lambert Reply-To: tlambert2@mindspring.com X-Mailer: Mozilla 4.7 [en]C-CCK-MCD {Sony} (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Matt Dillon Cc: Jake Burkholder , John Baldwin , freebsd-smp@FreeBSD.ORG, freebsd-alpha@FreeBSD.ORG Subject: Re: Preliminary proposed rollup of kernel submap initialization code References: <200108210157.f7L1vAh10384@k7.locore.ca> <200108211736.f7LHaoC64628@earth.backplane.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: owner-freebsd-smp@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org Matt Dillon wrote: > -static vm_offset_t buffer_sva, buffer_eva; > -vm_offset_t clean_sva, clean_eva; > -static vm_offset_t pager_sva, pager_eva; > +struct kva_md_info kmi; You make this a non-static global... > + vm_ksubmap_init(&kmi); Then you pass it's address in... > +void > +vm_ksubmap_init(struct kva_md_info *kmi) > +{ And then use much more expensive pointer arithmatic... > + buffer_map = kmem_suballoc(clean_map, &kmi->buffer_sva, > + &kmi->buffer_eva, (nbuf*BKVASIZE)); I understand that this is called once, but doesn't this really obfuscate things? -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-smp" in the body of the message