From owner-freebsd-current@FreeBSD.ORG  Tue Jun 22 12:29:07 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BF90816A4CE; Tue, 22 Jun 2004 12:29:07 +0000 (GMT)
Received: from relay.macomnet.ru (relay.macomnet.ru [195.128.64.10])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id AC86C43D54; Tue, 22 Jun 2004 12:29:04 +0000 (GMT)
	(envelope-from maxim@macomnet.ru)
Received: from mp2.macomnet.net (remyxi0k@mp2.macomnet.net [195.128.64.6])
	by relay.macomnet.ru (8.12.10/8.12.10) with ESMTP id i5MCT1u517292108;
	Tue, 22 Jun 2004 16:29:01 +0400 (MSD)
Date: Tue, 22 Jun 2004 16:29:01 +0400 (MSD)
From: Maxim Konovalov <maxim@macomnet.ru>
To: Andre Oppermann <andre@freebsd.org>
In-Reply-To: <40D81A53.FD490D89@freebsd.org>
Message-ID: <20040622162616.O7191@mp2.macomnet.net>
References: <40D754D5.1070805@freebsd.org>
	<20040622115532.W5744@mp2.macomnet.net>
	<40D81A53.FD490D89@freebsd.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: freebsd-net@freebsd.org
cc: freebsd-current@freebsd.org
Subject: Re: New preview patch for ipfw to pfil_hooks conversion
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jun 2004 12:29:07 -0000

On Tue, 22 Jun 2004, 13:38+0200, Andre Oppermann wrote:

> Maxim Konovalov wrote:
> >
> > Hi Andre,
> >
> > On Mon, 21 Jun 2004, 23:36+0200, Andre Oppermann wrote:
> >
> > > Here is the next preview patch for the ipfw to pfil_hooks conversion:
> > >
> > >  http://www.nrg4u.com/freebsd/ipfw-pfilhooks-and-more-20040621.diff
> > >
> > > This patch significantly cleans up ip_input.c and ip_output.c.
> >
> > Is it possible to split that ~100KB patch in a logic chunks?  One for
> > phil_hook, one for ip_pcbopt, one for ip_reass etc.  Much easier to
> > review and commit them later.
>
> Of course it will be split up.  I haven't done this because this is
> only a preview patch of work in progress.

Please HEADSUP us before commit or drop me a note, I am willing to
review reass/ip options code as I spent a lot of hours parsing it.

As a side note, what is "#define MAX_IPOPTLEN    40" in
ip_options.h for?  There is one in ip_var.h.

-- 
Maxim Konovalov