From owner-cvs-all@FreeBSD.ORG  Fri Nov 16 23:36:59 2007
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.ORG
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1DC3C16A46D;
	Fri, 16 Nov 2007 23:36:59 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id C142313C467;
	Fri, 16 Nov 2007 23:36:58 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from critter.freebsd.dk (unknown [192.168.61.3])
	by phk.freebsd.dk (Postfix) with ESMTP id 268C017105;
	Fri, 16 Nov 2007 23:36:54 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.1/8.14.1) with ESMTP id lAGNarXY034235;
	Fri, 16 Nov 2007 23:36:53 GMT (envelope-from phk@critter.freebsd.dk)
To: Scott Long <scottl@samsco.org>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Fri, 16 Nov 2007 16:21:25 MST."
	<473E25F5.1090805@samsco.org> 
Date: Fri, 16 Nov 2007 23:36:53 +0000
Message-ID: <34234.1195256213@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG,
	=?ISO-8859-1?Q?S=F8ren_Schmidt?= <sos@deepcore.dk>,
	Nate Lawson <nate@root.org>
Subject: Re: cvs commit: src/sys/dev/ata atapi-cd.c atapi-cd.h 
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 16 Nov 2007 23:36:59 -0000

In message <473E25F5.1090805@samsco.org>, Scott Long writes:

>Ok, back on track.  What you want to do is make g_access largely 
>irrelevant, and have the _real_ access check done in g_start.  Fine.

Only for drive mechanisms that require out of band ioctls issued
over the inband channel in order to enable access to the media.

In other words CD drives.

>Is there any reason at all to make g_access not return success from
>now on? 

g_access is also responsible for checking read/writeability of the
media against the requested permissions.

>is what I'm arguing against; you're advocating a hack that works well
>enough for you and ignoring the larger architectural issue, which I
>think is important.  But anyways.

I think you misunderstand something here.

The only suggested change is that the printfs in geom gets supressed
for this one particular errno.

Nothing else changes as far as I know.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.