From owner-cvs-src@FreeBSD.ORG  Sat Nov 19 22:02:33 2005
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 83CA116A41F;
	Sat, 19 Nov 2005 22:02:33 +0000 (GMT)
	(envelope-from flata@magnesium.net)
Received: from toxic.magnesium.net (toxic.magnesium.net [207.154.84.15])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4670B43D46;
	Sat, 19 Nov 2005 22:02:33 +0000 (GMT)
	(envelope-from flata@magnesium.net)
Received: by toxic.magnesium.net (Postfix, from userid 1212)
	id 12D0FDA871; Sat, 19 Nov 2005 14:02:33 -0800 (PST)
Date: Sat, 19 Nov 2005 12:02:33 -1000
From: juli mallett <jmallett@FreeBSD.org>
To: Ed Maste <emaste@FreeBSD.org>
Message-ID: <20051119220233.GA5935@toxic.magnesium.net>
References: <200511181941.jAIJftnL027282@repoman.freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200511181941.jAIJftnL027282@repoman.freebsd.org>
X-Towel: Yes
User-Agent: Mutt/1.5.11
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/sys queue.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Nov 2005 22:02:33 -0000

Maybe it should be KERNEL && INVARIANTS, for the sake of userland apps
using queue.h which may have their own INVARIANTS define but not their
own panic(9) implementation?

* Ed Maste <emaste@FreeBSD.org> [ Date: 2005-11-18 ]
	[ w.r.t. cvs commit: src/sys/sys queue.h ]
> emaste      2005-11-18 19:41:55 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/sys              queue.h 
>   Log:
>   Add sanity checking for QUEUE(3) lists under INVARIANTS.  Races may lead
>   to list corruption, which can be difficult to unravel in a post-mortem
>   analysis.  These checks verify that prev and next pointers are consistent
>   when inserting or removing elements, thus catching any corruption earlier.
>   
>   Also use TRASHIT to break LIST and SLIST link pointers on element removal,
>   from mlaier via -hackers.
>   
>   Reviewed by:    mlaier
>   Approved by:    rwatson (mentor)
>   
>   Revision  Changes    Path
>   1.62      +35 -2     src/sys/sys/queue.h

-- 
Go to sleep.  Go to sleep.  Go to sleep.