From owner-svn-src-user@FreeBSD.ORG Mon Jun 1 14:26:19 2009 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB0031065672; Mon, 1 Jun 2009 14:26:19 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id ADB548FC2A; Mon, 1 Jun 2009 14:26:19 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from bigwig.baldwin.cx (66.111.2.69.static.nyinternet.net [66.111.2.69]) by cyrus.watson.org (Postfix) with ESMTPSA id 64A1146B23; Mon, 1 Jun 2009 10:26:19 -0400 (EDT) Received: from jhbbsd.hudson-trading.com (unknown [209.249.190.8]) by bigwig.baldwin.cx (Postfix) with ESMTPA id 3D2238A02B; Mon, 1 Jun 2009 10:26:18 -0400 (EDT) From: John Baldwin To: Kip Macy Date: Mon, 1 Jun 2009 08:15:49 -0400 User-Agent: KMail/1.9.7 References: <200905300105.n4U15VAF092086@svn.freebsd.org> In-Reply-To: <200905300105.n4U15VAF092086@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200906010815.49692.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.0.1 (bigwig.baldwin.cx); Mon, 01 Jun 2009 10:26:18 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.95 at bigwig.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.5 required=4.2 tests=AWL,BAYES_00,RDNS_NONE autolearn=no version=3.2.5 X-Spam-Checker-Version: SpamAssassin 3.2.5 (2008-06-10) on bigwig.baldwin.cx Cc: src-committers@freebsd.org, svn-src-user@freebsd.org Subject: Re: svn commit: r193078 - in user/kmacy/releng_7_2_fcs/sys: amd64/amd64 vm X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 01 Jun 2009 14:26:20 -0000 On Friday 29 May 2009 9:05:31 pm Kip Macy wrote: > - --m->wire_count; > + atomic_subtract_int(&m->wire_count, 1); > if (m->wire_count == 0) > return _pmap_unwire_pte_hold(pmap, va, m, free); This is not safe. Use atomic_fetchadd() instead to do this atomically the way refcount_* do. -- John Baldwin