From owner-freebsd-pf@FreeBSD.ORG  Tue Sep 18 16:15:23 2012
Return-Path: <owner-freebsd-pf@FreeBSD.ORG>
Delivered-To: freebsd-pf@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 738461065691;
	Tue, 18 Sep 2012 16:15:23 +0000 (UTC)
	(envelope-from glebius@FreeBSD.org)
Received: from cell.glebius.int.ru (glebius.int.ru [81.19.64.117])
	by mx1.freebsd.org (Postfix) with ESMTP id E1D4A8FC1B;
	Tue, 18 Sep 2012 16:15:22 +0000 (UTC)
Received: from cell.glebius.int.ru (localhost [127.0.0.1])
	by cell.glebius.int.ru (8.14.5/8.14.5) with ESMTP id q8IGFGqL032797;
	Tue, 18 Sep 2012 20:15:16 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
Received: (from glebius@localhost)
	by cell.glebius.int.ru (8.14.5/8.14.5/Submit) id q8IGFGZW032796;
	Tue, 18 Sep 2012 20:15:16 +0400 (MSK)
	(envelope-from glebius@FreeBSD.org)
X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to
	glebius@FreeBSD.org using -f
Date: Tue, 18 Sep 2012 20:15:16 +0400
From: Gleb Smirnoff <glebius@FreeBSD.org>
To: Ermal Lu?i <eri@FreeBSD.org>
Message-ID: <20120918161516.GG85604@glebius.int.ru>
References: <201209181234.q8ICYaFB091109@svn.freebsd.org>
	<CAE-mSOJFHSSTmOBYYqUQkF3s_zK4aGTz2GXZWRo-ZfzJmhZazQ@mail.gmail.com>
	<CAPBZQG3JbsCOMAvYrOjVyRhbS6pfWxnyoaaMO8B+Hp=pUdXk_A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <CAPBZQG3JbsCOMAvYrOjVyRhbS6pfWxnyoaaMO8B+Hp=pUdXk_A@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Sergey Kandaurov <pluknet@FreeBSD.org>, freebsd-pf@FreeBSD.org
Subject: Re: svn commit: r240646 - head/sys/contrib/altq/altq
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Technical discussion and general questions about packet filter
	\(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
	<mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 18 Sep 2012 16:15:23 -0000

  Ermal,

On Tue, Sep 18, 2012 at 06:02:06PM +0200, Ermal Lu?i wrote:
E> The issue is that this hides the problem per se.

What had hidden problem per se, was the following code:

                        PF_UNLOCK();
                        error = altq_add(a2);
                        PF_LOCK();

That's what we have in stable/9.

E> The ioctl and pfctl loading of ruleset is not ready for handling failures here!

They do. Error from altq_add() is returned by pf_ioctl() as response
to DIOCADDALTQ command. The code in pfctl, which does DIOCADDALTQ also
is handling errors.

-- 
Totus tuus, Glebius.