From owner-freebsd-bugs@FreeBSD.ORG Tue Sep 20 12:20:09 2011 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 75985106564A for ; Tue, 20 Sep 2011 12:20:09 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 38B3C8FC18 for ; Tue, 20 Sep 2011 12:20:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p8KCK9FS008526 for ; Tue, 20 Sep 2011 12:20:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p8KCK9If008525; Tue, 20 Sep 2011 12:20:09 GMT (envelope-from gnats) Resent-Date: Tue, 20 Sep 2011 12:20:09 GMT Resent-Message-Id: <201109201220.p8KCK9If008525@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Andrey Zonov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1F83F1065672 for ; Tue, 20 Sep 2011 12:19:03 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 0F0768FC1A for ; Tue, 20 Sep 2011 12:19:03 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id p8KCJ2f5002466 for ; Tue, 20 Sep 2011 12:19:02 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id p8KCJ2cd002465; Tue, 20 Sep 2011 12:19:02 GMT (envelope-from nobody) Message-Id: <201109201219.p8KCJ2cd002465@red.freebsd.org> Date: Tue, 20 Sep 2011 12:19:02 GMT From: Andrey Zonov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/160848: [patch] [etc/periodic] 310.accounting ignore $daily_accounting_save X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Sep 2011 12:20:09 -0000 >Number: 160848 >Category: misc >Synopsis: [patch] [etc/periodic] 310.accounting ignore $daily_accounting_save >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Sep 20 12:20:08 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Andrey Zonov >Release: 8.2-STABLE >Organization: >Environment: >Description: Last commit to /etc/periodic/daily/310.accounting broke rotation accounting logs. >How-To-Repeat: Turn on accouting: echo 'accounting_enable="YES"' > /etc/rc.conf.d/accounting Check /var/account/ after few days. You will find that there's only one `acct' file. >Fix: Patch is in attach. Patch attached with submission follows: Index: 310.accounting =================================================================== --- 310.accounting (revision 225579) +++ 310.accounting (working copy) @@ -44,13 +44,12 @@ /etc/rc.d/accounting rotate_log || rc=3 + sa $daily_accounting_flags /var/account/acct.0 || rc=3 + case "$daily_accounting_compress" in [Yy][Ee][Ss]) - gzip --keep -f acct.0 || rc=3;; + gzip -f acct.0 || rc=3;; esac - - sa -s $daily_accounting_flags /var/account/acct.0 && - unlink acct.0 || rc=3 fi;; *) rc=0;; >Release-Note: >Audit-Trail: >Unformatted: