From owner-p4-projects@FreeBSD.ORG Wed Aug 30 21:31:30 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 6289A16A4E7; Wed, 30 Aug 2006 21:31:30 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3AFFF16A4E5 for ; Wed, 30 Aug 2006 21:31:30 +0000 (UTC) (envelope-from millert@freebsd.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 57F9543D6E for ; Wed, 30 Aug 2006 21:31:18 +0000 (GMT) (envelope-from millert@freebsd.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k7ULVHgj038453 for ; Wed, 30 Aug 2006 21:31:17 GMT (envelope-from millert@freebsd.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k7ULVHVO038450 for perforce@freebsd.org; Wed, 30 Aug 2006 21:31:17 GMT (envelope-from millert@freebsd.org) Date: Wed, 30 Aug 2006 21:31:17 GMT Message-Id: <200608302131.k7ULVHVO038450@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to millert@freebsd.org using -f From: Todd Miller To: Perforce Change Reviews Cc: Subject: PERFORCE change 105372 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2006 21:31:30 -0000 http://perforce.freebsd.org/chv.cgi?CH=105372 Change 105372 by millert@millert_g4tower on 2006/08/30 21:30:43 Do not consume a port reference in labelh_destroy(), ipc_port_destroy() will do this for us. Fixes an int underflow that was causing label handle ipc ports to never be deallocated. Affected files ... .. //depot/projects/trustedbsd/sedarwin8/darwin/xnu/osfmk/ipc/ipc_labelh.c#3 edit Differences ... ==== //depot/projects/trustedbsd/sedarwin8/darwin/xnu/osfmk/ipc/ipc_labelh.c#3 (text+ko) ==== @@ -202,7 +202,6 @@ { ipc_labelh_t lh = (ipc_labelh_t) port->ip_kobject; - ip_release(lh->lh_port); mac_port_destroy_label(&lh->lh_label); zfree(ipc_labelh_zone, (vm_offset_t)lh); }