From owner-freebsd-current@FreeBSD.ORG Thu Oct 2 17:54:49 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1E76316A4B3 for ; Thu, 2 Oct 2003 17:54:49 -0700 (PDT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3EDCC43FE9 for ; Thu, 2 Oct 2003 17:54:48 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.9p2/8.12.9) with ESMTP id h930s77R029983; Thu, 2 Oct 2003 20:54:07 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)h930s7aK029980; Thu, 2 Oct 2003 20:54:07 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Thu, 2 Oct 2003 20:54:06 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Mark Woodson In-Reply-To: <200310021731.44227.mwoodson@sricrm.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: current@FreeBSD.org Subject: Re: lor on boot X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 03 Oct 2003 00:54:49 -0000 On Thu, 2 Oct 2003, Mark Woodson wrote: > On Thursday 02 October 2003 05:07 pm, Robert Watson wrote: > > On Thu, 2 Oct 2003, Mark Woodson wrote: > > > I'm getting a lor on a system just upgraded to sources from this > > > morning. The systems been running fine for the past month or so. > > > > What version of src/sys/net/netisr.c are you running with? > > * $FreeBSD: src/sys/net/netisr.c,v 1.4 2003/10/01 21:31:09 rwatson > Exp $ > > That's what I'm showing. So it's from last night then. Ah. Ok, this is because the if_rl driver holds the driver mutex across a call to the interface input routine, resulting in holding the mutex across a call into the remainder of the network stack. The reason this showed up for you now is that I temporarily enabled direct dispatch of the isr code directly from the driver interrupt threads for an hour or so last night, and you updated during that time. I backed it out to work on two issues -- one the possible reordering of packets (patch now bing reviewed), and the other that a few drivers currently hold their lock over the call into the remainder of the stack, which needs to be fixed. If you cvsup, the problem should go away. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories