From owner-cvs-all@FreeBSD.ORG Tue Jan 25 11:06:50 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id AF69016A4CE; Tue, 25 Jan 2005 11:06:50 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id E227C43D3F; Tue, 25 Jan 2005 11:06:49 +0000 (GMT) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id j0PB6mqr030721; Tue, 25 Jan 2005 14:06:48 +0300 (MSK) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.13.1/8.13.1/Submit) id j0PB6mPx030720; Tue, 25 Jan 2005 14:06:48 +0300 (MSK) (envelope-from ache) Date: Tue, 25 Jan 2005 14:06:48 +0300 From: Andrey Chernov To: Poul-Henning Kamp , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG Message-ID: <20050125110648.GB29791@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Poul-Henning Kamp , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20050125103250.GA29461@nagual.pp.ru> <80962.1106649452@critter.freebsd.dk> <20050125105811.GA29791@nagual.pp.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20050125105811.GA29791@nagual.pp.ru> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter (version: 1.1.0-3; AVE: 6.29.0.8; VDF: 6.29.0.77; host: nagual.pp.ru) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.5.6 (nagual.pp.ru [0.0.0.0]); Tue, 25 Jan 2005 14:06:49 +0300 (MSK) Subject: Re: cvs commit: src/sys/kern sys_generic.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2005 11:06:50 -0000 On Tue, Jan 25, 2005 at 01:58:11PM +0300, Andrey Chernov wrote: > What's about "invalid buffer pointers" detection, directly mentioned in > the standard (above)? Now it is broken for zero bytes read because your > newly inserted check takes precedence. The next precedence violation candidate in error detection will be: "[EIO] The process is a member of a background process attempting to read from its controlling terminal, the process is ignoring or blocking the SIGTTIN signal, or the process group is orphaned." I.e. look at ERRORS section list and inspect each errno returning broken by preliminary zero bytes check. -- http://ache.pp.ru/