From owner-freebsd-bugs@FreeBSD.ORG Mon Nov 22 17:50:08 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C03281065670 for ; Mon, 22 Nov 2010 17:50:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9787E8FC1D for ; Mon, 22 Nov 2010 17:50:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAMHo8Rp070452 for ; Mon, 22 Nov 2010 17:50:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAMHo8P6070451; Mon, 22 Nov 2010 17:50:08 GMT (envelope-from gnats) Resent-Date: Mon, 22 Nov 2010 17:50:08 GMT Resent-Message-Id: <201011221750.oAMHo8P6070451@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Anton Yuzhaninov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 53E04106566B for ; Mon, 22 Nov 2010 17:46:23 +0000 (UTC) (envelope-from citrin@citrin.ru) Received: from mail.vega.ru (mail.vega.ru [90.156.167.5]) by mx1.freebsd.org (Postfix) with ESMTP id 086AA8FC0A for ; Mon, 22 Nov 2010 17:46:22 +0000 (UTC) Received: from builder.corp.vega.ru ([10.25.1.165]) by mail.vega.ru with esmtps (TLSv1:AES256-SHA:256) (Exim 4.72 (FreeBSD)) (envelope-from ) id 1PKaHg-000Jde-6d for FreeBSD-gnats-submit@freebsd.org; Mon, 22 Nov 2010 20:34:32 +0300 Received: from builder.corp.vega.ru (builder.corp.vega.ru [10.25.1.165]) by builder.corp.vega.ru (8.14.4/8.14.4) with ESMTP id oAMHYWwS019741 for ; Mon, 22 Nov 2010 17:34:32 GMT (envelope-from citrin@citrin.ru) Received: (from ayuzhaninov@localhost) by builder.corp.vega.ru (8.14.4/8.14.4/Submit) id oAMHYViM019740; Mon, 22 Nov 2010 17:34:31 GMT (envelope-from citrin@citrin.ru) Message-Id: <201011221734.oAMHYViM019740@builder.corp.vega.ru> Date: Mon, 22 Nov 2010 17:34:31 GMT From: Anton Yuzhaninov To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: kern/152488: [tmpfs] mtime of file updated when only inode changed (file data not changed) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Anton Yuzhaninov List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Nov 2010 17:50:08 -0000 >Number: 152488 >Category: kern >Synopsis: [tmpfs] mtime of file updated when only inode changed (file data not changed) >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Nov 22 17:50:08 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Anton Yuzhaninov >Release: FreeBSD 9.0-CURRENT i386 >Organization: openstat.ru >Environment: System: FreeBSD citrin.office.vega.ru 9.0-CURRENT FreeBSD 9.0-CURRENT #0 r215180: Sat Nov 13 00:19:31 MSK 2010 citrin@citrin.office.vega.ru:/usr/obj/usr/src/sys/NK i386 >Description: According to stat(2), mtime (st_mtim) changed by the mknod(2), utimes(2), read(2) and readv(2) system calls (when file data modified). It seems to be true for ufs, but not true for tmpfs. On tmpfs mtime updated even if file data is not modified. >How-To-Repeat: :~> sudo mount -t tmpfs tmpfs tmp && cd tmp :~/tmp> touch -m -t 197001010000 xxx :~/tmp> stat -x xxx | egrep '(Modify|Change)' Modify: Thu Jan 1 00:00:00 1970 Change: Mon Nov 22 19:43:49 2010 :~/tmp> ln xxx xxx2 :~/tmp> stat -x xxx | egrep '(Modify|Change)' Modify: Thu Jan 1 00:00:00 1970 Change: Mon Nov 22 19:44:40 2010 :~/tmp> rm xxx2 :~/tmp> stat -x xxx | egrep '(Modify|Change)' Modify: Mon Nov 22 19:44:54 2010 Change: Mon Nov 22 19:44:54 2010 But expected: Modify: Thu Jan 1 00:00:00 1970 Change: Mon Nov 22 19:44:54 2010 >Fix: --- tmpfs.patch begins here --- Index: tmpfs_vnops.c =================================================================== --- tmpfs_vnops.c (revision 215543) +++ tmpfs_vnops.c (working copy) @@ -853,8 +853,7 @@ tmpfs_free_dirent(tmp, de, TRUE); if (node->tn_links > 0) - node->tn_status |= TMPFS_NODE_ACCESSED | TMPFS_NODE_CHANGED | \ - TMPFS_NODE_MODIFIED; + node->tn_status |= TMPFS_NODE_ACCESSED | TMPFS_NODE_CHANGED; error = 0; out: --- tmpfs.patch ends here --- >Release-Note: >Audit-Trail: >Unformatted: