From owner-freebsd-x11@FreeBSD.ORG Fri Jun 1 11:21:43 2007 Return-Path: X-Original-To: freebsd-x11@freebsd.org Delivered-To: freebsd-x11@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9765116A41F; Fri, 1 Jun 2007 11:21:43 +0000 (UTC) (envelope-from knu@iDaemons.org) Received: from mail.musha.org (daemon.musha.org [210.189.104.8]) by mx1.freebsd.org (Postfix) with ESMTP id 67B8913C4BB; Fri, 1 Jun 2007 11:21:38 +0000 (UTC) (envelope-from knu@iDaemons.org) Received: from daemon.musha.org (daemon.local.idaemons.org [192.168.1.1]) by mail.musha.org (Postfix) with ESMTP id 6B6CDDC48; Fri, 1 Jun 2007 19:49:20 +0900 (JST) Date: Fri, 01 Jun 2007 19:49:20 +0900 Message-ID: <86vee8ar0v.knu@iDaemons.org> From: "Akinori MUSHA" To: Rene Ladan In-Reply-To: <465DD002.6020205@gmail.com> References: <20070528185007.03E9C16A50C@hub.freebsd.org> <465B2AEA.5050102@gmail.com> <200705292322.35299.dejan.lesjak@ijs.si> <465DD002.6020205@gmail.com> Organization: Associated I. Daemons X-PGP-Public-Key: finger knu@FreeBSD.org X-PGP-Fingerprint: 081D 099C 1705 861D 4B70 B04A 920B EFC7 9FD9 E1EE MIME-Version: 1.0 (generated by EMIKO 1.14.1 - "Choanoflagellata") Content-Type: multipart/signed; boundary="pgp-sign-Multipart_Fri_Jun__1_19:49:20_2007-1"; micalg=pgp-sha1; protocol="application/pgp-signature" Content-Transfer-Encoding: 7bit Cc: freebsd-x11@freebsd.org, bug-followup@freebsd.org Subject: Re: ports/113099: [PATCH] sysutils/libchk may skip $X11BASE now X-BeenThere: freebsd-x11@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: X11 on FreeBSD -- maintaining and support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2007 11:21:43 -0000 --pgp-sign-Multipart_Fri_Jun__1_19:49:20_2007-1 Content-Type: text/plain; charset=US-ASCII Hi, At Wed, 30 May 2007 21:26:58 +0200, Rene Ladan wrote: > Dejan Lesjak wrote: > > USE_NONDEFAULT_X11BASE is only relevant on FreeBSD before 6.2 (as we > > cant set the default X11BASE in ports infrastructure there). On > > newer versions one can define different X11BASE even without also > > setting USE_NONDEFAULT_X11BASE. The ability to do that is left > > intentionally. > > Anyhow, perhaps a more general solution for libchk might be to skip > > $X11BASE if it is the same as $LOCALBASE? > > > This sounds reasonable. Akinori, what do you think of the attached patch? > + if $x11base != $localbase > + $bindirs += [ > + "#{$x11base}/bin", > + "#{$x11base}/libexec", > + "#{$x11base}/sbin", > + ] > + end I suppose this would not make any difference to the behavior, since duplicated or redundant directories (descendant of another entry, etc.) are removed in compact_dirs!(). The real problem might be that in that process libchk does not use realpath(3) to follow symlinks but just performs static, literal string matching. So if you have /usr/X11R6 symlinked to /usr/local, libchk will dive into the directory twice. Regards, -- / /__ __ Akinori.org / MUSHA.org / ) ) ) ) / FreeBSD.org / Ruby-lang.org Akinori MUSHA aka / (_ / ( (__( @ iDaemons.org / and.or.jp "Different eyes see different things, Different hearts beat on different strings -- But there are times for you and me when all such things agree" --pgp-sign-Multipart_Fri_Jun__1_19:49:20_2007-1 Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (FreeBSD) iD8DBQBGX/mwkgvvx5/Z4e4RAiXPAJ0UkXVCFJ/X5NV4MruxkntJojbivQCdGYmF aL6f7fFTbovxqN2rChmq5+Q= =HhdN -----END PGP SIGNATURE----- --pgp-sign-Multipart_Fri_Jun__1_19:49:20_2007-1--