From owner-cvs-src@FreeBSD.ORG Sat May 22 10:40:35 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D6C6116A4CE for ; Sat, 22 May 2004 10:40:35 -0700 (PDT) Received: from root.org (root.org [67.118.192.226]) by mx1.FreeBSD.org (Postfix) with SMTP id A1E0643D2D for ; Sat, 22 May 2004 10:40:35 -0700 (PDT) (envelope-from nate@root.org) Received: (qmail 58845 invoked by uid 1000); 22 May 2004 17:40:01 -0000 Date: Sat, 22 May 2004 10:40:01 -0700 (PDT) From: Nate Lawson To: Bruce M Simpson In-Reply-To: <20040521134038.GE90068@empiric.dek.spc.org> Message-ID: <20040522103854.I58631@root.org> References: <200405210636.i4L6aadV059034@repoman.freebsd.org> <40ADAF07.2070909@freebsd.org> <20040521.020412.118756775.imp@bsdimp.com> <40ADBC15.6040004@freebsd.org> <20040521134038.GE90068@empiric.dek.spc.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: cvs-src@freebsd.org cc: src-committers@freebsd.org cc: Scott Long cc: cvs-all@freebsd.org cc: "M. Warner Losh" Subject: Re: cvs commit: src/sys/dev/pci pci.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 May 2004 17:40:35 -0000 On Fri, 21 May 2004, Bruce M Simpson wrote: > On Fri, May 21, 2004 at 02:21:41AM -0600, Scott Long wrote: > > Well, the 8.3.3 paragraph only specifically mentions the command > > register and the BARs. I'm just worried that by touching stuff outside > > of this range that you open up the risk of tickling latent buggy > > silicon. Exception cases like the ATA hardware doing magic things with > > the progif register should be left up to the ATA driver. It's exactly > > those kinds of bent-rules that makes me nervous =-) > > Maybe this behaviour could be enabled or disabled with an instance variable? > I can think of one example of hardware which might need this. I owned an > IBM ThinkPad T22 with an xl(4) NIC for about a year, and one of the things > which annoyed me about suspend/resume was the tendency for it to lose its > PCI configuration. Yes, this almost certainly required it. The question is whether any PCI device could be broken from excessive poking of its config space. I really doubt this. -Nate