From owner-freebsd-stable@FreeBSD.ORG Sat Jan 23 14:51:09 2010 Return-Path: Delivered-To: freebsd-stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C0365106566C; Sat, 23 Jan 2010 14:51:09 +0000 (UTC) (envelope-from to.my.trociny@gmail.com) Received: from mail-fx0-f226.google.com (mail-fx0-f226.google.com [209.85.220.226]) by mx1.freebsd.org (Postfix) with ESMTP id 272D98FC20; Sat, 23 Jan 2010 14:51:08 +0000 (UTC) Received: by fxm26 with SMTP id 26so2076519fxm.13 for ; Sat, 23 Jan 2010 06:51:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:to:cc:subject:references :organization:from:date:in-reply-to:message-id:user-agent :mime-version:content-type; bh=2oX4HIw7PMEf2Z+H5a4yCLpdVvoFVr1p8PUmtvc0GUw=; b=xEYj8RmyTBMzkSI+jI7MlTcQOhnBWAXIhFDlOwUzf2XGIUsMY9FMVFBWHNLnGBbEap NTodRVr6uuvOkaIYRozC6T1qxRYp0kxMBiIFputEAbZ2U+2dotwizK8Cci0otHTwy91Q e4dnStFZcODMeNI8TeFqFg77dILppI71ErAw4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=to:cc:subject:references:organization:from:date:in-reply-to :message-id:user-agent:mime-version:content-type; b=atBgxoyZ9VkvH18svZeKRIq++6BvutO6xJ+9wL4dmk97L871SNP0jloG5KlDBOsklH +SuTercGMmseD2RkL7Nb2G1nR7Z2+adBPXy5Mt9BGzZGI2qZc5jctagXxVSeUv80kQeK jeTe0gxb74xIjOYT9RHltHyNfkICajN4Xz86Y= Received: by 10.102.17.15 with SMTP id 15mr2210217muq.133.1264258267836; Sat, 23 Jan 2010 06:51:07 -0800 (PST) Received: from localhost (vpn-193-138-135-114.customer.onet.com.ua [193.138.135.114]) by mx.google.com with ESMTPS id b9sm13212343mug.9.2010.01.23.06.51.06 (version=TLSv1/SSLv3 cipher=RC4-MD5); Sat, 23 Jan 2010 06:51:06 -0800 (PST) To: Rick Macklem References: <86ocl272mb.fsf@kopusha.onet> <86tyuqnz9x.fsf@zhuzha.ua1> <86zl4awmon.fsf@zhuzha.ua1> <86vdeywmha.fsf@zhuzha.ua1> <86vdeuuo2y.fsf@zhuzha.ua1> Organization: TOA Ukraine From: Mikolaj Golub Date: Sat, 23 Jan 2010 16:51:04 +0200 In-Reply-To: (Rick Macklem's message of "Fri\, 22 Jan 2010 17\:13\:09 -0500 \(EST\)") Message-ID: <86pr50vprb.fsf@kopusha.onet> User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.3 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: freebsd-fs@FreeBSD.org, freebsd-stable@FreeBSD.org Subject: Re: FreeBSD NFS client/Linux NFS server issue X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 23 Jan 2010 14:51:09 -0000 On Fri, 22 Jan 2010 17:13:09 -0500 (EST) Rick Macklem wrote: > On Fri, 22 Jan 2010, Rick Macklem wrote: > >> >> There should probably be some sort of 3 way handshake between >> the code in nfs_asyncio() after calling nfs_nfsnewiod() and the >> code near the beginning of nfssvc_iod(), but I think the following >> somewhat cheesy fix might do the trick: >> > [stuff deleted] > I know it's a little weird to reply to my own posting, but I think > this might be a reasonable patch (I have only tested it for a few > minutes at this point). > > I basically redefined nfs_iodwant[] as a tri-state variable (although > it was a struct proc *, it was only tested NULL/non-NULL). > 0 - was NULL > 1 - was non-NULL > -1 - just created by nfs_asyncio() and will be used by it > > I'll keep testing it, but hopefully someone else can test and/or > review it... rick I applied your patch to FreeBSD8.0 (the box I get on weekend :-), mounted 10 shares, set vfs.nfs.iodmaxidle=10 (to have nfsiod creation more frequently) and have been running tests for 4 hours -- just to check the patch does not break anything. No issues have been detected. It would be very nice to have this patch committed. -- Mikolaj Golub