From owner-cvs-all@FreeBSD.ORG Tue Jan 25 11:26:17 2005 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 92D8916A4CE; Tue, 25 Jan 2005 11:26:17 +0000 (GMT) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id CE18F43D2D; Tue, 25 Jan 2005 11:26:16 +0000 (GMT) (envelope-from ache@nagual.pp.ru) Received: from nagual.pp.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.13.1/8.13.1) with ESMTP id j0PBQF8Z031258; Tue, 25 Jan 2005 14:26:15 +0300 (MSK) (envelope-from ache@nagual.pp.ru) Received: (from ache@localhost) by nagual.pp.ru (8.13.1/8.13.1/Submit) id j0PBQFU6031257; Tue, 25 Jan 2005 14:26:15 +0300 (MSK) (envelope-from ache) Date: Tue, 25 Jan 2005 14:26:14 +0300 From: Andrey Chernov To: Poul-Henning Kamp Message-ID: <20050125112614.GD29791@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , Poul-Henning Kamp , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20050125110648.GB29791@nagual.pp.ru> <81636.1106651373@critter.freebsd.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <81636.1106651373@critter.freebsd.dk> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter (version: 1.1.0-3; AVE: 6.29.0.8; VDF: 6.29.0.77; host: nagual.pp.ru) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-1.5.6 (nagual.pp.ru [0.0.0.0]); Tue, 25 Jan 2005 14:26:15 +0300 (MSK) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern sys_generic.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2005 11:26:17 -0000 On Tue, Jan 25, 2005 at 12:09:33PM +0100, Poul-Henning Kamp wrote: > >I.e. look at ERRORS section list and inspect each errno returning broken > >by preliminary zero bytes check. > > That's another check we didn't do before to the resid==0 handling before. > > Now, I'm going to killfile this subject until you come up with code which > real-life code which breaks because of this, OK ? I just show you the way of finding such cases, I already say I don't have much time to dig out real one. It is you who must prove that your addition not change anything or not violate POSIX. Because there is strong suspicion that you violates POSIX quote I already mention. I.e. look in the fo_read() chain and see which errors are skipped now. Even if you don't find such ones, it may simple mean that resid==0 check was placed preliminary in our old code, and it is old code which needs to be fixed. -- http://ache.pp.ru/