From owner-freebsd-embedded@FreeBSD.ORG  Tue Oct 15 17:04:04 2013
Return-Path: <owner-freebsd-embedded@FreeBSD.ORG>
Delivered-To: freebsd-embedded@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id BA11F6E0;
 Tue, 15 Oct 2013 17:04:04 +0000 (UTC)
 (envelope-from jmg@h2.funkthat.com)
Received: from h2.funkthat.com (gate2.funkthat.com [208.87.223.18])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mx1.freebsd.org (Postfix) with ESMTPS id 9BB262766;
 Tue, 15 Oct 2013 17:04:04 +0000 (UTC)
Received: from h2.funkthat.com (localhost [127.0.0.1])
 by h2.funkthat.com (8.14.3/8.14.3) with ESMTP id r9FH436X039104
 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
 Tue, 15 Oct 2013 10:04:04 -0700 (PDT)
 (envelope-from jmg@h2.funkthat.com)
Received: (from jmg@localhost)
 by h2.funkthat.com (8.14.3/8.14.3/Submit) id r9FH43ov039103;
 Tue, 15 Oct 2013 10:04:03 -0700 (PDT) (envelope-from jmg)
Date: Tue, 15 Oct 2013 10:04:03 -0700
From: John-Mark Gurney <jmg@funkthat.com>
To: sbruno@freebsd.org
Subject: Re: makefs(8) proposed changes [repost from fs@]
Message-ID: <20131015170403.GO56872@funkthat.com>
Mail-Followup-To: sbruno@freebsd.org, freebsd-embedded@freebsd.org
References: <1380730546.1619.47.camel@localhost>
 <1381853252.2682.0.camel@localhost>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1381853252.2682.0.camel@localhost>
User-Agent: Mutt/1.4.2.3i
X-Operating-System: FreeBSD 7.2-RELEASE i386
X-PGP-Fingerprint: 54BA 873B 6515 3F10 9E88  9322 9CB1 8F74 6D3F A396
X-Files: The truth is out there
X-URL: http://resnet.uoregon.edu/~gurney_j/
X-Resume: http://resnet.uoregon.edu/~gurney_j/resume.html
X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? can i haz chizburger?
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.2
 (h2.funkthat.com [127.0.0.1]); Tue, 15 Oct 2013 10:04:04 -0700 (PDT)
Cc: freebsd-embedded@freebsd.org
X-BeenThere: freebsd-embedded@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Dedicated and Embedded Systems <freebsd-embedded.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-embedded>, 
 <mailto:freebsd-embedded-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-embedded>
List-Post: <mailto:freebsd-embedded@freebsd.org>
List-Help: <mailto:freebsd-embedded-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-embedded>, 
 <mailto:freebsd-embedded-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Oct 2013 17:04:04 -0000

Sean Bruno wrote this message on Tue, Oct 15, 2013 at 09:07 -0700:
> Is this patch going to break non "device" makefs calls?  e.g. if I want
> to create an image file and not use a loopback device?

If the image file is zero bytes, then yes, it will break it... as the
read will return a short value (possibly zero) ...  Why not add some
error checking and if the read doesn't read enough, write the
remaining bytes?  If there is a failure from the read, the operation
should fail...

-- 
  John-Mark Gurney				Voice: +1 415 225 5579

     "All that I will do, has been done, All that I have, has not."