From owner-freebsd-ports@FreeBSD.ORG  Sat Jan 19 23:24:44 2013
Return-Path: <owner-freebsd-ports@FreeBSD.ORG>
Delivered-To: freebsd-ports@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id E6C3EDCD
 for <freebsd-ports@freebsd.org>; Sat, 19 Jan 2013 23:24:44 +0000 (UTC)
 (envelope-from nox@jelal.kn-bremen.de)
Received: from smtp.kn-bremen.de (gelbbaer.kn-bremen.de [78.46.108.116])
 by mx1.freebsd.org (Postfix) with ESMTP id 896FE3A5
 for <freebsd-ports@freebsd.org>; Sat, 19 Jan 2013 23:24:44 +0000 (UTC)
Received: by smtp.kn-bremen.de (Postfix, from userid 10)
 id 688671E000EC; Sun, 20 Jan 2013 00:24:43 +0100 (CET)
Received: from triton8.kn-bremen.de (noident@localhost [127.0.0.1])
 by triton8.kn-bremen.de (8.14.5/8.14.4) with ESMTP id r0JNNtij081273;
 Sun, 20 Jan 2013 00:23:55 +0100 (CET)
 (envelope-from nox@triton8.kn-bremen.de)
Received: (from nox@localhost)
 by triton8.kn-bremen.de (8.14.5/8.14.3/Submit) id r0JNNskP081272;
 Sun, 20 Jan 2013 00:23:54 +0100 (CET) (envelope-from nox)
From: Juergen Lock <nox@jelal.kn-bremen.de>
Date: Sun, 20 Jan 2013 00:23:54 +0100
To: =?iso-8859-1?Q?Ren=E9?= Ladan <r.c.ladan@gmail.com>
Subject: Re: CFT: building multimedia/vlc with clang on 9.1+
Message-ID: <20130119232354.GA81243@triton8.kn-bremen.de>
References: <20130119210903.GA76282@triton8.kn-bremen.de>
 <201301192253.r0JMrhsa080013@triton8.kn-bremen.de>
 <50FB2843.8070705@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <50FB2843.8070705@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Cc: Juergen Lock <nox@jelal.kn-bremen.de>, freebsd-ports@freebsd.org
X-BeenThere: freebsd-ports@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Porting software to FreeBSD <freebsd-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports>
List-Post: <mailto:freebsd-ports@freebsd.org>
List-Help: <mailto:freebsd-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports>,
 <mailto:freebsd-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 19 Jan 2013 23:24:45 -0000

On Sun, Jan 20, 2013 at 12:12:03AM +0100, René Ladan wrote:
> On 19-01-2013 23:53, Juergen Lock wrote:
> > In article <50FB156A.5010003@gmail.com> you write:
> >> On 19-01-2013 22:09, Juergen Lock wrote:
> [...]
> 
> >>
> >>> Index: Makefile
> >>> ===================================================================
> >>> RCS file: /home/pcvs/ports/multimedia/vlc/Makefile,v
> >>> retrieving revision 1.312
> >>> diff -u -p -r1.312 Makefile
> >>> --- Makefile	12 Jan 2013 20:25:57 -0000	1.312
> >>> +++ Makefile	19 Jan 2013 20:45:39 -0000
> >>> @@ -679,9 +679,16 @@ IGNORE=		base clang version too old, set
> >>>  CONFIGURE_ARGS+=--enable-altivec # VLC's config script doesn't know to do this
> >>>  .endif
> >>>  
> >>> +# prefer clang on 9.1+
> >>> +.if (${OSVERSION} >= 901000) && exists(${DESTDIR}/usr/bin/clang)
> >>
> >> Not sure if this is the proper(TM) way to detect clang.
> >>> +CC=	clang
> >>> +CXX=	clang++
> >>> +CPP=	clang-cpp
> >>> +.else
> >>>  .if ${ARCH} == "i386"
> >>>  USE_GCC?=	4.6+ # sse/3dnow detection on i386 needs newer gcc
> >>
> >> See above, if on e.g. FreeBSD 12 the /usr/bin/clang file gets removed
> >> this makes the port always use GCC 4.6+
> >>
> > Hmm do you think this would happen?  We still had /usr/bin/gcc hardlinked
> > to /usr/bin/cc the entire time we used gcc...
> > 
> Not really, but it _could_ happen.
> 
Well should that happen we can just stop setting CC since clang
will be default anyway...

	Juergen