From owner-freebsd-net@FreeBSD.ORG Mon Oct 17 13:23:55 2011 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 55F89106564A; Mon, 17 Oct 2011 13:23:55 +0000 (UTC) (envelope-from steven@pyro.eu.org) Received: from falkenstein-1.sn.de.cluster.ok24.net (maidenhead-1.wnm.uk.cluster.ok24.net [IPv6:2002:4e2f:2f89:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 0281B8FC08; Mon, 17 Oct 2011 13:23:55 +0000 (UTC) Received: from maidenhead-1.wnm.uk.cluster.ok24.net ([10.1.0.1] helo=falkenstein-1.sn.de.cluster.ok24.net) by falkenstein-1.sn.de.cluster.ok24.net with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1RFnAX-0001HI-O0; Mon, 17 Oct 2011 14:23:53 +0100 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=pyro.eu.org; s=10.2011; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:References:Subject:CC:To:MIME-Version:From:Date:Message-ID; bh=4KsPzrqEshQ3LW81+uIe0nLskU4/oZhhMsf6vK5JsQw=; b=B9i3M6bR5KY/Qjg7uqokRLWNr48pG55tgFk7EM9VOayEb1QhL8Oc87inY/yGFQFPpMnQe7IlhuOl4eZQxFe/rM0OdgoCNxcNwgK9Dl09odMFNFoSQpNlW1tuuSIxW8+vbkSldAZyCRMf+4vD7faTYFhmLR2nZRAAg8eMevCmjOA=; Received: from 188-220-33-66.zone11.bethere.co.uk ([188.220.33.66] helo=guisborough-1.rcc.uk.cluster.ok24.net) by falkenstein-1.sn.de.cluster.ok24.net with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.72) (envelope-from ) id 1RFnAX-0001HF-Jo; Mon, 17 Oct 2011 14:23:53 +0100 X-Spam-Status: No, score=-4.4 required=2.0 tests=ALL_TRUSTED, AWL, BAYES_00, DKIM_POLICY_SIGNALL Received: from [192.168.0.110] (helo=[192.168.0.9]) by guisborough-1.rcc.uk.cluster.ok24.net with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1RFnAS-0004IJ-GF; Mon, 17 Oct 2011 14:23:52 +0100 Message-ID: <4E9C2C64.5030007@pyro.eu.org> Date: Mon, 17 Oct 2011 14:23:48 +0100 From: Steven Chamberlain User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20111006 Icedove/3.0.11 MIME-Version: 1.0 To: Adrian Chadd References: <201110152200.p9FM0QUO044812@freefall.freebsd.org> <4E9A5FB6.7040904@pyro.eu.org> <4E9B062A.9050408@pyro.eu.org> <4E9B315A.6030607@pyro.eu.org> In-Reply-To: X-Enigmail-Version: 1.0.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-net@freebsd.org Subject: Re: kern/149643: [rum] device not sending proper beacon frames in ap mode X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Oct 2011 13:23:55 -0000 On 17/10/11 14:13, Adrian Chadd wrote: > I've committed this to -HEAD in r226465. > I'll MFC this to -9 and -8 in the next 3 or so days, re@ approval pending. Argh... there were a couple of issues someone pointed out to me off-list that you may not have seen: On 17/10/11 01:16, Gang 'Henry' Hu wrote: > There are some minor problems: > > + error = rum_do_request(sc, &req, buf + offset); > > At this line, you should cast buf to (char*), since buf is (void*) > which cannot be used in calculation... > > And you should also return 0 at the end of the function, else there > would be no return value.... I was going to get back to you with a slightly revised freebsd patch to fix those before you committed. Otherwise, Henry said it has fixed the problem for him (in 8.2-STABLE). Regards, -- Steven Chamberlain steven@pyro.eu.org