From owner-freebsd-geom@FreeBSD.ORG Mon Jun 20 11:07:02 2011 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 1B01B10656E2 for ; Mon, 20 Jun 2011 11:07:02 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 0A1A28FC2C for ; Mon, 20 Jun 2011 11:07:02 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5KB713J098113 for ; Mon, 20 Jun 2011 11:07:01 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5KB7162098111 for freebsd-geom@FreeBSD.org; Mon, 20 Jun 2011 11:07:01 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 20 Jun 2011 11:07:01 GMT Message-Id: <201106201107.p5KB7162098111@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-geom@FreeBSD.org Cc: Subject: Current problem reports assigned to freebsd-geom@FreeBSD.org X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2011 11:07:02 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o kern/157879 geom [libgeom] ABI change without version bump in 8.2 o kern/157863 geom [geli] kbdmux prevents geli passwords from being enter o kern/157819 geom [geom] gpart(8): drop serial from MBR o kern/157739 geom [geom] GPT labels with geom_multipath o kern/157724 geom [geom] gpart(8) 'add' command must preserve gap for sc o kern/157723 geom [geom] GEOM should not process 'c' (raw) partitions fo o kern/157108 geom [gjournal] dumpon(8) fails on gjournal providers o kern/155994 geom [geom] Long "Suspend time" when reading large files fr o kern/154226 geom [geom] GEOM label does not change when you modify them o kern/150858 geom [geom] [geom_label] [patch] glabel(8) is not compatibl o kern/150626 geom [geom] [gjournal] gjournal(8) destroys label o kern/150555 geom [geom] gjournal unusable on GPT partitions o kern/150334 geom [geom] [udf] [patch] geom label does not support UDF o kern/149762 geom volume labels with rogue characters o bin/149215 geom [panic] [geom_part] gpart(8): Delete linux's slice via o kern/147667 geom [gmirror] Booting with one component of a gmirror, the o kern/145818 geom [geom] geom_stat_open showing cached information for n o kern/145042 geom [geom] System stops booting after printing message "GE o kern/144905 geom [geom][geom_part] panic in gpart_ctlreq when unpluggin o kern/143455 geom gstripe(8) in RELENG_8 (31st Jan 2010) broken o kern/142563 geom [geom] [hang] ioctl freeze in zpool o kern/141740 geom [geom] gjournal(8): g_journal_destroy concurrent error o kern/140352 geom [geom] gjournal + glabel not working o kern/135898 geom [geom] Severe filesystem corruption - large files or l o kern/134922 geom [gmirror] [panic] kernel panic when use fdisk on disk o kern/134113 geom [geli] Problem setting secondary GELI key o kern/133931 geom [geli] [request] intentionally wrong password to destr o bin/132845 geom [geom] [patch] ggated(8) does not close files opened a o kern/131353 geom [geom] gjournal(8) kernel lock o kern/129674 geom [geom] gjournal root did not mount on boot o kern/129645 geom gjournal(8): GEOM_JOURNAL causes system to fail to boo o kern/129245 geom [geom] gcache is more suitable for suffix based provid f kern/128276 geom [gmirror] machine lock up when gmirror module is used o kern/127420 geom [geom] [gjournal] [panic] Journal overflow on gmirrore o kern/124973 geom [gjournal] [patch] boot order affects geom_journal con o kern/124969 geom gvinum(8): gvinum raid5 plex does not detect missing s o kern/123962 geom [panic] [gjournal] gjournal (455Gb data, 8Gb journal), o kern/123122 geom [geom] GEOM / gjournal kernel lock o kern/122738 geom [geom] gmirror list "losts consumers" after gmirror de o kern/122067 geom [geom] [panic] Geom crashed during boot o kern/121364 geom [gmirror] Removing all providers create a "zombie" mir o kern/120091 geom [geom] [geli] [gjournal] geli does not prompt for pass o kern/115856 geom [geli] ZFS thought it was degraded when it should have o kern/115547 geom [geom] [patch] [request] let GEOM Eli get password fro o kern/114532 geom [geom] GEOM_MIRROR shows up in kldstat even if compile f kern/113957 geom [gmirror] gmirror is intermittently reporting a degrad o kern/113837 geom [geom] unable to access 1024 sector size storage o kern/113419 geom [geom] geom fox multipathing not failing back o kern/107707 geom [geom] [patch] [request] add new class geom_xbox360 to o kern/94632 geom [geom] Kernel output resets input while GELI asks for o kern/90582 geom [geom] [panic] Restore cause panic string (ffs_blkfree o bin/90093 geom fdisk(8) incapable of altering in-core geometry o kern/87544 geom [gbde] mmaping large files on a gbde filesystem deadlo o bin/86388 geom [geom] [geom_part] periodic(8) daily should backup gpa o kern/84556 geom [geom] [panic] GBDE-encrypted swap causes panic at shu o kern/79251 geom [2TB] newfs fails on 2.6TB gbde device o kern/79035 geom [vinum] gvinum unable to create a striped set of mirro o bin/78131 geom gbde(8) "destroy" not working. 58 problems total. From owner-freebsd-geom@FreeBSD.ORG Mon Jun 20 18:00:09 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D9B3A106566C for ; Mon, 20 Jun 2011 18:00:09 +0000 (UTC) (envelope-from kris@pcbsd.org) Received: from mail.iXsystems.com (newknight.ixsystems.com [206.40.55.70]) by mx1.freebsd.org (Postfix) with ESMTP id A18828FC18 for ; Mon, 20 Jun 2011 18:00:09 +0000 (UTC) Received: from mail.ixsystems.com (localhost [127.0.0.1]) by mail.iXsystems.com (Postfix) with ESMTP id 07C6EA66428 for ; Mon, 20 Jun 2011 10:40:35 -0700 (PDT) Received: from mail.iXsystems.com ([127.0.0.1]) by mail.ixsystems.com (mail.ixsystems.com [127.0.0.1]) (amavisd-maia, port 10024) with ESMTP id 75699-07 for ; Mon, 20 Jun 2011 10:40:34 -0700 (PDT) Received: from [192.168.0.186] (75-130-56-30.static.kgpt.tn.charter.com [75.130.56.30]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.iXsystems.com (Postfix) with ESMTPSA id 97F02A66403 for ; Mon, 20 Jun 2011 10:40:34 -0700 (PDT) Message-ID: <4DFF8611.4090705@pcbsd.org> Date: Mon, 20 Jun 2011 13:40:33 -0400 From: Kris Moore User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110430 Thunderbird/3.1.10 MIME-Version: 1.0 To: freebsd-geom@FreeBSD.ORG Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Subject: gpart sizes way off X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2011 18:00:10 -0000 Not sure if this has been reported, apologies if I'm late to noticing this. I'm not sure if something has changed in the past few weeks on CURRENT to cause this, or if we are just noticing it for the first time, but when doing installs and using "gpart add" for creating partitions on a 2nd MBR slice, the sizes we are giving it are WAY off what actually is allocated. For example: # gpart add -s 2048M -t freebsd-ufs -i 1 /dev/ada0s2 ada0s2a added # gpart add -s 1534M -t freebsd-swap -i 2 /dev/ada0s2 ada0s2b added # gpart add -s 2048M -t freebsd-ufs -i 4 /dev/ada0s2 ada0s2d added # gpart add -s 97165M -t freebsd-ufs -i 5 /dev/ada0s2 gpart: autofill: No space left on device There *should* be enough space for the last partition, but take a look what actually happened on disk: # gpart show ada0s2 => 0 210534400 ada0s2 BSD (100G) 0 5933056 1 freebsd-ufs (2.8G) 5933056 4880384 2 freebsd-swap (2.3G) 10813440 5933056 4 freebsd-ufs (2.8G) 16746496 193787904 - free - (92G) I'm unsure why 2048M is getting bumped up to 2.8G, same with 1534M -> 2.3G, but of course that explains why the last partition is failing. Here's the output of "gpart show ada0" for kicks: => 63 419430337 ada0 MBR (200G) 63 1985 - free - (992k) 2048 102400000 1 linux-data (48G) 102402048 210534400 2 freebsd (100G) 312936448 106493952 3 linux-data (50G) -- Kris Moore PC-BSD Software iXsystems From owner-freebsd-geom@FreeBSD.ORG Mon Jun 20 18:13:40 2011 Return-Path: Delivered-To: freebsd-geom@FreeBSD.ORG Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id B98D4106566B for ; Mon, 20 Jun 2011 18:13:40 +0000 (UTC) (envelope-from ae@FreeBSD.org) Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 9E12020467C; Mon, 20 Jun 2011 18:13:39 +0000 (UTC) Message-ID: <4DFF8DC6.1010701@FreeBSD.org> Date: Mon, 20 Jun 2011 22:13:26 +0400 From: "Andrey V. Elsukov" User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110429 Thunderbird/3.1.10 MIME-Version: 1.0 To: Kris Moore References: <4DFF8611.4090705@pcbsd.org> In-Reply-To: <4DFF8611.4090705@pcbsd.org> X-Enigmail-Version: 1.1.2 OpenPGP: id=10C8A17A Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig59E1DCC9EACBA738AB4530A1" Cc: freebsd-geom@FreeBSD.ORG Subject: Re: gpart sizes way off X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2011 18:13:40 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig59E1DCC9EACBA738AB4530A1 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable On 20.06.2011 21:40, Kris Moore wrote: >=20 > Not sure if this has been reported, apologies if I'm late to noticing t= his. >=20 > I'm not sure if something has changed in the past few weeks on CURRENT > to cause this, or if we are just noticing it for the first time, but > when doing installs and using "gpart add" for creating partitions on a > 2nd MBR slice, the sizes we are giving it are WAY off what actually is > allocated. For example: >=20 > # gpart add -s 2048M -t freebsd-ufs -i 1 /dev/ada0s2 > ada0s2a added > # gpart add -s 1534M -t freebsd-swap -i 2 /dev/ada0s2 > ada0s2b added > # gpart add -s 2048M -t freebsd-ufs -i 4 /dev/ada0s2 > ada0s2d added > # gpart add -s 97165M -t freebsd-ufs -i 5 /dev/ada0s2 > gpart: autofill: No space left on device Which revision do you use? Also, please, show the output of `gpart list` and `geom disk list`. --=20 WBR, Andrey V. Elsukov --------------enig59E1DCC9EACBA738AB4530A1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBAgAGBQJN/43KAAoJEAHF6gQQyKF6X1QH/1m0/xdo5cUlMjFj7/UGkSOm EML9ViO8dvBiOJD84cCaED9vZUievYZW4T/ZpCoi9h0IwZzAF4RM7SF28lI0RpxP N0ANF+xSXnis1V2uD4OvwRbIXTiic1qnTEmMwq3DtV4hX5uDb6KcQS3LXSv0XfG9 vXWUZpp4XuIqJPskCSzAviyfS+7zLh1EOGG6OeIaUtJBzdjDRen8STIRyLBNNh/J LY9LZ1HjPW0s8nP7Ds9x1vd315xoKJwswLoiKQhJMZFl9dbTkNJQaKyofcms/yZZ 35jpZmeLp5nUXCmInYpeaSVsl0Xz2f9UGePX+PSjT4tvIAvcEjcD9GK9LtVQvn4= =8bQ7 -----END PGP SIGNATURE----- --------------enig59E1DCC9EACBA738AB4530A1-- From owner-freebsd-geom@FreeBSD.ORG Mon Jun 20 18:56:37 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6490A1065672 for ; Mon, 20 Jun 2011 18:56:37 +0000 (UTC) (envelope-from kris@pcbsd.org) Received: from mail.iXsystems.com (newknight.ixsystems.com [206.40.55.70]) by mx1.freebsd.org (Postfix) with ESMTP id EC6E28FC1A for ; Mon, 20 Jun 2011 18:56:36 +0000 (UTC) Received: from mail.ixsystems.com (localhost [127.0.0.1]) by mail.iXsystems.com (Postfix) with ESMTP id D23FAA6642C; Mon, 20 Jun 2011 11:56:35 -0700 (PDT) Received: from mail.iXsystems.com ([127.0.0.1]) by mail.ixsystems.com (mail.ixsystems.com [127.0.0.1]) (amavisd-maia, port 10024) with ESMTP id 78344-05; Mon, 20 Jun 2011 11:56:35 -0700 (PDT) Received: from [192.168.0.186] (75-130-56-30.static.kgpt.tn.charter.com [75.130.56.30]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.iXsystems.com (Postfix) with ESMTPSA id 919EDA66413; Mon, 20 Jun 2011 11:56:34 -0700 (PDT) Message-ID: <4DFF97DF.5040408@pcbsd.org> Date: Mon, 20 Jun 2011 14:56:31 -0400 From: Kris Moore User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110430 Thunderbird/3.1.10 MIME-Version: 1.0 To: "Andrey V. Elsukov" References: <4DFF8611.4090705@pcbsd.org> <4DFF8DC6.1010701@FreeBSD.org> In-Reply-To: <4DFF8DC6.1010701@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-geom@FreeBSD.ORG Subject: Re: gpart sizes way off X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2011 18:56:37 -0000 On 06/20/2011 14:13, Andrey V. Elsukov wrote: > On 20.06.2011 21:40, Kris Moore wrote: >> Not sure if this has been reported, apologies if I'm late to noticing this. >> >> I'm not sure if something has changed in the past few weeks on CURRENT >> to cause this, or if we are just noticing it for the first time, but >> when doing installs and using "gpart add" for creating partitions on a >> 2nd MBR slice, the sizes we are giving it are WAY off what actually is >> allocated. For example: >> >> # gpart add -s 2048M -t freebsd-ufs -i 1 /dev/ada0s2 >> ada0s2a added >> # gpart add -s 1534M -t freebsd-swap -i 2 /dev/ada0s2 >> ada0s2b added >> # gpart add -s 2048M -t freebsd-ufs -i 4 /dev/ada0s2 >> ada0s2d added >> # gpart add -s 97165M -t freebsd-ufs -i 5 /dev/ada0s2 >> gpart: autofill: No space left on device > Which revision do you use? This is current from last Friday the 17th. > Also, please, show the output of `gpart list` and `geom disk list`. > Here you go! # gpart list Geom name: ada0 modified: false state: OK fwheads: 255 fwsectors: 63 last: 419430399 first: 63 entries: 4 scheme: MBR Providers: 1. Name: ada0s1 Mediasize: 52428800000 (48G) Sectorsize: 512 Stripesize: 0 Stripeoffset: 1048576 Mode: r0w0e0 rawtype: 131 length: 52428800000 offset: 1048576 type: linux-data index: 1 end: 102402047 start: 2048 2. Name: ada0s2 Mediasize: 107793612800 (100G) Sectorsize: 512 Stripesize: 0 Stripeoffset: 890241024 Mode: r0w0e0 rawtype: 165 length: 107793612800 offset: 52429848576 type: freebsd index: 2 end: 312936447 start: 102402048 3. Name: ada0s3 Mediasize: 54524903424 (50G) Sectorsize: 512 Stripesize: 0 Stripeoffset: 1309671424 Mode: r0w0e0 rawtype: 131 length: 54524903424 offset: 160223461376 type: linux-data index: 3 end: 419430399 start: 312936448 Consumers: 1. Name: ada0 Mediasize: 214748364800 (200G) Sectorsize: 512 Mode: r0w0e0 Geom name: ada0s2 modified: false state: OK fwheads: 255 fwsectors: 63 last: 210534399 first: 0 entries: 8 scheme: BSD Providers: 1. Name: ada0s2a Mediasize: 3037724672 (2.8G) Sectorsize: 512 Stripesize: 0 Stripeoffset: 890241024 Mode: r0w0e0 rawtype: 7 length: 3037724672 offset: 0 type: freebsd-ufs index: 1 end: 5933055 start: 0 2. Name: ada0s2b Mediasize: 2498756608 (2.3G) Sectorsize: 512 Stripesize: 0 Stripeoffset: 3927965696 Mode: r0w0e0 rawtype: 1 length: 2498756608 offset: 3037724672 type: freebsd-swap index: 2 end: 10813439 start: 5933056 3. Name: ada0s2d Mediasize: 3037724672 (2.8G) Sectorsize: 512 Stripesize: 0 Stripeoffset: 2131755008 Mode: r0w0e0 rawtype: 7 length: 3037724672 offset: 5536481280 type: freebsd-ufs index: 4 end: 16746495 start: 10813440 Consumers: 1. Name: ada0s2 Mediasize: 107793612800 (100G) Sectorsize: 512 Stripesize: 0 Stripeoffset: 890241024 Mode: r0w0e0 # geom disk list Geom name: cd0 Providers: 1. Name: cd0 Mediasize: 729233408 (695M) Sectorsize: 2048 Mode: r0w0e0 descr: VBOX CD-ROM ident: (null) fwsectors: 0 fwheads: 0 Geom name: ada0 Providers: 1. Name: ada0 Mediasize: 214748364800 (200G) Sectorsize: 512 Mode: r0w0e0 descr: VBOX HARDDISK ident: (null) fwsectors: 63 fwheads: 16 -- Kris Moore PC-BSD Software iXsystems From owner-freebsd-geom@FreeBSD.ORG Mon Jun 20 19:36:49 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5930D10656A7; Mon, 20 Jun 2011 19:36:49 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 01CC18FC1A; Mon, 20 Jun 2011 19:36:49 +0000 (UTC) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 63093E873; Mon, 20 Jun 2011 12:36:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1308598608; bh=tCQlZ5XLlJJ9LRwCNMvVm8MFkc7aq5X8HlTyH1ghpS8=; h=Message-ID:Date:From:Reply-To:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type; b=o9FiBeezx3iP9opjy/x8vyiJiPxGIsjQd/VDxpycXjfK6uYg1WzTRhZp5arhrJlzY FFsXSYHop+NpGfCKZpoZWNZxvWYkBQ/Lb3kGzzeYyhKUgE7pbt7vUBH4zckQvQeDXq SP8Z/3jNNqKOT4Np0AOJ108Vad8vHeGoMrUaJWZI= Message-ID: <4DFFA14F.4030402@delphij.net> Date: Mon, 20 Jun 2011 12:36:47 -0700 From: Xin LI Organization: The FreeBSD Project MIME-Version: 1.0 To: freebsd-geom@freebsd.org References: <4DFF8611.4090705@pcbsd.org> <4DFF8DC6.1010701@FreeBSD.org> In-Reply-To: <4DFF8DC6.1010701@FreeBSD.org> OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: multipart/mixed; boundary="------------080804050103030201080009" Cc: Alexander Motin Subject: Re: gpart sizes way off X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2011 19:36:49 -0000 This is a multi-part message in MIME format. --------------080804050103030201080009 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 06/20/11 11:13, Andrey V. Elsukov wrote: > On 20.06.2011 21:40, Kris Moore wrote: >> >> Not sure if this has been reported, apologies if I'm late to noticing this. >> >> I'm not sure if something has changed in the past few weeks on CURRENT >> to cause this, or if we are just noticing it for the first time, but >> when doing installs and using "gpart add" for creating partitions on a >> 2nd MBR slice, the sizes we are giving it are WAY off what actually is >> allocated. For example: >> >> # gpart add -s 2048M -t freebsd-ufs -i 1 /dev/ada0s2 >> ada0s2a added >> # gpart add -s 1534M -t freebsd-swap -i 2 /dev/ada0s2 >> ada0s2b added >> # gpart add -s 2048M -t freebsd-ufs -i 4 /dev/ada0s2 >> ada0s2d added >> # gpart add -s 97165M -t freebsd-ufs -i 5 /dev/ada0s2 >> gpart: autofill: No space left on device > > Which revision do you use? > Also, please, show the output of `gpart list` and `geom disk list`. I can reproduce the problem on -CURRENT however the cause seems to be a weird one. Attached is a (workaround?) for this issue. The revision 201645 seems to have exposed this problem -- when there is no stripesize, the part class exposes the absolute offset when stripesize == 0, while what gpart really want to do is to align against a stripe, where the stripesize is not really meaningful here. Alexander, would you please help to review my patch? ==================== r201645 | mav | 2010-01-06 05:14:37 -0800 (Wed, 06 Jan 2010) | 8 lines Change the way in which zero stripesize is handled. Instead of reporting zero stripeoffset in such case (as if device has no stripes), report offset from the beginning of the media (as if device has single infinite stripe). This gives partitioning tools information, required to guess better partition alignment, in case if hardware doesn't report it's stripe size. For example, it should give disklabel info about odd offset made by fdisk. Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBCAAGBQJN/6FOAAoJEATO+BI/yjfB20IIALN45Q9j7B2nlLrf4n4VdKVe lgYelj6aBr8GrFFmCPrVAZ7MLlk4U9+fGziVba4g7SrFPZLZrX4QmCUo1xk3xWk4 8/0arxj0QavqcdOEgFc1iJ4fItCszaV1itRwqvQyQTHymuionyc9BqPU+Fo/ALMK TdeZbKWVRlg/5fadVuW0cjsX48SgNY+gZlM3pvtSrHGWTxKhq3a0es6cgEg9i81I d7sCpXSskL5jk980IzA0rgiE5uNpMqw3520cJl0PO2HcwC2UkU6I5WM6Mmdwx7An 1jSyzKm+qA5eCnIBRAWQkhsZGB9jd3AmcvyWoPxkB/H/hqAhHYh00vn8Uy4QYio= =uwO2 -----END PGP SIGNATURE----- --------------080804050103030201080009 Content-Type: text/plain; name="gpart.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="gpart.diff" Index: sbin/geom/class/part/geom_part.c =================================================================== --- sbin/geom/class/part/geom_part.c (revision 223344) +++ sbin/geom/class/part/geom_part.c (working copy) @@ -363,6 +363,8 @@ } offset = pp->lg_stripeoffset / pp->lg_sectorsize; + if (pp->lg_stripesize == 0) + offset = 0; last = (off_t)strtoimax(find_geomcfg(gp, "last"), NULL, 0); LIST_FOREACH(pp, &gp->lg_provider, lg_provider) { s = find_provcfg(pp, "index"); @@ -498,6 +500,8 @@ /* Adjust parameters to stripeoffset */ offset = pp->lg_stripeoffset / pp->lg_sectorsize; + if (pp->lg_stripesize == 0) + offset = 0; start = ALIGNUP(start + offset, alignment); if (size + offset > alignment) size = ALIGNDOWN(size + offset, alignment); --------------080804050103030201080009-- From owner-freebsd-geom@FreeBSD.ORG Mon Jun 20 19:59:03 2011 Return-Path: Delivered-To: freebsd-geom@FreeBSD.ORG Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 075DA1065673 for ; Mon, 20 Jun 2011 19:59:03 +0000 (UTC) (envelope-from ae@FreeBSD.org) Received: from [127.0.0.1] (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 5578F14DB17; Mon, 20 Jun 2011 19:59:02 +0000 (UTC) Message-ID: <4DFFA67D.2010305@FreeBSD.org> Date: Mon, 20 Jun 2011 23:58:53 +0400 From: "Andrey V. Elsukov" User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110429 Thunderbird/3.1.10 MIME-Version: 1.0 To: Kris Moore References: <4DFF8611.4090705@pcbsd.org> <4DFF8DC6.1010701@FreeBSD.org> <4DFF97DF.5040408@pcbsd.org> In-Reply-To: <4DFF97DF.5040408@pcbsd.org> X-Enigmail-Version: 1.1.2 OpenPGP: id=10C8A17A Content-Type: multipart/mixed; boundary="------------040408000900090507080007" Cc: freebsd-geom@FreeBSD.ORG Subject: Re: gpart sizes way off X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2011 19:59:03 -0000 This is a multi-part message in MIME format. --------------040408000900090507080007 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit On 20.06.2011 22:56, Kris Moore wrote: > Here you go! > # gpart list Hi, thank you for the report. It's my fail. Can you test attached patch? -- WBR, Andrey V. Elsukov --------------040408000900090507080007 Content-Type: text/plain; name="gpart.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="gpart.diff" Index: head/sbin/geom/class/part/geom_part.c =================================================================== --- head/sbin/geom/class/part/geom_part.c (revision 223335) +++ head/sbin/geom/class/part/geom_part.c (working copy) @@ -500,7 +500,7 @@ gpart_autofill(struct gctl_req *req) offset = pp->lg_stripeoffset / pp->lg_sectorsize; start = ALIGNUP(start + offset, alignment); if (size + offset > alignment) - size = ALIGNDOWN(size + offset, alignment); + size = ALIGNDOWN(size + offset, alignment) - offset; first = (off_t)strtoimax(find_geomcfg(gp, "first"), NULL, 0); last = (off_t)strtoimax(find_geomcfg(gp, "last"), NULL, 0); --------------040408000900090507080007-- From owner-freebsd-geom@FreeBSD.ORG Mon Jun 20 21:19:04 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 313241065673 for ; Mon, 20 Jun 2011 21:19:04 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id ACB668FC23 for ; Mon, 20 Jun 2011 21:19:03 +0000 (UTC) Received: by fxm11 with SMTP id 11so2575747fxm.13 for ; Mon, 20 Jun 2011 14:19:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=+hpL0OUHxIboa5Mj73eHfisDuRpuWT6rXJPcb4SO2ss=; b=Fdc/DSv3QMZzqguY+aVVyKxSehB9KJBiqpFFA6xnzKYNuWsNVpvemF1jxw+G+raSDM V5kXm0Yxe3XO9telGfKhh3BHOdfXFokLcvx9IyN++DGGs+onBSj1WVNNH6VREbmj9+xG pTVfzV1WPjiSPgkPzD/VW/1tBQwynmxfy3TPw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=Ht1G013Mp8IVIBU7INYVkY88dbNwLSOl1XQy/AxbFUasxpvctwVlQ5eDIUR69g89HU 8bCWHTMoLyapYRc9CaT7/gRgwdBq8lZ50S5XdJh/wSdJrCoG/FhoOwlxhS9BZOxt+W4T Jn9D9KZ47bQPMhavXA0iSKXnAILc7ELTCMwA8= Received: by 10.223.98.5 with SMTP id o5mr1388597fan.33.1308602596118; Mon, 20 Jun 2011 13:43:16 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id l26sm3018512fah.14.2011.06.20.13.43.13 (version=SSLv3 cipher=OTHER); Mon, 20 Jun 2011 13:43:14 -0700 (PDT) Sender: Alexander Motin Message-ID: <4DFFB0DD.5070701@FreeBSD.org> Date: Mon, 20 Jun 2011 23:43:09 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110616 Thunderbird/3.1.10 MIME-Version: 1.0 To: d@delphij.net References: <4DFF8611.4090705@pcbsd.org> <4DFF8DC6.1010701@FreeBSD.org> <4DFFA14F.4030402@delphij.net> In-Reply-To: <4DFFA14F.4030402@delphij.net> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit Cc: "Andrey V. Elsukov" , Xin LI , freebsd-geom@freebsd.org Subject: Re: gpart sizes way off X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2011 21:19:04 -0000 On 20.06.2011 22:36, Xin LI wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On 06/20/11 11:13, Andrey V. Elsukov wrote: >> On 20.06.2011 21:40, Kris Moore wrote: >>> >>> Not sure if this has been reported, apologies if I'm late to noticing this. >>> >>> I'm not sure if something has changed in the past few weeks on CURRENT >>> to cause this, or if we are just noticing it for the first time, but >>> when doing installs and using "gpart add" for creating partitions on a >>> 2nd MBR slice, the sizes we are giving it are WAY off what actually is >>> allocated. For example: >>> >>> # gpart add -s 2048M -t freebsd-ufs -i 1 /dev/ada0s2 >>> ada0s2a added >>> # gpart add -s 1534M -t freebsd-swap -i 2 /dev/ada0s2 >>> ada0s2b added >>> # gpart add -s 2048M -t freebsd-ufs -i 4 /dev/ada0s2 >>> ada0s2d added >>> # gpart add -s 97165M -t freebsd-ufs -i 5 /dev/ada0s2 >>> gpart: autofill: No space left on device >> >> Which revision do you use? >> Also, please, show the output of `gpart list` and `geom disk list`. > > I can reproduce the problem on -CURRENT however the cause seems to be a > weird one. > > Attached is a (workaround?) for this issue. > > The revision 201645 seems to have exposed this problem -- when there is > no stripesize, the part class exposes the absolute offset when > stripesize == 0, while what gpart really want to do is to align against > a stripe, where the stripesize is not really meaningful here. > > Alexander, would you please help to review my patch? I think it is also not good. It will ignore useful absolute offset in case if user specified wanted alignment on command line. Proper fix I think would be in adding there: offset %= alignment; -- Alexander Motin From owner-freebsd-geom@FreeBSD.ORG Mon Jun 20 21:34:01 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D6DB11065674; Mon, 20 Jun 2011 21:34:01 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id BBB458FC18; Mon, 20 Jun 2011 21:34:01 +0000 (UTC) Received: from delta.delphij.net (drawbridge.ixsystems.com [206.40.55.65]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 7E94DEDB2; Mon, 20 Jun 2011 14:34:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1308605641; bh=QG30Hc6q6SD8AVZAEBL6e76i5wWsKuLsYA9yfqChJws=; h=Message-ID:Date:From:Reply-To:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=KdimiT8RcC5oHINp7Ps9VvECLCy4Ptyvewp43FbU+HYZdvBvNwDTJl5pPu2o34UEk lq2wpcZTsbbq+zYYjpbJGbDcHF8iR7MO3ObtFdR1t8FNM7E1Waoya37FaH+d2ROW+J padSKvycXzKZD7/86vwlbMvhrC5Dh1pk9jlBgpSk= Message-ID: <4DFFBCC8.5090005@delphij.net> Date: Mon, 20 Jun 2011 14:34:00 -0700 From: Xin LI Organization: The FreeBSD Project MIME-Version: 1.0 To: Alexander Motin References: <4DFF8611.4090705@pcbsd.org> <4DFF8DC6.1010701@FreeBSD.org> <4DFFA14F.4030402@delphij.net> <4DFFB0DD.5070701@FreeBSD.org> In-Reply-To: <4DFFB0DD.5070701@FreeBSD.org> OpenPGP: id=3FCA37C1; url=http://www.delphij.net/delphij.asc Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Cc: "Andrey V. Elsukov" , d@delphij.net, freebsd-geom@freebsd.org Subject: Re: gpart sizes way off X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: d@delphij.net List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Jun 2011 21:34:02 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 06/20/11 13:43, Alexander Motin wrote: > On 20.06.2011 22:36, Xin LI wrote: >> -----BEGIN PGP SIGNED MESSAGE----- >> Hash: SHA256 >> >> On 06/20/11 11:13, Andrey V. Elsukov wrote: >>> On 20.06.2011 21:40, Kris Moore wrote: >>>> >>>> Not sure if this has been reported, apologies if I'm late to >>>> noticing this. >>>> >>>> I'm not sure if something has changed in the past few weeks on CURRENT >>>> to cause this, or if we are just noticing it for the first time, but >>>> when doing installs and using "gpart add" for creating partitions on a >>>> 2nd MBR slice, the sizes we are giving it are WAY off what actually is >>>> allocated. For example: >>>> >>>> # gpart add -s 2048M -t freebsd-ufs -i 1 /dev/ada0s2 >>>> ada0s2a added >>>> # gpart add -s 1534M -t freebsd-swap -i 2 /dev/ada0s2 >>>> ada0s2b added >>>> # gpart add -s 2048M -t freebsd-ufs -i 4 /dev/ada0s2 >>>> ada0s2d added >>>> # gpart add -s 97165M -t freebsd-ufs -i 5 /dev/ada0s2 >>>> gpart: autofill: No space left on device >>> >>> Which revision do you use? >>> Also, please, show the output of `gpart list` and `geom disk list`. >> >> I can reproduce the problem on -CURRENT however the cause seems to be a >> weird one. >> >> Attached is a (workaround?) for this issue. >> >> The revision 201645 seems to have exposed this problem -- when there is >> no stripesize, the part class exposes the absolute offset when >> stripesize == 0, while what gpart really want to do is to align against >> a stripe, where the stripesize is not really meaningful here. >> >> Alexander, would you please help to review my patch? > > I think it is also not good. It will ignore useful absolute offset in > case if user specified wanted alignment on command line. Proper fix I > think would be in adding there: > offset %= alignment; Like: =================================================================== - --- sbin/geom/class/part/geom_part.c (revision 223344) +++ sbin/geom/class/part/geom_part.c (working copy) @@ -362,7 +362,7 @@ goto done; } - - offset = pp->lg_stripeoffset / pp->lg_sectorsize; + offset = (pp->lg_stripeoffset / pp->lg_sectorsize) % alignment; last = (off_t)strtoimax(find_geomcfg(gp, "last"), NULL, 0); LIST_FOREACH(pp, &gp->lg_provider, lg_provider) { s = find_provcfg(pp, "index"); @@ -497,7 +497,7 @@ alignment = len; /* Adjust parameters to stripeoffset */ - - offset = pp->lg_stripeoffset / pp->lg_sectorsize; + offset = (pp->lg_stripeoffset / pp->lg_sectorsize) % alignment; start = ALIGNUP(start + offset, alignment); if (size + offset > alignment) size = ALIGNDOWN(size + offset, alignment); ? Cheers, - -- Xin LI https://www.delphij.net/ FreeBSD - The Power to Serve! Live free or die -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (FreeBSD) iQEcBAEBCAAGBQJN/7zIAAoJEATO+BI/yjfBoCoH/iUIno+qBi0RougSPj0aa1cd HbkdsbYy3FCjgPm2QD6JYLriZaJOAwfrtliG7mNzTkX8J4uCRwxCs6bTOcDYhUs8 y8ym1MInAdRcOKrsW+0sP9J3B7bnNePHYYtqDfmryEIxKc3Lh0xCiKPHiD3E8dUm oyJMG+kutbxJJUkbYWGmLvrSdv7hF/cFa7DWgD9PBfbO1H2pRnq+KsV959XoBYBV mYSDiI9zqLeHe9ClELc9UPV1wkMl0RbwkvSzpA1GHj/bTjA2KchiYUC0U1E18LHh nTEvQdw5s6paAB5lVcf+/K9AdnVWTjqucglFV2w6LLRx4nl3b+Otu89oyEa9oc8= =FtAq -----END PGP SIGNATURE----- From owner-freebsd-geom@FreeBSD.ORG Tue Jun 21 13:30:40 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 142C5106566B for ; Tue, 21 Jun 2011 13:30:40 +0000 (UTC) (envelope-from kris@pcbsd.org) Received: from mail.iXsystems.com (newknight.ixsystems.com [206.40.55.70]) by mx1.freebsd.org (Postfix) with ESMTP id E98B78FC15 for ; Tue, 21 Jun 2011 13:30:39 +0000 (UTC) Received: from mail.ixsystems.com (localhost [127.0.0.1]) by mail.iXsystems.com (Postfix) with ESMTP id B497BA6647D for ; Tue, 21 Jun 2011 06:30:39 -0700 (PDT) Received: from mail.iXsystems.com ([127.0.0.1]) by mail.ixsystems.com (mail.ixsystems.com [127.0.0.1]) (amavisd-maia, port 10024) with ESMTP id 02536-10 for ; Tue, 21 Jun 2011 06:30:39 -0700 (PDT) Received: from [192.168.0.186] (75-130-56-30.static.kgpt.tn.charter.com [75.130.56.30]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mail.iXsystems.com (Postfix) with ESMTPSA id 62DEEA6647B for ; Tue, 21 Jun 2011 06:30:39 -0700 (PDT) Message-ID: <4E009CFE.2070006@pcbsd.org> Date: Tue, 21 Jun 2011 09:30:38 -0400 From: Kris Moore User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110430 Thunderbird/3.1.10 MIME-Version: 1.0 To: freebsd-geom@freebsd.org References: <4DFF8611.4090705@pcbsd.org> <4DFF8DC6.1010701@FreeBSD.org> <4DFF97DF.5040408@pcbsd.org> <4DFFA67D.2010305@FreeBSD.org> In-Reply-To: <4DFFA67D.2010305@FreeBSD.org> Content-Type: text/plain; charset=KOI8-R; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.5 Subject: Re: gpart sizes way off X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2011 13:30:40 -0000 On 06/20/2011 15:58, Andrey V. Elsukov wrote: > On 20.06.2011 22:56, Kris Moore wrote: >> Here you go! >> # gpart list > Hi, > > thank you for the report. It's my fail. Can you test attached patch? > > > > _______________________________________________ > freebsd-geom@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-geom > To unsubscribe, send any mail to "freebsd-geom-unsubscribe@freebsd.org" I saw some commits from you and Xin, do you still need me to test this patch, or just svn update and give that a shot from HEAD? -- Kris Moore PC-BSD Software iXsystems From owner-freebsd-geom@FreeBSD.ORG Tue Jun 21 15:54:27 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id D95BD106564A for ; Tue, 21 Jun 2011 15:54:27 +0000 (UTC) (envelope-from eirnym@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id A18128FC0A for ; Tue, 21 Jun 2011 15:54:27 +0000 (UTC) Received: by iyb11 with SMTP id 11so2630033iyb.13 for ; Tue, 21 Jun 2011 08:54:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-type:content-transfer-encoding; bh=m4cTndWnnv0ei/spe++Hy4m5kg4jxijhblnnmNyjPz0=; b=ioAHR/kSxJtxjlfEuI/4/MfoepBdpEU+iCD+yd9gOyxmr5Qm5H30HbgKZF1dd7It6i QSZ5qLIPQvrzNTO+Dc0Cp6pbSe65qRI8ehi9zwDhHLdBfOXBSdQvGtGV+O43xvPWmlzk DMWnrOE6BHFgjH7Bhq0A0yeaPWoTnz43mdfKI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=dAy+9eQYGSBKlk8MVJgmdQsHPqXR2F2Bh4NyN/V1ihm7g1qYZBgEQWogG3XWXXy+yi aCMXZiV2vCyCtHWQdwo5aVKZXcMYIyueqN+GWDb9F3XQuFRvS9w6od02sq5CxCr7gVDR MfwFIvL0G4Sk7qTKvqj+2oALhpzu9F5o/jy08= Received: by 10.231.115.160 with SMTP id i32mr6267621ibq.143.1308669906084; Tue, 21 Jun 2011 08:25:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.231.38.5 with HTTP; Tue, 21 Jun 2011 08:24:46 -0700 (PDT) In-Reply-To: <4DFA376B.1050502@FreeBSD.org> References: <201106151620.p5FGK30l019900@freefall.freebsd.org> <4DFA376B.1050502@FreeBSD.org> From: Eir Nym Date: Tue, 21 Jun 2011 19:24:46 +0400 Message-ID: To: "Andrey V. Elsukov" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: freebsd-geom@freebsd.org Subject: Re: kern/157819: [geom] gpart(8): drop serial from MBR X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2011 15:54:27 -0000 2011/6/16 Andrey V. Elsukov : > On 15.06.2011 20:20, Eir Nym wrote: >> =C2=A0> The fundamental question we need to answer is this: >> =C2=A0> Is the serial number a well-defined field in the MBR that is >> =C2=A0> independent and unrelated to the bootcode, or not? >> >> =C2=A0Yes, this field is defined in several documentation sources. >> =C2=A0It has 6 bytes and used Windows OS as disk identifier in registry = to >> =C2=A0specify mount point. > > As i found this field is 4 bytes only. Next 2 bytes are used by our > boot0 boot manager to keep ticks count. Can you test attached patch, > does it fix your problem? > Yes, these patches are work for me. -- Eir Nym > -- > WBR, Andrey V. Elsukov > From owner-freebsd-geom@FreeBSD.ORG Thu Jun 23 07:22:05 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7FF2B106564A for ; Thu, 23 Jun 2011 07:22:05 +0000 (UTC) (envelope-from piotr-l@netexpert.pl) Received: from poczta.netexpert.pl (poczta.netexpert.pl [81.210.116.233]) by mx1.freebsd.org (Postfix) with ESMTP id 381F68FC0C for ; Thu, 23 Jun 2011 07:22:05 +0000 (UTC) Received: by poczta.netexpert.pl (Postfix, from userid 58) id BAA9217051; Thu, 23 Jun 2011 08:59:52 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on lancre.netexpert.net.pl X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=ham version=3.3.1 X-Spam-DCC: X-Spam-SCL: 1 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP Received: from [172.22.22.186] (evdo-78-30-74-94.subscribers.sferia.net [78.30.74.94]) by poczta.netexpert.pl (Postfix) with ESMTPA id 4980A17039 for ; Thu, 23 Jun 2011 08:59:50 +0200 (CEST) Message-ID: <4E02E573.5070102@netexpert.pl> Date: Thu, 23 Jun 2011 09:04:19 +0200 From: Piotr NetExpert User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.2.18) Gecko/20110616 Thunderbird MIME-Version: 1.0 To: freebsd-geom@freebsd.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: *.journal missing X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 07:22:05 -0000 Hi, I have got a journal made on top of a mirror. It was OK until today. After a reboot the system cannot mount journaled filesystems. After gjournal load I can see: GEOM_JOURNAL: Journal 4249355098: ifsid/4def2606510052ce contains data. GEOM_JOURNAL: Journal 4249355098: mirror/gm0s2h contains journal. GEOM_JOURNAL: Journal ifsid/4def2606510052ce clean. However I do not see *.journal entries under /dev/mirror and cannot mount journaled filesystems. What could be wrong? -- pozdrawiam Piotr Szafarczyk http://www.netexpert.pl From owner-freebsd-geom@FreeBSD.ORG Thu Jun 23 07:39:35 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 033AF106566B for ; Thu, 23 Jun 2011 07:39:35 +0000 (UTC) (envelope-from bu7cher@yandex.ru) Received: from forward3.mail.yandex.net (forward3.mail.yandex.net [77.88.46.8]) by mx1.freebsd.org (Postfix) with ESMTP id A46878FC22 for ; Thu, 23 Jun 2011 07:39:34 +0000 (UTC) Received: from smtp3.mail.yandex.net (smtp3.mail.yandex.net [77.88.46.103]) by forward3.mail.yandex.net (Yandex) with ESMTP id CF8E3B43224; Thu, 23 Jun 2011 11:39:32 +0400 (MSD) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1308814772; bh=P5VOgYu9xpMEvx3Nr6tUv9pG/Ep5Anb+ex6P7HY6wDU=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type; b=tPbmS9cfkS3nJTXDSLvOqU8mHleU7WlCaZA+TQAkzvAp+tEWCkH3miMgqQGhoaCHW 8TFHZuhkcIfqDxmIzIaq7UHwNSf/1kJGSfkyjGw3l7Dm3XbyhktmK+YWa50+GHgRZq HZXRsaNq3tyG7SCXfsc+w5I2+Gl82zwDiN+gwkYM= Received: from [127.0.0.1] (unknown [77.72.136.146]) by smtp3.mail.yandex.net (Yandex) with ESMTPSA id 94B616980067; Thu, 23 Jun 2011 11:39:32 +0400 (MSD) Message-ID: <4E02EDA7.6000304@yandex.ru> Date: Thu, 23 Jun 2011 11:39:19 +0400 From: "Andrey V. Elsukov" User-Agent: Mozilla Thunderbird 1.5 (FreeBSD/20051231) MIME-Version: 1.0 To: Piotr NetExpert References: <4E02E573.5070102@netexpert.pl> In-Reply-To: <4E02E573.5070102@netexpert.pl> X-Enigmail-Version: 1.1.1 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigDEBFD35CA0AAC0D3C7CEC3B6" X-Yandex-Spam: 1 Cc: freebsd-geom@freebsd.org Subject: Re: *.journal missing X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 07:39:35 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDEBFD35CA0AAC0D3C7CEC3B6 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable On 23.06.2011 11:04, Piotr NetExpert wrote: > I have got a journal made on top of a mirror. It was OK until today. Af= ter a reboot the system > cannot mount journaled filesystems. >=20 > After gjournal load I can see: > GEOM_JOURNAL: Journal 4249355098: ifsid/4def2606510052ce contains data.= > GEOM_JOURNAL: Journal 4249355098: mirror/gm0s2h contains journal. > GEOM_JOURNAL: Journal ifsid/4def2606510052ce clean. >=20 > However I do not see *.journal entries under /dev/mirror and cannot mou= nt journaled filesystems. >=20 > What could be wrong? Probably, gjournal has used glabel's ufsid provider. If you do not use ufs and ufsid labels you can disable them from the boot loader prompt or from the /boot/loader.conf. kern.geom.label.ufs.enable=3D0 kern.geom.label.ufsid.enable=3D0 --=20 WBR, Andrey V. Elsukov --------------enigDEBFD35CA0AAC0D3C7CEC3B6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) iQEcBAEBAgAGBQJOAu2qAAoJEAHF6gQQyKF6OJMH/1Amm6a51DRgCengz6t0OlhR YYkbGmj+7G+MwMc+tpS9KIroweUSUfN5XkMXu3xdPpn4hxLPMNNVH2gObZTiIrJn mjBQLBJSopmU6aEzIlMqyT45kNFFwArmNrlbcRCr5RRaJH2EBj7BP0gx/H/J4Y0u e1SKmeboonJy9lnamA2qVZskp6h233inCImpY5q9uSGily5nH1G5RvoGbuOYXzop 4ehs9S8Fldg2Dvy2lFdTP7oBuyVsha4F4yv8HklxHSridiB/qdv64ZE8Dyd3fX3p 5lO/JY+eAqq4NKsMmCtqlqGOfG5nVW9JEaoU6bsILkk0BEQrzQN1vQjn3FQM5Cg= =HEUH -----END PGP SIGNATURE----- --------------enigDEBFD35CA0AAC0D3C7CEC3B6-- From owner-freebsd-geom@FreeBSD.ORG Thu Jun 23 07:59:37 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 66CB9106566C for ; Thu, 23 Jun 2011 07:59:37 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 21A558FC16 for ; Thu, 23 Jun 2011 07:59:37 +0000 (UTC) Received: from localhost (garage.whl [10.0.3.1]) by mail.dawidek.net (Postfix) with ESMTPSA id 083F3160; Thu, 23 Jun 2011 08:47:38 +0200 (CEST) Date: Thu, 23 Jun 2011 09:59:26 +0200 From: Pawel Jakub Dawidek To: Piotr NetExpert Message-ID: <20110623075926.GB1842@garage.freebsd.pl> References: <4E02E573.5070102@netexpert.pl> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="eHhjakXzOLJAF9wJ" Content-Disposition: inline In-Reply-To: <4E02E573.5070102@netexpert.pl> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: freebsd-geom@freebsd.org Subject: Re: *.journal missing X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 07:59:37 -0000 --eHhjakXzOLJAF9wJ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 23, 2011 at 09:04:19AM +0200, Piotr NetExpert wrote: > Hi, >=20 > I have got a journal made on top of a mirror. It was OK until today.=20 > After a reboot the system cannot mount journaled filesystems. >=20 > After gjournal load I can see: > GEOM_JOURNAL: Journal 4249355098: ifsid/4def2606510052ce contains data. > GEOM_JOURNAL: Journal 4249355098: mirror/gm0s2h contains journal. > GEOM_JOURNAL: Journal ifsid/4def2606510052ce clean. ifsid or ufsid? > However I do not see *.journal entries under /dev/mirror and cannot=20 > mount journaled filesystems. >=20 > What could be wrong? Either turn off ufsid labels (kern.geom.label.ufsid.enable=3D0 in /boot/loader.conf), they are useless or look for .journal provider in /dev/ufsid/. --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --eHhjakXzOLJAF9wJ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk4C8l0ACgkQForvXbEpPzT45wCfWVFmCq2IxIn9tIvWcYDdVTrb 4gsAn0MbRHCWdJ40lwQavTH4POcq+jAU =tny7 -----END PGP SIGNATURE----- --eHhjakXzOLJAF9wJ-- From owner-freebsd-geom@FreeBSD.ORG Thu Jun 23 09:34:20 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (unknown [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 48CFB106566C for ; Thu, 23 Jun 2011 09:34:20 +0000 (UTC) (envelope-from piotr-l@netexpert.pl) Received: from poczta.netexpert.pl (poczta.netexpert.pl [81.210.116.233]) by mx1.freebsd.org (Postfix) with ESMTP id F39778FC08 for ; Thu, 23 Jun 2011 09:34:19 +0000 (UTC) Received: by poczta.netexpert.pl (Postfix, from userid 58) id E59A517051; Thu, 23 Jun 2011 11:29:42 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on lancre.netexpert.net.pl X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=ham version=3.3.1 X-Spam-DCC: X-Spam-SCL: 1 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP Received: from [172.22.22.186] (evdo-78-30-74-94.subscribers.sferia.net [78.30.74.94]) by poczta.netexpert.pl (Postfix) with ESMTPA id 6106A17039 for ; Thu, 23 Jun 2011 11:29:40 +0200 (CEST) Message-ID: <4E030891.2050507@netexpert.pl> Date: Thu, 23 Jun 2011 11:34:09 +0200 From: Piotr NetExpert User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.2.18) Gecko/20110616 Thunderbird MIME-Version: 1.0 To: freebsd-geom@freebsd.org References: <4E02E573.5070102@netexpert.pl> <4E02EDA7.6000304@yandex.ru> In-Reply-To: <4E02EDA7.6000304@yandex.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: *.journal missing X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 09:34:20 -0000 Thanks for a reply. It is almost OK now. If I include the settings in a loader.conf file and load gjournal manualy, I am able to mount filesystems. However it looks like gjournal is loaded before they are set if I set geom_journal_load to YES. Paweł, there should be ufsid/... I am not able to copy from a console. U and i are close on a keyboard :) -- Treść oryginalnej wiadomości -- > On 23.06.2011 11:04, Piotr NetExpert wrote: >> I have got a journal made on top of a mirror. It was OK until today. After a reboot the system >> cannot mount journaled filesystems. >> >> After gjournal load I can see: >> GEOM_JOURNAL: Journal 4249355098: ifsid/4def2606510052ce contains data. >> GEOM_JOURNAL: Journal 4249355098: mirror/gm0s2h contains journal. >> GEOM_JOURNAL: Journal ifsid/4def2606510052ce clean. >> >> However I do not see *.journal entries under /dev/mirror and cannot mount journaled filesystems. >> >> What could be wrong? > > Probably, gjournal has used glabel's ufsid provider. > If you do not use ufs and ufsid labels you can disable them from > the boot loader prompt or from the /boot/loader.conf. > > kern.geom.label.ufs.enable=0 > kern.geom.label.ufsid.enable=0 > -- pozdrawiam Piotr Szafarczyk http://www.netexpert.pl From owner-freebsd-geom@FreeBSD.ORG Thu Jun 23 15:40:50 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (unknown [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AF7C4106566C for ; Thu, 23 Jun 2011 15:40:50 +0000 (UTC) (envelope-from piotr-l@netexpert.pl) Received: from poczta.netexpert.pl (poczta.netexpert.pl [81.210.116.233]) by mx1.freebsd.org (Postfix) with ESMTP id 6504B8FC08 for ; Thu, 23 Jun 2011 15:40:50 +0000 (UTC) Received: by poczta.netexpert.pl (Postfix, from userid 58) id 6B37E17051; Thu, 23 Jun 2011 17:30:19 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on lancre.netexpert.net.pl X-Spam-Level: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED autolearn=ham version=3.3.1 X-Spam-DCC: X-Spam-SCL: 1 X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP Received: from [172.22.22.186] (evdo-78-30-74-94.subscribers.sferia.net [78.30.74.94]) by poczta.netexpert.pl (Postfix) with ESMTPA id 7A65D17039 for ; Thu, 23 Jun 2011 17:30:16 +0200 (CEST) Message-ID: <4E035E76.1060806@netexpert.pl> Date: Thu, 23 Jun 2011 17:40:38 +0200 From: Piotr NetExpert User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; pl; rv:1.9.2.18) Gecko/20110616 Thunderbird MIME-Version: 1.0 To: freebsd-geom@freebsd.org References: <4E02E573.5070102@netexpert.pl> <4E02EDA7.6000304@yandex.ru> <4E030891.2050507@netexpert.pl> In-Reply-To: <4E030891.2050507@netexpert.pl> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: *.journal missing X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 15:40:50 -0000 It looks like I just need to recreate journals. Thanks a lot for your help. -- Treść oryginalnej wiadomości -- > Thanks for a reply. It is almost OK now. > > If I include the settings in a loader.conf file and load gjournal > manualy, I am able to mount filesystems. However it looks like gjournal > is loaded before they are set if I set geom_journal_load to YES. > > Paweł, there should be ufsid/... I am not able to copy from a console. U > and i are close on a keyboard :) > > -- Treść oryginalnej wiadomości -- > >> On 23.06.2011 11:04, Piotr NetExpert wrote: >>> I have got a journal made on top of a mirror. It was OK until today. >>> After a reboot the system >>> cannot mount journaled filesystems. >>> >>> After gjournal load I can see: >>> GEOM_JOURNAL: Journal 4249355098: ifsid/4def2606510052ce contains data. >>> GEOM_JOURNAL: Journal 4249355098: mirror/gm0s2h contains journal. >>> GEOM_JOURNAL: Journal ifsid/4def2606510052ce clean. >>> >>> However I do not see *.journal entries under /dev/mirror and cannot >>> mount journaled filesystems. >>> >>> What could be wrong? >> >> Probably, gjournal has used glabel's ufsid provider. >> If you do not use ufs and ufsid labels you can disable them from >> the boot loader prompt or from the /boot/loader.conf. >> >> kern.geom.label.ufs.enable=0 >> kern.geom.label.ufsid.enable=0 >> > -- pozdrawiam Piotr Szafarczyk http://www.netexpert.pl From owner-freebsd-geom@FreeBSD.ORG Thu Jun 23 18:05:13 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (unknown [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AEFCD106566B for ; Thu, 23 Jun 2011 18:05:13 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 03B398FC08 for ; Thu, 23 Jun 2011 18:05:12 +0000 (UTC) Received: by fxm11 with SMTP id 11so2135626fxm.13 for ; Thu, 23 Jun 2011 11:05:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=q14NWe7tTPtP34yyirdoTdpFpmWR+eUBg8IkmHwdcLI=; b=s/UsRoMD9DuthkXCTig6S++uEhR5bMEmudi2dkgj0q+qqdTEvly1hn+eyWcDDBJIoo MpIl21fbrxlcG8wEOXcZKWpjfEBkizkN8kjmyhWYJXzbTnwAfyJgtG2nDw51bismjOUE Xeh79g50ZVOjOURhvCzfcylpJT0rWCVZiSrCE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; b=bgCGeg14iFXBJQ53I1tZCFQ/Uy1+t0biKzc6XROB4/lxh/CZrLok2JSlkLbxbD0W66 Ye/XXm6lb9RGSV4IeajuXRnTce3uBslmuKP2OVfJOQfDdps4NB4yIT1ogK2sLoM7oKIU Xfgi26MeTLkTR77Ny5oFAdVMGVtg0ByrOQ3zw= Received: by 10.223.37.153 with SMTP id x25mr3042583fad.117.1308852311579; Thu, 23 Jun 2011 11:05:11 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id h1sm1139401fag.11.2011.06.23.11.05.09 (version=SSLv3 cipher=OTHER); Thu, 23 Jun 2011 11:05:10 -0700 (PDT) Sender: Alexander Motin Message-ID: <4E038051.3020809@FreeBSD.org> Date: Thu, 23 Jun 2011 21:05:05 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.17) Gecko/20110616 Thunderbird/3.1.10 MIME-Version: 1.0 To: Gavin Atkinson References: <1308851620.3853.34.camel@buffy.york.ac.uk> In-Reply-To: <1308851620.3853.34.camel@buffy.york.ac.uk> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Cc: freebsd-geom@FreeBSD.org Subject: Re: geom_raid tasting providers that can't be raw disks X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 18:05:13 -0000 Hi. On 23.06.2011 20:53, Gavin Atkinson wrote: > While debugging a problem that looks like it was unrelated to geom_raid, > I realised that it tastes all providers, including each partition and > slice on raid devices it itself created. > > Given that geom_raid is purely a replacement for ataraid, the only place > that the metadata can be valid is on the raw disk itself. Therefore, > I'm proposing this patch: > > Index: sys/geom/raid/g_raid.c > =================================================================== > --- sys/geom/raid/g_raid.c (revision 223446) > +++ sys/geom/raid/g_raid.c (working copy) > @@ -1993,6 +1993,12 @@ > g_trace(G_T_TOPOLOGY, "%s(%s, %s)", __func__, mp->name, pp->name); > G_RAID_DEBUG(2, "Tasting provider %s.", pp->name); > > + if (pp->geom->rank> 1) { > + G_RAID_DEBUG(2, "Rank of provider %s is %d, skipping.", > + pp->name, pp->geom->rank); > + return (NULL); > + } > + > gp = g_new_geomf(mp, "mirror:taste"); > /* > * This orphan function should be never called. > > This will only allow the probing to happen on providers of rank 1, i.e. > the disks themselves. I can't see any reason to probe any other > providers. Any objection to this? In general case nothing prevents from using graid on partitions (instead of gmirror/gstripe/...) if BIOS support is not needed. I think this check at least should be moved to specific metadata modules in case if we later add support for abstract gxxx metadata formats. > Also, should geom_raid be in GENERIC? ataraid was, and it's one less > "gotcha" for upgrades. Given the lack of ar0 -> raid/r0 aliases, the > upgrade is painful enough for users already, putting it in GENERIC may > at least help slightly... Aggressive tasting for each metadata format was actually the reason why I haven't added it. If we load all GEOM modules, then some floppy tasting will take ages. -- Alexander Motin From owner-freebsd-geom@FreeBSD.ORG Thu Jun 23 18:11:12 2011 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (unknown [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6D0CA1065670 for ; Thu, 23 Jun 2011 18:11:12 +0000 (UTC) (envelope-from gavin@FreeBSD.org) Received: from gse-mta-27.emailfiltering.com (gse-mta-27-tx.emailfiltering.com [194.116.198.158]) by mx1.freebsd.org (Postfix) with ESMTP id DC8748FC1C for ; Thu, 23 Jun 2011 18:11:11 +0000 (UTC) Received: from mail-gw12.york.ac.uk ([144.32.129.162]) by gse-mta-27.emailfiltering.com with emfmta (version 4.8.2.32) by TLS id 1045496144 for freebsd-geom@FreeBSD.org; a62f5eb6a2bbd093; Thu, 23 Jun 2011 18:53:42 +0100 Received: from buffy-128.york.ac.uk ([144.32.128.160]:24432 helo=buffy.york.ac.uk) by mail-gw12.york.ac.uk with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QZo61-0005f1-IC; Thu, 23 Jun 2011 18:53:41 +0100 Received: from buffy.york.ac.uk (localhost [127.0.0.1]) by buffy.york.ac.uk (8.14.4/8.14.4) with ESMTP id p5NHreTA028223; Thu, 23 Jun 2011 18:53:40 +0100 (BST) (envelope-from gavin@FreeBSD.org) Received: (from ga9@localhost) by buffy.york.ac.uk (8.14.4/8.14.4/Submit) id p5NHreAI028222; Thu, 23 Jun 2011 18:53:40 +0100 (BST) (envelope-from gavin@FreeBSD.org) X-Authentication-Warning: buffy.york.ac.uk: ga9 set sender to gavin@FreeBSD.org using -f From: Gavin Atkinson To: freebsd-geom@FreeBSD.org Content-Type: text/plain; charset="ASCII" Content-Transfer-Encoding: quoted-printable Date: Thu, 23 Jun 2011 18:53:40 +0100 Message-ID: <1308851620.3853.34.camel@buffy.york.ac.uk> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Cc: mav@FreeBSD.org Subject: geom_raid tasting providers that can't be raw disks X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 18:11:12 -0000 Hi, While debugging a problem that looks like it was unrelated to geom_raid, I realised that it tastes all providers, including each partition and slice on raid devices it itself created. Given that geom_raid is purely a replacement for ataraid, the only place that the metadata can be valid is on the raw disk itself. Therefore, I'm proposing this patch: Index: sys/geom/raid/g_raid.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/geom/raid/g_raid.c (revision 223446) +++ sys/geom/raid/g_raid.c (working copy) @@ -1993,6 +1993,12 @@ g_trace(G_T_TOPOLOGY, "%s(%s, %s)", __func__, mp->name, pp->name); G_RAID_DEBUG(2, "Tasting provider %s.", pp->name); + if (pp->geom->rank > 1) { + G_RAID_DEBUG(2, "Rank of provider %s is %d, skipping.", + pp->name, pp->geom->rank); + return (NULL); + } + gp =3D g_new_geomf(mp, "mirror:taste"); /* * This orphan function should be never called. This will only allow the probing to happen on providers of rank 1, i.e. the disks themselves. I can't see any reason to probe any other providers. Any objection to this? Also, should geom_raid be in GENERIC? ataraid was, and it's one less "gotcha" for upgrades. Given the lack of ar0 -> raid/r0 aliases, the upgrade is painful enough for users already, putting it in GENERIC may at least help slightly... Thanks, Gavin --=20 Gavin Atkinson FreeBSD committer and bugmeister GPG: A093262B (313A A79F 697D 3A5C 216A EDF5 935D EF44 A093 262B) From owner-freebsd-geom@FreeBSD.ORG Thu Jun 23 23:04:05 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (unknown [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id CBF901065674; Thu, 23 Jun 2011 23:04:05 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-fx0-f54.google.com (mail-fx0-f54.google.com [209.85.161.54]) by mx1.freebsd.org (Postfix) with ESMTP id 200CF8FC0C; Thu, 23 Jun 2011 23:04:04 +0000 (UTC) Received: by fxm11 with SMTP id 11so2361863fxm.13 for ; Thu, 23 Jun 2011 16:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:sender:message-id:date:from:user-agent :mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=PPo4I5IN1YF9/ATurxJFFwVDgRLLlVYm21MHc0fOqQ8=; b=hEfVi756nhxj+V3sVRGRZoZurEaSYZqSgr4UXjX91GXivX2phvVps0dGhYAz9bFGJw LDl8oZ6HKARLLTBco8SR7Vcek7Uo5D7N0nwqXMSl0JJo3FsI8TimzYLlsPgD/Xph7Wad 8QWsTi1cj5/hVN7uHeYphNLK+TWyJGJvGOw+k= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=U8PfKBiJg+pDEJnI7d5YEMm1wBFQmNj5iPeminOXcu/Bz2oBjAQllTOGiy01qyTCZn gWFHo7utRKHEUn2Cl5KMl5vNQ1/ksdOPRXVRVXJo7ex6CJborHMGWyypkRCjLj9KGybE vx2fiIOBTXRtwXq+r9Za8rBLr9gZ8fIpaBicQ= Received: by 10.223.1.70 with SMTP id 6mr3436019fae.82.1308870244028; Thu, 23 Jun 2011 16:04:04 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id e16sm1278371fak.17.2011.06.23.16.04.02 (version=SSLv3 cipher=OTHER); Thu, 23 Jun 2011 16:04:03 -0700 (PDT) Sender: Alexander Motin Message-ID: <4E03C621.4050505@FreeBSD.org> Date: Fri, 24 Jun 2011 02:02:57 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: Gavin Atkinson References: <1308851620.3853.34.camel@buffy.york.ac.uk> <4E038051.3020809@FreeBSD.org> <4e03c408.45822a0a.66cf.ffffe135SMTPIN_ADDED@mx.google.com> In-Reply-To: <4e03c408.45822a0a.66cf.ffffe135SMTPIN_ADDED@mx.google.com> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-geom@FreeBSD.org Subject: Re: geom_raid tasting providers that can't be raw disks X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 23:04:06 -0000 Gavin Atkinson wrote: > On Thu, 23 Jun 2011, Alexander Motin wrote: >> On 23.06.2011 20:53, Gavin Atkinson wrote: >>> While debugging a problem that looks like it was unrelated to geom_raid, >>> I realised that it tastes all providers, including each partition and >>> slice on raid devices it itself created. >>> >>> Given that geom_raid is purely a replacement for ataraid, the only place >>> that the metadata can be valid is on the raw disk itself. >> In general case nothing prevents from using graid on partitions (instead of >> gmirror/gstripe/...) if BIOS support is not needed. I think this check at >> least should be moved to specific metadata modules in case if we later add >> support for abstract gxxx metadata formats. > > OK, thanks. I had believed that this was purely for use on hardware. If > the intention is that this module can be used on arbitrary providers, then > I see no reason to change things. It may depend on metadata format. For example, Intel format depends on valid provider serial number. It can't be used on providers without serial number -- it won't be able to find place in array for the components. Not sure if any non-hardware provider has serial number, so this limitation can be effectively the same. >>> Also, should geom_raid be in GENERIC? ataraid was, and it's one less >>> "gotcha" for upgrades. Given the lack of ar0 -> raid/r0 aliases, the >>> upgrade is painful enough for users already, putting it in GENERIC may >>> at least help slightly... >> Aggressive tasting for each metadata format was actually the reason why I >> haven't added it. If we load all GEOM modules, then some floppy tasting will >> take ages. > > OK, that makes sense. > > I had a bit of a look this evening as to the best way to try to get code > in place to provide /dev/arX compatibility nodes whenever a geom_raid > array is discovered. Is there any reason that I shouldn't take exactly > the same approach as you have done with the adX -> adaX compatibility > shims? May be not. Just haven't tried. Should be only few lines. -- Alexander Motin From owner-freebsd-geom@FreeBSD.ORG Thu Jun 23 23:11:48 2011 Return-Path: Delivered-To: freebsd-geom@FreeBSD.org Received: from mx1.freebsd.org (unknown [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0E598106566C for ; Thu, 23 Jun 2011 23:11:48 +0000 (UTC) (envelope-from gavin.atkinson@ury.york.ac.uk) Received: from gse-mta-27.emailfiltering.com (gse-mta-27-tx.emailfiltering.com [194.116.198.158]) by mx1.freebsd.org (Postfix) with ESMTP id 808028FC08 for ; Thu, 23 Jun 2011 23:11:47 +0000 (UTC) Received: from mail-gw5.york.ac.uk ([144.32.129.29]) by gse-mta-27.emailfiltering.com with emfmta (version 4.8.2.32) by TLS id 1045647620 for mav@FreeBSD.org;172ed6f60f60bd64; Thu, 23 Jun 2011 23:53:46 +0100 Received: from ury.york.ac.uk ([144.32.108.81]:35733) by mail-gw5.york.ac.uk with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QZsmP-0006hx-Uq; Thu, 23 Jun 2011 23:53:45 +0100 Received: from gavin (helo=localhost) by ury.york.ac.uk with local-esmtp (Exim 4.76) (envelope-from ) id 1QZsmP-0007j3-Mo; Thu, 23 Jun 2011 23:53:45 +0100 Date: Thu, 23 Jun 2011 23:53:45 +0100 (BST) From: Gavin Atkinson X-X-Sender: gavin@"ury.york.ac.uk." To: Alexander Motin In-Reply-To: <4E038051.3020809@FreeBSD.org> Message-ID: References: <1308851620.3853.34.camel@buffy.york.ac.uk> <4E038051.3020809@FreeBSD.org> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: Cc: freebsd-geom@FreeBSD.org Subject: Re: geom_raid tasting providers that can't be raw disks X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jun 2011 23:11:48 -0000 On Thu, 23 Jun 2011, Alexander Motin wrote: > On 23.06.2011 20:53, Gavin Atkinson wrote: > > While debugging a problem that looks like it was unrelated to geom_raid, > > I realised that it tastes all providers, including each partition and > > slice on raid devices it itself created. > > > > Given that geom_raid is purely a replacement for ataraid, the only place > > that the metadata can be valid is on the raw disk itself. > > In general case nothing prevents from using graid on partitions (instead of > gmirror/gstripe/...) if BIOS support is not needed. I think this check at > least should be moved to specific metadata modules in case if we later add > support for abstract gxxx metadata formats. OK, thanks. I had believed that this was purely for use on hardware. If the intention is that this module can be used on arbitrary providers, then I see no reason to change things. > > Also, should geom_raid be in GENERIC? ataraid was, and it's one less > > "gotcha" for upgrades. Given the lack of ar0 -> raid/r0 aliases, the > > upgrade is painful enough for users already, putting it in GENERIC may > > at least help slightly... > > Aggressive tasting for each metadata format was actually the reason why I > haven't added it. If we load all GEOM modules, then some floppy tasting will > take ages. OK, that makes sense. I had a bit of a look this evening as to the best way to try to get code in place to provide /dev/arX compatibility nodes whenever a geom_raid array is discovered. Is there any reason that I shouldn't take exactly the same approach as you have done with the adX -> adaX compatibility shims? Thanks, Gavin From owner-freebsd-geom@FreeBSD.ORG Fri Jun 24 00:29:07 2011 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (unknown [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id ED27A106566B; Fri, 24 Jun 2011 00:29:07 +0000 (UTC) (envelope-from linimon@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [69.147.83.40]) by mx1.freebsd.org (Postfix) with ESMTP id C49948FC12; Fri, 24 Jun 2011 00:29:07 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5O0T7Bt061947; Fri, 24 Jun 2011 00:29:07 GMT (envelope-from linimon@freefall.freebsd.org) Received: (from linimon@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5O0T7In061943; Fri, 24 Jun 2011 00:29:07 GMT (envelope-from linimon) Date: Fri, 24 Jun 2011 00:29:07 GMT Message-Id: <201106240029.p5O0T7In061943@freefall.freebsd.org> To: linimon@FreeBSD.org, freebsd-amd64@FreeBSD.org, freebsd-geom@FreeBSD.org From: linimon@FreeBSD.org Cc: Subject: Re: kern/158197: [geom] geom_cache with size>1000 leads to panics X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Jun 2011 00:29:08 -0000 Old Synopsis: geom_cache with size>1000 leads to panics New Synopsis: [geom] geom_cache with size>1000 leads to panics Responsible-Changed-From-To: freebsd-amd64->freebsd-geom Responsible-Changed-By: linimon Responsible-Changed-When: Fri Jun 24 00:27:56 UTC 2011 Responsible-Changed-Why: Over to maintainer(s). http://www.freebsd.org/cgi/query-pr.cgi?pr=158197 From owner-freebsd-geom@FreeBSD.ORG Sat Jun 25 21:13:25 2011 Return-Path: Delivered-To: freebsd-geom@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 438AD106564A for ; Sat, 25 Jun 2011 21:13:25 +0000 (UTC) (envelope-from perryh@pluto.rain.com) Received: from agora.rdrop.com (agora.rdrop.com [IPv6:2607:f678:1010::34]) by mx1.freebsd.org (Postfix) with ESMTP id 0D5FC8FC12 for ; Sat, 25 Jun 2011 21:13:25 +0000 (UTC) Received: from agora.rdrop.com (66@localhost [127.0.0.1]) by agora.rdrop.com (8.13.1/8.12.7) with ESMTP id p5PLDO5Q083972 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Sat, 25 Jun 2011 14:13:24 -0700 (PDT) (envelope-from perryh@pluto.rain.com) Received: (from uucp@localhost) by agora.rdrop.com (8.13.1/8.12.9/Submit) with UUCP id p5PLDOVj083971 for freebsd-geom@freebsd.org; Sat, 25 Jun 2011 14:13:24 -0700 (PDT) Received: from fbsd61 by pluto.rain.com (4.1/SMI-4.1-pluto-M2060407) id AA08390; Sat, 25 Jun 11 14:11:47 PDT Date: Sat, 25 Jun 2011 14:11:11 -0700 From: perryh@pluto.rain.com To: freebsd-geom@freebsd.org Message-Id: <4e064eef.qVQOy1VCTJp2wI/g%perryh@pluto.rain.com> User-Agent: nail 11.25 7/29/05 Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Subject: gmirror robustness X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 25 Jun 2011 21:13:25 -0000 How would I go about making gmirror more robust WRT transient errors? Once in a while I get a sequence like this (reformatted): Jun 25 15:55:30 fbsd81 kernel: ad8: WARNING - WRITE_DMA48 UDMA ICRC error (retrying request) LBA=615769530 Jun 25 15:55:30 fbsd81 kernel: ad8: FAILURE - WRITE_DMA48 status=51 error=4 LBA=615769530 Jun 25 15:55:30 fbsd81 kernel: GEOM_MIRROR: Request failed (error=5). ad8s2a[WRITE(offset=315265765888, length=78336)] Jun 25 15:55:30 fbsd81 kernel: GEOM_MIRROR: Device gm0: provider ad8s2a disconnected. It's always the same 4 messages: a retried WRITE_DMA48 UDMA ICRC error, a WRITE_DMA48 "FAILURE" on the same LBA with status=51 and error=4, a gmirror "Request failed (error=5)", and a disconnect. The LBA, offset, and length vary from one instance to another. It's unclear why the ad8 driver is returning an error indication after a single retryable error -- I'll be asking about that on drivers@ -- but the question here is how to improve gmirror's handling of the situation. I'd prefer to have gmirror retry before giving up and disconnecting, or at least deactivate instead of disconnecting (so that I can reactivate, and have it update the mirror, rather than having to re-insert the disconnected provider and have gmirror spend the next couple of hours recopying everything). Are there any configuration settings that would affect this behavior, or would I have to hack the code?