From owner-freebsd-sparc64@FreeBSD.ORG Sun Mar 24 07:20:35 2013 Return-Path: Delivered-To: sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 216D9B13; Sun, 24 Mar 2013 07:20:35 +0000 (UTC) (envelope-from tinderbox@freebsd.org) Received: from freebsd-current.sentex.ca (freebsd-current.sentex.ca [64.7.128.98]) by mx1.freebsd.org (Postfix) with ESMTP id D5C6DC25; Sun, 24 Mar 2013 07:20:34 +0000 (UTC) Received: from freebsd-current.sentex.ca (localhost [127.0.0.1]) by freebsd-current.sentex.ca (8.14.5/8.14.5) with ESMTP id r2O7KYqI029728; Sun, 24 Mar 2013 03:20:34 -0400 (EDT) (envelope-from tinderbox@freebsd.org) Received: (from tinderbox@localhost) by freebsd-current.sentex.ca (8.14.5/8.14.5/Submit) id r2O7KYEY029727; Sun, 24 Mar 2013 07:20:34 GMT (envelope-from tinderbox@freebsd.org) Date: Sun, 24 Mar 2013 07:20:34 GMT Message-Id: <201303240720.r2O7KYEY029727@freebsd-current.sentex.ca> X-Authentication-Warning: freebsd-current.sentex.ca: tinderbox set sender to FreeBSD Tinderbox using -f Sender: FreeBSD Tinderbox From: FreeBSD Tinderbox To: FreeBSD Tinderbox , , Subject: [head tinderbox] failure on sparc64/sparc64 Precedence: bulk X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.14 List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Mar 2013 07:20:35 -0000 TB --- 2013-03-24 06:26:48 - tinderbox 2.10 running on freebsd-current.sentex.ca TB --- 2013-03-24 06:26:48 - FreeBSD freebsd-current.sentex.ca 8.3-PRERELEASE FreeBSD 8.3-PRERELEASE #0: Mon Mar 26 13:54:12 EDT 2012 des@freebsd-current.sentex.ca:/usr/obj/usr/src/sys/GENERIC amd64 TB --- 2013-03-24 06:26:48 - starting HEAD tinderbox run for sparc64/sparc64 TB --- 2013-03-24 06:26:48 - cleaning the object tree TB --- 2013-03-24 06:26:48 - /usr/local/bin/svn stat /src TB --- 2013-03-24 06:26:53 - At svn revision 248671 TB --- 2013-03-24 06:26:54 - building world TB --- 2013-03-24 06:26:54 - CROSS_BUILD_TESTING=YES TB --- 2013-03-24 06:26:54 - MAKEOBJDIRPREFIX=/obj TB --- 2013-03-24 06:26:54 - PATH=/usr/bin:/usr/sbin:/bin:/sbin TB --- 2013-03-24 06:26:54 - SRCCONF=/dev/null TB --- 2013-03-24 06:26:54 - TARGET=sparc64 TB --- 2013-03-24 06:26:54 - TARGET_ARCH=sparc64 TB --- 2013-03-24 06:26:54 - TZ=UTC TB --- 2013-03-24 06:26:54 - __MAKE_CONF=/dev/null TB --- 2013-03-24 06:26:54 - cd /src TB --- 2013-03-24 06:26:54 - /usr/bin/make -B buildworld >>> Building an up-to-date make(1) >>> World build started on Sun Mar 24 06:26:59 UTC 2013 >>> Rebuilding the temporary build tree >>> stage 1.1: legacy release compatibility shims >>> stage 1.2: bootstrap tools >>> stage 2.1: cleaning up the object tree >>> stage 2.2: rebuilding the object tree >>> stage 2.3: build tools >>> stage 3: cross tools >>> stage 4.1: building includes >>> stage 4.2: building libraries >>> stage 4.3: make dependencies >>> stage 4.4: building everything [...] cc -O2 -pipe -I/src/sbin/fsck_ffs -I/src/sbin/fsck_ffs/../mount -DRESCUE -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -c /src/sbin/fsck_ffs/ea.c cc -O2 -pipe -I/src/sbin/fsck_ffs -I/src/sbin/fsck_ffs/../mount -DRESCUE -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -c /src/sbin/fsck_ffs/fsutil.c cc1: warnings being treated as errors /src/sbin/fsck_ffs/fsutil.c: In function 'printIOstats': /src/sbin/fsck_ffs/fsutil.c:511: warning: format '%d' expects type 'int', but argument 2 has type 'time_t' /src/sbin/fsck_ffs/fsutil.c:526: warning: format '%4d' expects type 'int', but argument 6 has type 'time_t' /src/sbin/fsck_ffs/fsutil.c:526: warning: format '%2jd' expects type 'intmax_t', but argument 8 has type 'long long int' /src/sbin/fsck_ffs/fsutil.c:526: warning: format '%jd' expects type 'intmax_t', but argument 9 has type 'long long int' *** [fsutil.o] Error code 1 Stop in /src/sbin/fsck_ffs. *** [fsck_ffs_make] Error code 1 Stop in /obj/sparc64.sparc64/src/rescue/rescue. *** [objs] Error code 1 Stop in /src/rescue/rescue. *** [all] Error code 1 Stop in /src/rescue. *** [rescue.all__D] Error code 1 Stop in /src. *** [everything] Error code 1 Stop in /src. *** Error code 1 Stop in /src. TB --- 2013-03-24 07:20:34 - WARNING: /usr/bin/make returned exit code 1 TB --- 2013-03-24 07:20:34 - ERROR: failed to build world TB --- 2013-03-24 07:20:34 - 2446.69 user 443.98 system 3225.84 real http://tinderbox.freebsd.org/tinderbox-head-ss-build-HEAD-sparc64-sparc64.full From owner-freebsd-sparc64@FreeBSD.ORG Sun Mar 24 09:19:17 2013 Return-Path: Delivered-To: sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 9C9B54EA; Sun, 24 Mar 2013 09:19:17 +0000 (UTC) (envelope-from delphij@delphij.net) Received: from anubis.delphij.net (anubis.delphij.net [IPv6:2001:470:1:117::25]) by mx1.freebsd.org (Postfix) with ESMTP id 81DDCCEB; Sun, 24 Mar 2013 09:19:17 +0000 (UTC) Received: from delphij-macbook.local (c-67-188-85-47.hsd1.ca.comcast.net [67.188.85.47]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by anubis.delphij.net (Postfix) with ESMTPSA id 271285680; Sun, 24 Mar 2013 02:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=delphij.net; s=anubis; t=1364116757; bh=WxbkfVmLhL5NylDRj3orfb0VxTQp5DPLZwMzHvPRTDg=; h=Date:From:Reply-To:To:CC:Subject:References:In-Reply-To; b=04knuL51BWokxmSJP7Qv/+MbesnzgGvheyA9UZdqHX9Mw9hrm76XRoPZUod7+CVue hb2kezyTeBM1uGkutFn7hfljQgnqf8Kq15SG4MViPCXz4dtZ/KVZ7FsXHyGjUFShKU /SYYYNGF/uELVXsIhk3l/rXFedXFeAqfVpTjFHzo= Message-ID: <514EC514.6080504@delphij.net> Date: Sun, 24 Mar 2013 02:19:16 -0700 From: Xin Li Organization: The FreeBSD Project MIME-Version: 1.0 To: FreeBSD Tinderbox Subject: Re: [head tinderbox] failure on sparc64/sparc64 References: <201303240720.r2O7KYEY029727@freebsd-current.sentex.ca> In-Reply-To: <201303240720.r2O7KYEY029727@freebsd-current.sentex.ca> X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Marshall Kirk McKusick , current@freebsd.org, sparc64@freebsd.org X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: d@delphij.net List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Mar 2013 09:19:17 -0000 -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA256 On 3/24/13 12:20 AM, FreeBSD Tinderbox wrote: > TB --- 2013-03-24 06:26:48 - tinderbox 2.10 running on > freebsd-current.sentex.ca TB --- 2013-03-24 06:26:48 - FreeBSD > freebsd-current.sentex.ca 8.3-PRERELEASE FreeBSD 8.3-PRERELEASE #0: > Mon Mar 26 13:54:12 EDT 2012 > des@freebsd-current.sentex.ca:/usr/obj/usr/src/sys/GENERIC amd64 > TB --- 2013-03-24 06:26:48 - starting HEAD tinderbox run for > sparc64/sparc64 TB --- 2013-03-24 06:26:48 - cleaning the object > tree TB --- 2013-03-24 06:26:48 - /usr/local/bin/svn stat /src TB > --- 2013-03-24 06:26:53 - At svn revision 248671 TB --- 2013-03-24 > 06:26:54 - building world TB --- 2013-03-24 06:26:54 - > CROSS_BUILD_TESTING=YES TB --- 2013-03-24 06:26:54 - > MAKEOBJDIRPREFIX=/obj TB --- 2013-03-24 06:26:54 - > PATH=/usr/bin:/usr/sbin:/bin:/sbin TB --- 2013-03-24 06:26:54 - > SRCCONF=/dev/null TB --- 2013-03-24 06:26:54 - TARGET=sparc64 TB > --- 2013-03-24 06:26:54 - TARGET_ARCH=sparc64 TB --- 2013-03-24 > 06:26:54 - TZ=UTC TB --- 2013-03-24 06:26:54 - > __MAKE_CONF=/dev/null TB --- 2013-03-24 06:26:54 - cd /src TB --- > 2013-03-24 06:26:54 - /usr/bin/make -B buildworld >>>> Building an up-to-date make(1) World build started on Sun Mar >>>> 24 06:26:59 UTC 2013 Rebuilding the temporary build tree >>>> stage 1.1: legacy release compatibility shims stage 1.2: >>>> bootstrap tools stage 2.1: cleaning up the object tree stage >>>> 2.2: rebuilding the object tree stage 2.3: build tools stage >>>> 3: cross tools stage 4.1: building includes stage 4.2: >>>> building libraries stage 4.3: make dependencies stage 4.4: >>>> building everything > [...] cc -O2 -pipe -I/src/sbin/fsck_ffs > -I/src/sbin/fsck_ffs/../mount -DRESCUE -std=gnu99 -fstack-protector > -Wsystem-headers -Werror -Wall -Wno-format-y2k -Wno-uninitialized > -Wno-pointer-sign -c /src/sbin/fsck_ffs/ea.c cc -O2 -pipe > -I/src/sbin/fsck_ffs -I/src/sbin/fsck_ffs/../mount -DRESCUE > -std=gnu99 -fstack-protector -Wsystem-headers -Werror -Wall > -Wno-format-y2k -Wno-uninitialized -Wno-pointer-sign -c > /src/sbin/fsck_ffs/fsutil.c cc1: warnings being treated as errors > /src/sbin/fsck_ffs/fsutil.c: In function 'printIOstats': > /src/sbin/fsck_ffs/fsutil.c:511: warning: format '%d' expects type > 'int', but argument 2 has type 'time_t' > /src/sbin/fsck_ffs/fsutil.c:526: warning: format '%4d' expects type > 'int', but argument 6 has type 'time_t' > /src/sbin/fsck_ffs/fsutil.c:526: warning: format '%2jd' expects > type 'intmax_t', but argument 8 has type 'long long int' > /src/sbin/fsck_ffs/fsutil.c:526: warning: format '%jd' expects type > 'intmax_t', but argument 9 has type 'long long int' *** [fsutil.o] > Error code 1 This should fix the issue, can someone review and commit it? Index: sbin/fsck_ffs/fsutil.c =================================================================== - --- sbin/fsck_ffs/fsutil.c (revision 248678) +++ sbin/fsck_ffs/fsutil.c (working copy) @@ -507,8 +507,8 @@ static void printIOstats(void) clock_gettime(CLOCK_REALTIME_PRECISE, &finishpass); timespecsub(&finishpass, &startpass); - - printf("Running time: %ld.%03ld msec\n", - - finishpass.tv_sec, finishpass.tv_nsec / 1000000); + printf("Running time: %jd.%03jd msec\n", + (intmax_t)finishpass.tv_sec, (intmax_t)finishpass.tv_nsec / 1000000); printf("buffer reads by type:\n"); for (totalmsec = 0, i = 0; i < BT_NUMBUFTYPES; i++) totalmsec += readtime[i].tv_sec * 1000 + @@ -519,10 +519,10 @@ static void printIOstats(void) if (readcnt[i] == 0) continue; msec = readtime[i].tv_sec * 1000 + readtime[i].tv_nsec / 1000000; - - printf("%21s:%8ld %2ld.%ld%% %4ld.%03ld sec %2lld.%lld%%\n", + printf("%21s:%8ld %2ld.%ld%% %4jd.%03jd sec %2lld.%lld%%\n", buftype[i], readcnt[i], readcnt[i] * 100 / diskreads, (readcnt[i] * 1000 / diskreads) % 10, - - readtime[i].tv_sec, readtime[i].tv_nsec / 1000000, + (intmax_t)readtime[i].tv_sec, (intmax_t)readtime[i].tv_nsec / 1000000, msec * 100 / totalmsec, (msec * 1000 / totalmsec) % 10); } printf("\n"); Cheers, -----BEGIN PGP SIGNATURE----- iQEcBAEBCAAGBQJRTsUUAAoJEG80Jeu8UPuziSkIAImVgY8aEExJ1b2zLu2wLL2y hHpQ+oMf63WFEQ3XN+wYnY0sZyjpBCTUULkdSQPbnj9eymJ8UkaPkdvE2JN4jWDu UqTuSI4E7IYZpoH06LiAZTnNFI0+H072sdFTw7bUVwLTm4x7lOUD2G9JFZCOhBKi QyXJ1r6i/jTORoRH+3oAYEl5hZk9IniFBkQp7i5Elzm/mxFpT/H7b48ptTmv+3+o fKRLduuu6zNd+DtCOUmPAgyOOLyh1szAxhoIdQj5iopRgzdS1f5uQ7xP+SWqDhrl PdT8YtEfFuXFeAg+PpgDWTank7lMKn4QBNn9g4CsvLrs4eA/JN3aSStuMWkzfgQ= =VsRR -----END PGP SIGNATURE----- From owner-freebsd-sparc64@FreeBSD.ORG Mon Mar 25 01:20:23 2013 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 508AC282 for ; Mon, 25 Mar 2013 01:20:23 +0000 (UTC) (envelope-from cross+freebsd@distal.com) Received: from mail.distal.com (mail.distal.com [IPv6:2001:470:e24c:200::ae25]) by mx1.freebsd.org (Postfix) with ESMTP id 18026F53 for ; Mon, 25 Mar 2013 01:20:22 +0000 (UTC) Received: from magrathea.distal.com (magrathea.distal.com [IPv6:2001:470:e24c:200:ea06:88ff:feca:960e]) (authenticated bits=0) by mail.distal.com (8.14.3/8.14.3) with ESMTP id r2P1KJQN020907 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Sun, 24 Mar 2013 21:20:21 -0400 (EDT) From: Chris Ross Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Subject: CAM timeouts on Netra X1 Message-Id: Date: Sun, 24 Mar 2013 21:20:19 -0400 To: "freebsd-sparc64@freebsd.org" Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) X-Mailer: Apple Mail (2.1503) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.2 (mail.distal.com [IPv6:2001:470:e24c:200::ae25]); Sun, 24 Mar 2013 21:20:22 -0400 (EDT) X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2013 01:20:23 -0000 This may not be sparc64 specific, but. I have a Netra X1 that I've = been netbooting, to eventually install FreeBSD onto its disks. Booting = a recent stable/9. with the old disks (one 80G, one 250G), I would see = the following [sort] of errors during [net]boot: (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 00 (ada0:ata2:0:0:0): CAM status: Command timeout (ada0:ata2:0:0:0): Retrying command (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 00 (ada0:ata2:0:0:0): CAM status: Command timeout (ada0:ata2:0:0:0): Retrying command (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 00 (ada0:ata2:0:0:0): CAM status: Command timeout (ada0:ata2:0:0:0): Retrying command (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 00 (ada0:ata2:0:0:0): CAM status: Command timeout (ada0:ata2:0:0:0): Retrying command (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 00 (ada0:ata2:0:0:0): CAM status: Command timeout (ada0:ata2:0:0:0): Error 5, Retries exhausted In the past, with the old disks, it was ada1, not ada0, and that was = the 250G disk that has been reporting errors when the system was running = off of it (NetBSD 5.1). So I assumed that was the problem. However, = I've replaced the disks with a pair of 320GB disks, and am now having = that same problem and messages both during boot, and when trying to = configure the disks with gpart, for both disks. Is this some sort of size issue? And, is there any way around it? = NetBSD works on the machine, so I assume it's not that the hardware is = deficient in some way with larger PATA disks... - Chris From owner-freebsd-sparc64@FreeBSD.ORG Mon Mar 25 01:46:59 2013 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 2427C75C for ; Mon, 25 Mar 2013 01:46:59 +0000 (UTC) (envelope-from cross+freebsd@distal.com) Received: from mail.distal.com (mail.distal.com [IPv6:2001:470:e24c:200::ae25]) by mx1.freebsd.org (Postfix) with ESMTP id DA8EA12E for ; Mon, 25 Mar 2013 01:46:58 +0000 (UTC) Received: from magrathea.distal.com (magrathea.distal.com [IPv6:2001:470:e24c:200:ea06:88ff:feca:960e]) (authenticated bits=0) by mail.distal.com (8.14.3/8.14.3) with ESMTP id r2P1kvgv004366 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Sun, 24 Mar 2013 21:46:58 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Subject: Re: CAM timeouts on Netra X1 From: Chris Ross In-Reply-To: Date: Sun, 24 Mar 2013 21:46:57 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: "freebsd-sparc64@freebsd.org" X-Mailer: Apple Mail (2.1503) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.2 (mail.distal.com [IPv6:2001:470:e24c:200::ae25]); Sun, 24 Mar 2013 21:46:58 -0400 (EDT) X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2013 01:46:59 -0000 Okay. I noticed both: atapci0: port = 0x10200-0x10207,0x10218-0x1021b,0x10210-0x10217,0x10208-0x1020b,0x10220-0x= 1022f at device 13.0 on pci0 atapci0: using PIO transfers above 137GB as workaround for 48bit DMA = access bug, expect reduced performance and http://lists.freebsd.org/pipermail/freebsd-bugs/2012-January/047385.html Perhaps it's a CAM problem where CAM isn't using PIO on the parts of = the disk it needs to? =20 - Chris On Mar 24, 2013, at 21:20 , Chris Ross wrote: > This may not be sparc64 specific, but. I have a Netra X1 that I've = been netbooting, to eventually install FreeBSD onto its disks. Booting = a recent stable/9. with the old disks (one 80G, one 250G), I would see = the following [sort] of errors during [net]boot: >=20 > (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 = 00 > (ada0:ata2:0:0:0): CAM status: Command timeout > (ada0:ata2:0:0:0): Retrying command > (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 = 00 > (ada0:ata2:0:0:0): CAM status: Command timeout > (ada0:ata2:0:0:0): Retrying command > (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 = 00 > (ada0:ata2:0:0:0): CAM status: Command timeout > (ada0:ata2:0:0:0): Retrying command > (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 = 00 > (ada0:ata2:0:0:0): CAM status: Command timeout > (ada0:ata2:0:0:0): Retrying command > (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 = 00 > (ada0:ata2:0:0:0): CAM status: Command timeout > (ada0:ata2:0:0:0): Error 5, Retries exhausted >=20 > In the past, with the old disks, it was ada1, not ada0, and that was = the 250G disk that has been reporting errors when the system was running = off of it (NetBSD 5.1). So I assumed that was the problem. However, = I've replaced the disks with a pair of 320GB disks, and am now having = that same problem and messages both during boot, and when trying to = configure the disks with gpart, for both disks. >=20 > Is this some sort of size issue? And, is there any way around it? = NetBSD works on the machine, so I assume it's not that the hardware is = deficient in some way with larger PATA disks... >=20 > - Chris >=20 > _______________________________________________ > freebsd-sparc64@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64 > To unsubscribe, send any mail to = "freebsd-sparc64-unsubscribe@freebsd.org" From owner-freebsd-sparc64@FreeBSD.ORG Mon Mar 25 04:31:14 2013 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id B39C2D53 for ; Mon, 25 Mar 2013 04:31:14 +0000 (UTC) (envelope-from cross+freebsd@distal.com) Received: from mail.distal.com (mail.distal.com [IPv6:2001:470:e24c:200::ae25]) by mx1.freebsd.org (Postfix) with ESMTP id 85B448FF for ; Mon, 25 Mar 2013 04:31:14 +0000 (UTC) Received: from magrathea.distal.com (magrathea.distal.com [IPv6:2001:470:e24c:200:ea06:88ff:feca:960e]) (authenticated bits=0) by mail.distal.com (8.14.3/8.14.3) with ESMTP id r2P4V9Sj010901 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO) for ; Mon, 25 Mar 2013 00:31:13 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Subject: Re: CAM timeouts on Netra X1 From: Chris Ross In-Reply-To: Date: Mon, 25 Mar 2013 00:31:09 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: "freebsd-sparc64@freebsd.org" X-Mailer: Apple Mail (2.1503) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.2 (mail.distal.com [IPv6:2001:470:e24c:200::ae25]); Mon, 25 Mar 2013 00:31:13 -0400 (EDT) X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2013 04:31:14 -0000 After messing with this issue for a couple of hours, I'm 99% sure that = the ATA_CAM is the crux of my problem. While fixing that issue would be = the best option, I was trying a "right now" option. I'm not sure how to = build a kernel, and release.iso (or the like) without CAM. I've been = trying numerous things with modified versions of GENERIC, but am not = sure I've gotten anything working the way I want it to. Has anyone else done this sort of custom-kernel-patched-into-a-stable = sort of thing before? - Chris On Mar 24, 2013, at 21:46 , Chris Ross wrote: > Okay. I noticed both: >=20 > atapci0: port = 0x10200-0x10207,0x10218-0x1021b,0x10210-0x10217,0x10208-0x1020b,0x10220-0x= 1022f at device 13.0 on pci0 > atapci0: using PIO transfers above 137GB as workaround for 48bit DMA = access bug, expect reduced performance >=20 > and >=20 > = http://lists.freebsd.org/pipermail/freebsd-bugs/2012-January/047385.html >=20 > Perhaps it's a CAM problem where CAM isn't using PIO on the parts of = the disk it needs to? =20 >=20 > - Chris >=20 > On Mar 24, 2013, at 21:20 , Chris Ross = wrote: >> This may not be sparc64 specific, but. I have a Netra X1 that I've = been netbooting, to eventually install FreeBSD onto its disks. Booting = a recent stable/9. with the old disks (one 80G, one 250G), I would see = the following [sort] of errors during [net]boot: >>=20 >> (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 = 00 >> (ada0:ata2:0:0:0): CAM status: Command timeout >> (ada0:ata2:0:0:0): Retrying command >> (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 = 00 >> (ada0:ata2:0:0:0): CAM status: Command timeout >> (ada0:ata2:0:0:0): Retrying command >> (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 = 00 >> (ada0:ata2:0:0:0): CAM status: Command timeout >> (ada0:ata2:0:0:0): Retrying command >> (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 = 00 >> (ada0:ata2:0:0:0): CAM status: Command timeout >> (ada0:ata2:0:0:0): Retrying command >> (ada0:ata2:0:0:0): READ_DMA48. ACB: 25 00 cf cf b5 40 25 00 00 00 01 = 00 >> (ada0:ata2:0:0:0): CAM status: Command timeout >> (ada0:ata2:0:0:0): Error 5, Retries exhausted >>=20 >> In the past, with the old disks, it was ada1, not ada0, and that was = the 250G disk that has been reporting errors when the system was running = off of it (NetBSD 5.1). So I assumed that was the problem. However, = I've replaced the disks with a pair of 320GB disks, and am now having = that same problem and messages both during boot, and when trying to = configure the disks with gpart, for both disks. >>=20 >> Is this some sort of size issue? And, is there any way around it? = NetBSD works on the machine, so I assume it's not that the hardware is = deficient in some way with larger PATA disks... >>=20 >> - Chris >>=20 >> _______________________________________________ >> freebsd-sparc64@freebsd.org mailing list >> http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64 >> To unsubscribe, send any mail to = "freebsd-sparc64-unsubscribe@freebsd.org" >=20 > _______________________________________________ > freebsd-sparc64@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-sparc64 > To unsubscribe, send any mail to = "freebsd-sparc64-unsubscribe@freebsd.org" From owner-freebsd-sparc64@FreeBSD.ORG Mon Mar 25 11:06:50 2013 Return-Path: Delivered-To: freebsd-sparc64@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 5B572C9 for ; Mon, 25 Mar 2013 11:06:50 +0000 (UTC) (envelope-from owner-bugmaster@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) by mx1.freebsd.org (Postfix) with ESMTP id 4C599D3 for ; Mon, 25 Mar 2013 11:06:50 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.6/8.14.6) with ESMTP id r2PB6ojp007291 for ; Mon, 25 Mar 2013 11:06:50 GMT (envelope-from owner-bugmaster@FreeBSD.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.6/8.14.6/Submit) id r2PB6nm6007289 for freebsd-sparc64@FreeBSD.org; Mon, 25 Mar 2013 11:06:49 GMT (envelope-from owner-bugmaster@FreeBSD.org) Date: Mon, 25 Mar 2013 11:06:49 GMT Message-Id: <201303251106.r2PB6nm6007289@freefall.freebsd.org> X-Authentication-Warning: freefall.freebsd.org: gnats set sender to owner-bugmaster@FreeBSD.org using -f From: FreeBSD bugmaster To: freebsd-sparc64@FreeBSD.org Subject: Current problem reports assigned to freebsd-sparc64@FreeBSD.org X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2013 11:06:50 -0000 Note: to view an individual PR, use: http://www.freebsd.org/cgi/query-pr.cgi?pr=(number). The following is a listing of current problems submitted by FreeBSD users. These represent problem reports covering all versions including experimental development code and obsolete releases. S Tracker Resp. Description -------------------------------------------------------------------------------- o sparc/170663 sparc64 panics with VIA 6421 SATA150 controller on Blade 1500 o sparc/169669 sparc64 Something seems broken in sparc64 TLS or lang/lua o sparc/164227 sparc64 [boot] Can't boot 9.0-RELEASE/sparc64 on Blade 1500 s sparc/164226 sparc64 [cd] Data corruption on 9.0-RELEASE when reading from o sparc/162513 sparc64 mpt(4), mptutil(8) reports variable, erroneous drive i o sparc/141918 sparc64 [ehci] ehci_interrupt: unrecoverable error, controller s sparc/139134 sparc64 kernel output corruption s sparc/107087 sparc64 [hang] system is hung during boot from CD o sparc/105048 sparc64 [trm] trm(4) panics on sparc64 o sparc/104428 sparc64 [nullfs] nullfs panics on E4500 (but not E420) o sparc/71729 sparc64 printf in kernel thread causes panic on SPARC 11 problems total. From owner-freebsd-sparc64@FreeBSD.ORG Mon Mar 25 14:01:28 2013 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 7F5409BD for ; Mon, 25 Mar 2013 14:01:28 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id 1C28C7D for ; Mon, 25 Mar 2013 14:01:27 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.6/8.14.6/ALCHEMY.FRANKEN.DE) with ESMTP id r2PDxpSW045893; Mon, 25 Mar 2013 14:59:51 +0100 (CET) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.6/8.14.6/Submit) id r2PDxpCc045892; Mon, 25 Mar 2013 14:59:51 +0100 (CET) (envelope-from marius) Date: Mon, 25 Mar 2013 14:59:51 +0100 From: Marius Strobl To: Chris Ross Subject: Re: CAM timeouts on Netra X1 Message-ID: <20130325135951.GA45845@alchemy.franken.de> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "freebsd-sparc64@freebsd.org" X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2013 14:01:28 -0000 On Mon, Mar 25, 2013 at 12:31:09AM -0400, Chris Ross wrote: > > After messing with this issue for a couple of hours, I'm 99% sure that the ATA_CAM is the crux of my problem. While fixing that issue would be the best option, I was trying a "right now" option. I'm not sure how to build a kernel, and release.iso (or the like) without CAM. I've been trying numerous things with modified versions of GENERIC, but am not sure I've gotten anything working the way I want it to. > > Has anyone else done this sort of custom-kernel-patched-into-a-stable sort of thing before? > Err, right, ATA_CAM broke ATA_NO_48BIT_DMA. The simplest workaround likely is to use a stock GENERIC and set the hw.ata.ata_dma loader tunable to 0. That will globally disable DMA and not just in cases where 48-bit DMA is needed but should get you working. Once you've managed to install FreeBSD, could you please try whether the following patch fixes that regression? http://people.freebsd.org/~marius/ATA_CAM_NO_48BIT_DMA.diff Marius From owner-freebsd-sparc64@FreeBSD.ORG Mon Mar 25 16:34:06 2013 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D9138178 for ; Mon, 25 Mar 2013 16:34:06 +0000 (UTC) (envelope-from cross+freebsd@distal.com) Received: from mail.distal.com (mail.distal.com [IPv6:2001:470:e24c:200::ae25]) by mx1.freebsd.org (Postfix) with ESMTP id AAAA8F7C for ; Mon, 25 Mar 2013 16:34:06 +0000 (UTC) Received: from zalamar.mm-corp.net (static-66-16-13-46.dsl.cavtel.net [66.16.13.46]) (authenticated bits=0) by mail.distal.com (8.14.3/8.14.3) with ESMTP id r2PGY1d5002004 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 25 Mar 2013 12:34:02 -0400 (EDT) Subject: Re: CAM timeouts on Netra X1 Mime-Version: 1.0 (Apple Message framework v1283) Content-Type: text/plain; charset=us-ascii From: Chris Ross In-Reply-To: <20130325135951.GA45845@alchemy.franken.de> Date: Mon, 25 Mar 2013 12:33:55 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20130325135951.GA45845@alchemy.franken.de> To: Marius Strobl X-Mailer: Apple Mail (2.1283) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.2 (mail.distal.com [206.138.151.250]); Mon, 25 Mar 2013 12:34:03 -0400 (EDT) Cc: "freebsd-sparc64@freebsd.org" X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2013 16:34:06 -0000 On Mar 25, 2013, at 9:59 AM, Marius Strobl wrote: > Err, right, ATA_CAM broke ATA_NO_48BIT_DMA. The simplest workaround > likely is to use a stock GENERIC and set the hw.ata.ata_dma loader > tunable to 0. That will globally disable DMA and not just in cases > where 48-bit DMA is needed but should get you working. > Once you've managed to install FreeBSD, could you please try whether > the following patch fixes that regression? > http://people.freebsd.org/~marius/ATA_CAM_NO_48BIT_DMA.diff Well, I'm net booting to do the install, so I can test it whenever. = :-) That patch applied, except for cam/ata/ata_all.h, which failed to = apply because my copy (stable/9 from Mar 22) didn't have SID_AEN = defined. But, I hand applied that piece to add SID_DMA48, and it then = failed to build as follows: - Chris cc -O2 -pipe -fno-strict-aliasing -Werror -D_KERNEL -DKLD_MODULE = -nostdinc -DHAVE_KERNEL_OPTION_HEADERS -include = /usr/obj/usr/src/sys/GENERIC/opt_global.h -I. -I@ -I@/contrib/altq = -finline-limit=3D15000 --param inline-unit-growth=3D100 --param = large-function-growth=3D1000 -fno-common -g = -I/usr/obj/usr/src/sys/GENERIC -mcmodel=3Dmedany -msoft-float = -ffreestanding -fstack-protector -std=3Diso9899:1999 -fstack-protector = -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes = -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual -Wundef = -Wno-pointer-sign -fformat-extensions -Wmissing-include-dirs = -fdiagnostics-show-option -c = /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c cc1: warnings being treated as errors /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c: In = function 'ad_ioctl': /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c:354: = warning: implicit declaration of function 'ata_device_ioctl' /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c:354: = warning: nested extern declaration of 'ata_device_ioctl' = [-Wnested-externs] /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c: In = function 'ad_init': /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c:397: = warning: implicit declaration of function 'ata_setmode' /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c:397: = warning: nested extern declaration of 'ata_setmode' [-Wnested-externs] /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c: In = function 'ad_set_geometry': /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c:516: = warning: implicit declaration of function 'ata_getparam' /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c:516: = warning: nested extern declaration of 'ata_getparam' [-Wnested-externs] /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c: In = function 'ad_describe': /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c:558: = warning: implicit declaration of function 'ata_unit2str' /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c:558: = warning: nested extern declaration of 'ata_unit2str' [-Wnested-externs] /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c:561: = warning: implicit declaration of function 'ata_satarev2str' /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c:561: = warning: nested extern declaration of 'ata_satarev2str' = [-Wnested-externs] /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c:561: = warning: format '%s' expects type 'char *', but argument 8 has type = 'int' [-Wformat] /usr/src/sys/modules/ata/atadisk/../../../dev/ata/ata-disk.c:561: = warning: format '%s' expects type 'char *', but argument 11 has type = 'int' [-Wformat] *** [ata-disk.o] Error code 1 1 error *** [all] Error code 2 1 error *** [all] Error code 2 1 error *** [modules-all] Error code 2 1 error *** [buildkernel] Error code 2 1 error *** [buildkernel] Error code 2 1 error From owner-freebsd-sparc64@FreeBSD.ORG Mon Mar 25 17:22:08 2013 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id B62B9FFD for ; Mon, 25 Mar 2013 17:22:08 +0000 (UTC) (envelope-from marius@alchemy.franken.de) Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214]) by mx1.freebsd.org (Postfix) with ESMTP id 54F163D3 for ; Mon, 25 Mar 2013 17:22:08 +0000 (UTC) Received: from alchemy.franken.de (localhost [127.0.0.1]) by alchemy.franken.de (8.14.6/8.14.6/ALCHEMY.FRANKEN.DE) with ESMTP id r2PHM4Nt059410; Mon, 25 Mar 2013 18:22:04 +0100 (CET) (envelope-from marius@alchemy.franken.de) Received: (from marius@localhost) by alchemy.franken.de (8.14.6/8.14.6/Submit) id r2PHM31r059409; Mon, 25 Mar 2013 18:22:03 +0100 (CET) (envelope-from marius) Date: Mon, 25 Mar 2013 18:22:03 +0100 From: Marius Strobl To: Chris Ross Subject: Re: CAM timeouts on Netra X1 Message-ID: <20130325172203.GB955@alchemy.franken.de> References: <20130325135951.GA45845@alchemy.franken.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: "freebsd-sparc64@freebsd.org" X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2013 17:22:08 -0000 On Mon, Mar 25, 2013 at 12:33:55PM -0400, Chris Ross wrote: > > On Mar 25, 2013, at 9:59 AM, Marius Strobl wrote: > > Err, right, ATA_CAM broke ATA_NO_48BIT_DMA. The simplest workaround > > likely is to use a stock GENERIC and set the hw.ata.ata_dma loader > > tunable to 0. That will globally disable DMA and not just in cases > > where 48-bit DMA is needed but should get you working. > > Once you've managed to install FreeBSD, could you please try whether > > the following patch fixes that regression? > > http://people.freebsd.org/~marius/ATA_CAM_NO_48BIT_DMA.diff > > Well, I'm net booting to do the install, so I can test it whenever. :-) > > That patch applied, except for cam/ata/ata_all.h, which failed to apply because my copy (stable/9 from Mar 22) didn't have SID_AEN defined. But, I hand applied that piece to add SID_DMA48, and it then failed to build as follows: > Urqs, I forgot the oddness of the (rather pointless) ata(4) module build. Either re-fetch the entire patch or just revert the changes to your local ata-all.h and then manually remove the prototype for ata_cam_begin_transaction() in it. Marius From owner-freebsd-sparc64@FreeBSD.ORG Tue Mar 26 00:29:03 2013 Return-Path: Delivered-To: freebsd-sparc64@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 3E375CCE for ; Tue, 26 Mar 2013 00:29:03 +0000 (UTC) (envelope-from cross+freebsd@distal.com) Received: from mail.distal.com (mail.distal.com [IPv6:2001:470:e24c:200::ae25]) by mx1.freebsd.org (Postfix) with ESMTP id 15A1CBFD for ; Tue, 26 Mar 2013 00:29:02 +0000 (UTC) Received: from magrathea.distal.com (magrathea.distal.com [IPv6:2001:470:e24c:200:ea06:88ff:feca:960e]) (authenticated bits=0) by mail.distal.com (8.14.3/8.14.3) with ESMTP id r2Q0SwRp003470 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=NO); Mon, 25 Mar 2013 20:28:58 -0400 (EDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Subject: Re: CAM timeouts on Netra X1 From: Chris Ross In-Reply-To: <20130325172203.GB955@alchemy.franken.de> Date: Mon, 25 Mar 2013 20:28:58 -0400 Content-Transfer-Encoding: 7bit Message-Id: <5F32C554-AE21-41AD-BE13-EA94BB0647CC@distal.com> References: <20130325135951.GA45845@alchemy.franken.de> <20130325172203.GB955@alchemy.franken.de> To: Marius Strobl X-Mailer: Apple Mail (2.1503) X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.2 (mail.distal.com [IPv6:2001:470:e24c:200::ae25]); Mon, 25 Mar 2013 20:28:59 -0400 (EDT) Cc: "freebsd-sparc64@freebsd.org" X-BeenThere: freebsd-sparc64@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Porting FreeBSD to the Sparc List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Mar 2013 00:29:03 -0000 On Mar 25, 2013, at 13:22 , Marius Strobl wrote: > Urqs, I forgot the oddness of the (rather pointless) ata(4) module > build. Either re-fetch the entire patch or just revert the changes > to your local ata-all.h and then manually remove the prototype for > ata_cam_begin_transaction() in it. Thanks. I had already re-updated my source tree so the patch was reverted, and reapplying it caused a successful build, and I'm no longer seeing the CAM timeouts. I am still loading the OS onto the disks [zfs pools], but I think that's got it. Thanks! - Chris